[Bug 11753] New: Replace jQuery qTip plugin with Bootstrap tooltip on patron search form
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11753 Bug ID: 11753 Summary: Replace jQuery qTip plugin with Bootstrap tooltip on patron search form Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/members/members-home.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 9876 The patron advanced search form uses the jQuery qTip plugin which is out of date and blocks an upgrade of jQuery. The Bootstrap tooltip implementation should be used instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11753 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25215&action=edit Bug 11753 - Replace jQuery qTip plugin with Bootstrap tooltip on patron search form The qTip plugin is out of date and incompatible with recent versions of jQuery. This patch replaces use of qTip on the patron search form with a Bootstrap tooltip implementation. To test, apply the patch and view /cgi-bin/koha/members/members-home.pl - Expand the patron search form by clicking the [+] - Change 'search fields' from 'Standard' to 'Date of birth' - A tooltip should appear giving details about the date format required - Change the 'search fields' to something else. The tooltip should not appear. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25215|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25216&action=edit Bug 11753 - Replace jQuery qTip plugin with Bootstrap tooltip on patron search form The qTip plugin is out of date and incompatible with recent versions of jQuery. This patch replaces use of qTip on the patron search form with a Bootstrap tooltip implementation. To test, apply the patch and view /cgi-bin/koha/members/members-home.pl - Expand the patron search form by clicking the [+] - Change 'search fields' from 'Standard' to 'Date of birth' - A tooltip should appear giving details about the date format required - Change the 'search fields' to something else. The tooltip should not appear. Revision: Removed inclusion of qTip plugin from global header include. The other instance of qTip usage occurs on a page which loads the plugin separately. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11753 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9876 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11753 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11753 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25216|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 25309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25309&action=edit Bug 11753 - Replace jQuery qTip plugin with Bootstrap tooltip on patron search form The qTip plugin is out of date and incompatible with recent versions of jQuery. This patch replaces use of qTip on the patron search form with a Bootstrap tooltip implementation. To test, apply the patch and view /cgi-bin/koha/members/members-home.pl - Expand the patron search form by clicking the [+] - Change 'search fields' from 'Standard' to 'Date of birth' - A tooltip should appear giving details about the date format required - Change the 'search fields' to something else. The tooltip should not appear. Revision: Removed inclusion of qTip plugin from global header include. The other instance of qTip usage occurs on a page which loads the plugin separately. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11753 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11753 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25309|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25339&action=edit Bug 11753 - Replace jQuery qTip plugin with Bootstrap tooltip on patron search form The qTip plugin is out of date and incompatible with recent versions of jQuery. This patch replaces use of qTip on the patron search form with a Bootstrap tooltip implementation. To test, apply the patch and view /cgi-bin/koha/members/members-home.pl - Expand the patron search form by clicking the [+] - Change 'search fields' from 'Standard' to 'Date of birth' - A tooltip should appear giving details about the date format required - Change the 'search fields' to something else. The tooltip should not appear. Revision: Removed inclusion of qTip plugin from global header include. The other instance of qTip usage occurs on a page which loads the plugin separately. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11753 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11753 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org