[Bug 8234] New: Dates are not well sorted on Transfers to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 Priority: P5 - low Change sponsored?: --- Bug ID: 8234 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Dates are not well sorted on Transfers to receive Severity: enhancement Classification: Unclassified OS: All Reporter: sophie.meynieux@biblibre.com Hardware: All Status: NEW Version: unspecified Component: Circulation Product: Koha In "Transfers to receive" table, date are not well sorted. DataTable should be used as in other tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5345 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |adrien.saurat@biblibre.com --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> --- They are sorted, but with an UK date format. Parameter : dateFormat: 'uk' For the 10th of June, 2012, we have the following date in France: 10/06/2012 But the DataTable consider this to be 06/10/2012 This breaks the sorting for Koha installations using non UK-dates. The problem could be present in other pages. I still have to see how to correct this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |adrien.saurat@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 --- Comment #2 from Adrien SAURAT <adrien.saurat@biblibre.com> --- But shouldn't this MM/DD/YY way of writing dates be the US format? In fact, it looks like the case was supposed to be handled (there's a IF checking for metric format), but it doesn't work well. $("#transferst[% branchesloo.branchcode %]").tablesorter({[% IF ( branchesloo.dateformat_metric ) %] dateFormat: 'uk',[% END %] sortList: [[0,0]], headers: { 1: { sorter: 'articles' }} }); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 --- Comment #3 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 12432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12432&action=edit proposed patch TEST PLAN : 1) As dateformat (in sysprefs) you have to chose the metric system (dd/mm/yyyy). 2) Prepare several transfers from one library to another. 3) Change the dates of these tranfers (table "branchtransfers"), you especially have to create a possible confusion between days and months. 4) Display the "Transfers to receive page". The sort doesn't work properly as dates are treated like "MM/DD/YYYY" dates. Once the patch is applied, the metric system format is handled ok. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |melia@bywatersolutions.com --- Comment #4 from Melia Meggs <melia@bywatersolutions.com> --- Before applying the patch, with dateformat set to dd/mm/yyyy, the dates of transfer on my transfers to receive page were incorrectly organized like this: 03/11/2012 - this is Nov 3 09/09/2012 - this is Sept 9 12/09/2012 - this is Sept 12 12/10/2012 - this is Oct 12 After applying the patch, with dateformat set to dd/mm/yyyy, the dates of transfer on my transfers to receive page are correctly organized like this: 09/09/2012 - this is Sept 9 12/09/2012 - this is Sept 12 12/10/2012 - this is Oct 12 03/11/2012 - this is Nov 3 So it looks like this works! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 --- Comment #5 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 12797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12797&action=edit [Signed off] Bug 8234 - Dates are not well sorted on transfers to receive -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12432|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: one line patch passed QA I suspect there's something wrong with sorting when your syspref is iso, but it was already the case before this patch (untested, but we deal only dateformat_metric yes / no) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|unspecified |rel_3_8 QA Contact| |paul.poulain@biblibre.com --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master I just tested iso case (see my previous comment), it's OK, so forget the comment ;-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- (it's not an ENH, but a minor bugfix) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |liz@catalyst.net.nz Resolution|--- |FIXED --- Comment #10 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Pushed to 3.6.x will be in 3.6.11. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org