[Bug 8674] New: Need a delete biblios script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8674 Priority: P5 - low Change sponsored?: --- Bug ID: 8674 Assignee: koha-bugs@lists.koha-community.org Summary: Need a delete biblios script Severity: enhancement Classification: Unclassified OS: All Reporter: jonathan.druart@biblibre.com Hardware: All Status: NEW Version: unspecified Component: Acquisitions Product: Koha We need a script to delete biblios -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8674 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8674 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11779&action=edit Bug 8438: Adds script batchdeletebiblios This script batch deletes biblios which contain a biblionumber present in file passed in parameter. If one biblio has items, it is not deleted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8674 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11779|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11780&action=edit Bug 8674: Adds script batchdeletebiblios This script batch deletes biblios which contain a biblionumber present in file passed in parameter. If one biblio has items, it is not deleted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8674 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8674 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8674 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no Blocks| |8149 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8674 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8674 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I realize that we don't really have firm coding guidelines for command line scripts (http://wiki.koha-community.org/wiki/Coding_Guidelines#Command-line_argument_... sounds preliminary), but I'm inclined to not sign off on this script because it offers no help to the user. Running it with no arguments doesn't give me feedback about specifying a file, and running it with "--help" returns no help. Other than that the script seems to be working as expected. Records with items are not deleted, records without items are deleted and added to oldbiblio. I wonder if it would be useful to show a different message if a biblionumber is not found? Re-running the script on a file of already-deleted records returns "OK" for each. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8674 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11887&action=edit Bug 8674: Followup: Add POD for misc/batchdeletebiblios.pl (In reply to comment #3) Hi Owen,
I realize that we don't really have firm coding guidelines for command line scripts (http://wiki.koha-community.org/wiki/Coding_Guidelines#Command- line_argument_conventions sounds preliminary), but I'm inclined to not sign off on this script because it offers no help to the user. Running it with no arguments doesn't give me feedback about specifying a file, and running it with "--help" returns no help.
I wonder if it would be useful to show a different message if a biblionumber is not found? Re-running the script on a file of already-deleted records returns "OK" for each. I think it is a problem in DelBiblio. If this routine returns an error or die,
Yes, you are totally right. Thank you. the script will know there is a problem. This patch adds POD for the script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8674 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye@biblibre.co | |m --- Comment #5 from delaye <stephane.delaye@biblibre.com> --- i test in a sandbox . it's ok perl batchdeletebiblios.pl file name or perl batchdeletebiblios.pl /home/directory_name/file_name -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8674 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11780|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11919&action=edit Bug 8674: Adds script batchdeletebiblios This script batch deletes biblios which contain a biblionumber present in file passed in parameter. If one biblio has items, it is not deleted. http://bugs.koha-community.org/show_bug.cgi?id=8674 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created file with biblionumbers for bibs with and without items. Only the bibs without items were deleted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8674 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11887|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11920&action=edit Bug 8674: Followup: Add POD for misc/batchdeletebiblios.pl Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8674 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8674 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- I should note that I did test the help, it displays when the script is run with no arguments, or when -h or --help is passed. (In reply to comment #7)
Created attachment 11920 [details] Bug 8674: Followup: Add POD for misc/batchdeletebiblios.pl
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8674 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * 0 side effect risk: new script in misc * script located at same place as many other batchsomething, so it's OK * passes koha-qa.pl after a tiny follow-up for perlcritic ( file opening was not perlcritic compliant) passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8674 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 12647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12647&action=edit Bug 8674 follow-up Fix perlcritic error -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8674 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8674 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Component|Acquisitions |Cataloging Assignee|jonathan.druart@biblibre.co |gmcharlt@gmail.com |m | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org