[Bug 16239] New: Upgrade Bootstrap in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Bug ID: 16239 Summary: Upgrade Bootstrap in the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 15883 Blocks: 14546 Now that we are on a path to getting a jQuery upgrade, it's time to start working on an upgrade to Bootstrap in the staff client. I propose that this upgrade be done as a precursor to (rather than simultaneously with) a full conversion of the staff client to a Bootstrap grid (Bug 14546). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 [Bug 14546] Make staff client templates responsive https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 [Bug 15883] Upgrade jQuery from v1.7.2 in the staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- For anyone in fear of Bootstrap v3 not working with older browsers, I just want to add that there are third-party polyfills/shims available online, which allow Bootstrap v3 to work more or less with older browsers like IE7 and IE8. DSpace JSPUI uses Bootstrap v3, and I've utilized these other tools to make DSpace work correctly for older browsers (which are sadly still required by corporate/government IT departments). While I don't think it's Koha's responsibility to deal with that third-party support at all, I just wanted to put it on the record that individuals should be able to get it work on their own, if they require it. In other words, hurray for Owen being awesome! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- (In reply to David Cook from comment #1)
In other words, hurray for Owen being awesome!
Seconded! Bootstrap in the Staff client would be awesome as well. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56159&action=edit Bug 16239: Update Bootstrap to 3.3.7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56160&action=edit 16239: Add Bootstrap theme css -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56161&action=edit Bug 16239: Update templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56162&action=edit Bug 16239: Update javascript files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56163&action=edit Bug 16239: Update css files Test plan: 1) Apply the patch 2) Try to go through interface to find problems, inconsistencies, etc. 3) Read the diff Migration guide for bootstrap: http://getbootstrap.com/migration/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- I am pretty sure it's not perfect yet, but I'd like others to have a look at this... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #9 from Marc Véron <veron@veron.ch> --- Created attachment 56201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56201&action=edit Radioboxes, checkboxes and a label do not dieplay as expected First findings: It seems that radio boxes and checkboxes are moved after applying the patch. See attached PDF (PDF bookmarks = comments) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56159|0 |1 is obsolete| | --- Comment #10 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56329&action=edit Bug 16239: Update Bootstrap to 3.3.7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56160|0 |1 is obsolete| | --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56330&action=edit 16239: Add Bootstrap theme css -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56161|0 |1 is obsolete| | --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56331&action=edit Bug 16239: Update templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56162|0 |1 is obsolete| | --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56332&action=edit Bug 16239: Update javascript files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56163|0 |1 is obsolete| | --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56333&action=edit Bug 16239: Update css files Test plan: 1) Apply the patch 2) Try to go through interface to find problems, inconsistencies, etc. 3) Read the diff Migration guide for bootstrap: http://getbootstrap.com/migration/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56334&action=edit Bug 16239: Advanced cataloguing editor changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56335&action=edit Bug 16239: Update searchengine mappings configuration page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Thanks for testing Marc! I hope I've addressed the issues you point at and rebased on master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Josef did you use the Bootstrap download customizer? Our 2.x Bootstrap js is limited to these plugins: bootstrap-transition.js, bootstrap-modal.js, bootstrap-dropdown.js, bootstrap-tooltip.js, bootstrap-popover.js, bootstrap-affix.js, bootstrap-alert.js, bootstrap-button.js I'm pretty sure the 2.x Bootstrap CSS is limited too, but unfortunately the file doesn't contain a list of the included components. I'll have to check my notes at home. It think it would be worthwhile to continue to use the Bootstrap download customizer so that we're not including functionality we're not using and thus keeping JS and CSS file size smaller. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #19 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Owen Leonard from comment #18)
Josef did you use the Bootstrap download customizer? Our 2.x Bootstrap js is limited to these plugins:
I didn't, but I agree I should ;) I'll try it and submit followup, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56329|0 |1 is obsolete| | --- Comment #20 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56529&action=edit Bug 16239: Update Bootstrap to 3.3.7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56330|0 |1 is obsolete| | --- Comment #21 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56530&action=edit 16239: Add Bootstrap theme css -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56331|0 |1 is obsolete| | --- Comment #22 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56531&action=edit Bug 16239: Update templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56332|0 |1 is obsolete| | --- Comment #23 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56532&action=edit Bug 16239: Update javascript files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56333|0 |1 is obsolete| | --- Comment #24 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56533&action=edit Bug 16239: Update css files Test plan: 1) Apply the patch 2) Try to go through interface to find problems, inconsistencies, etc. 3) Read the diff Migration guide for bootstrap: http://getbootstrap.com/migration/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56334|0 |1 is obsolete| | --- Comment #25 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56534&action=edit Bug 16239: Advanced cataloguing editor changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56335|0 |1 is obsolete| | --- Comment #26 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56535&action=edit Bug 16239: Update searchengine mappings configuration page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #27 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56536&action=edit Bug 16239: Customize bootstrap files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #28 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56537&action=edit Bug 16239: Fixing some forms display issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #29 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56538&action=edit Bug 16239: Get rid of icon-* classes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #30 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56539&action=edit Bug 16239: Fix forms in tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #31 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56563&action=edit Config of bootstrap customization I'm adding the configuration I used for generating customized bootstrap -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56529|0 |1 is obsolete| | Attachment #56530|0 |1 is obsolete| | Attachment #56531|0 |1 is obsolete| | Attachment #56532|0 |1 is obsolete| | Attachment #56533|0 |1 is obsolete| | Attachment #56534|0 |1 is obsolete| | Attachment #56535|0 |1 is obsolete| | Attachment #56536|0 |1 is obsolete| | Attachment #56537|0 |1 is obsolete| | Attachment #56538|0 |1 is obsolete| | Attachment #56539|0 |1 is obsolete| | --- Comment #32 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56729&action=edit Bug 16239: Update Bootstrap to 3.3.7 Customization tool used. Javascript modules: alert button dropdown modal tooltip popover tab affix collapse transition CSS modules: type code grid tables forms buttons responsive-utilities button-groups input-groups navs navbar breadcrumbs pagination pager labels badges thumbnails alerts progress-bars media list-group panels responsive-embed close component-animations dropdowns tooltip popovers modals Test plan: 1) Apply the patch 2) Try to go through interface to find problems, inconsistencies, etc. 3) Read the diff Migration guide for bootstrap: http://getbootstrap.com/migration/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #33 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56730&action=edit Bug 16239: Update templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #34 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56731&action=edit Bug 16239: Update css files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #35 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56732&action=edit Bug 16239: Update javascript files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #36 from Josef Moravec <josef.moravec@gmail.com> --- I've rebased and squashed patches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56729|0 |1 is obsolete| | --- Comment #37 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57016&action=edit Bug 16239: Update Bootstrap to 3.3.7 Customization tool used. Javascript modules: alert button dropdown modal tooltip popover tab affix collapse transition CSS modules: type code grid tables forms buttons responsive-utilities button-groups input-groups navs navbar breadcrumbs pagination pager labels badges thumbnails alerts progress-bars media list-group panels responsive-embed close component-animations dropdowns tooltip popovers modals Test plan: 1) Apply the patch 2) Try to go through interface to find problems, inconsistencies, etc. 3) Read the diff Migration guide for bootstrap: http://getbootstrap.com/migration/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56730|0 |1 is obsolete| | --- Comment #38 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57017&action=edit Bug 16239: Update templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56731|0 |1 is obsolete| | --- Comment #39 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57018&action=edit Bug 16239: Update css files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56732|0 |1 is obsolete| | --- Comment #40 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57019&action=edit Bug 16239: Update javascript files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #41 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57020&action=edit Bug 16239: Adapt new housebound module template to Bootstrap 3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #42 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57021&action=edit Bug 16239: Polishing things -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #43 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57022&action=edit Bug 16239: Rebased on master on 2016-11-01, commit 6001765 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57016|0 |1 is obsolete| | --- Comment #44 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57374&action=edit Bug 16239: Update Bootstrap to 3.3.7 Customization tool used. Javascript modules: alert button dropdown modal tooltip popover tab affix collapse transition CSS modules: type code grid tables forms buttons responsive-utilities button-groups input-groups navs navbar breadcrumbs pagination pager labels badges thumbnails alerts progress-bars media list-group panels responsive-embed close component-animations dropdowns tooltip popovers modals Test plan: 1) Apply the patch 2) Try to go through interface to find problems, inconsistencies, etc. 3) Read the diff Migration guide for bootstrap: http://getbootstrap.com/migration/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57017|0 |1 is obsolete| | --- Comment #45 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57375&action=edit Bug 16239: Update templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57018|0 |1 is obsolete| | --- Comment #46 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57376&action=edit Bug 16239: Update css files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57019|0 |1 is obsolete| | --- Comment #47 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57377&action=edit Bug 16239: Update javascript files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57020|0 |1 is obsolete| | --- Comment #48 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57378&action=edit Bug 16239: Adapt new housebound module template to Bootstrap 3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57021|0 |1 is obsolete| | --- Comment #49 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57379&action=edit Bug 16239: Polishing things -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57022|0 |1 is obsolete| | --- Comment #50 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57381&action=edit Bug 16239: Rebased on master on 2016-11-09, commit 80c80ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #51 from Owen Leonard <oleonard@myacpl.org> ---
It think it would be worthwhile to continue to use the Bootstrap download customizer so that we're not including functionality we're not using and thus keeping JS and CSS file size smaller.
Do we need tab, affix, and collapse? tab and collapse are currently being provided by jQueryUI. We should pick one or the other. Overall everything looks great, but I found some issues: - <caption> inheriting the color #777 from the default Bootstrap CSS (should be black). - The MARC preview modal on the detail page is broken. There is some in-page CSS which changes the width of that modal (and some others -- cataloging merge for instance), and the update has broken it. - DataTables "Processing" box which shows while tables are rendering looks bad. - If you have translations installed with sub-languages (like en + en-GB), the menu link color on hover is white and thus unreadable. - Radio button alignment on the Calendar entry form is off - Split buttons wrapping badly on saved reports page and serials search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57374|0 |1 is obsolete| | --- Comment #52 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57416&action=edit Bug 16239: Update Bootstrap to 3.3.7 Customization tool used. Javascript modules: alert button dropdown modal tooltip popover transition CSS modules: type code grid tables forms buttons responsive-utilities button-groups input-groups navs navbar breadcrumbs pagination pager labels badges thumbnails alerts progress-bars media list-group panels responsive-embed close component-animations dropdowns tooltip popovers modals Test plan: 1) Apply the patch 2) Try to go through interface to find problems, inconsistencies, etc. 3) Read the diff Migration guide for bootstrap: http://getbootstrap.com/migration/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57375|0 |1 is obsolete| | --- Comment #53 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57417&action=edit Bug 16239: Update templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57376|0 |1 is obsolete| | --- Comment #54 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57418&action=edit Bug 16239: Update css files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57377|0 |1 is obsolete| | Attachment #57378|0 |1 is obsolete| | Attachment #57379|0 |1 is obsolete| | Attachment #57381|0 |1 is obsolete| | --- Comment #55 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57419&action=edit Bug 16239: Update javascript files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #56 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Owen Leonard from comment #51)
Do we need tab, affix, and collapse? tab and collapse are currently being provided by jQueryUI. We should pick one or the other.
I agree that we shouldn't duplicate the functionalities, so I removed these 3 modules and bootstrap js has 7 kB less in size now
Overall everything looks great, but I found some issues:
- <caption> inheriting the color #777 from the default Bootstrap CSS (should be black).
Fixed
- The MARC preview modal on the detail page is broken. There is some in-page CSS which changes the width of that modal (and some others -- cataloging merge for instance), and the update has broken it.
There were some other I fixed before, but I missed this one. Now fixed.
- DataTables "Processing" box which shows while tables are rendering looks bad.
Should be fixed.
- If you have translations installed with sub-languages (like en + en-GB), the menu link color on hover is white and thus unreadable.
Fixed, look at it please, if it's ok or need adjusting more
- Radio button alignment on the Calendar entry form is off
Fixed
- Split buttons wrapping badly on saved reports page and serials search results
It's not as easy as it could looks like... I tried solution from here: https://github.com/twbs/bootstrap/issues/9939, another possibility is using flex, if we decide we can adapt it, see http://caniuse.com/#search=flexbox for browser support. I also squashed the patches again. I hope I haven't break anything. Thanks for testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56563|0 |1 is obsolete| | --- Comment #57 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57420&action=edit Config of bootstrap customization -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56201|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57416|0 |1 is obsolete| | --- Comment #58 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57772&action=edit Bug 16239: Update Bootstrap to 3.3.7 Customization tool used. Javascript modules: alert button dropdown modal tooltip popover transition CSS modules: type code grid tables forms buttons responsive-utilities button-groups input-groups navs navbar breadcrumbs pagination pager labels badges thumbnails alerts progress-bars media list-group panels responsive-embed close component-animations dropdowns tooltip popovers modals Test plan: 1) Apply the patch 2) Try to go through interface to find problems, inconsistencies, etc. 3) Read the diff Migration guide for bootstrap: http://getbootstrap.com/migration/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57417|0 |1 is obsolete| | --- Comment #59 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57773&action=edit Bug 16239: Update templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57418|0 |1 is obsolete| | --- Comment #60 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57774&action=edit Bug 16239: Update css files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57419|0 |1 is obsolete| | --- Comment #61 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57775&action=edit Bug 16239: Update javascript files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #62 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57776&action=edit Bug 16239: Use inline-block for split buttons only in tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #63 from Josef Moravec <josef.moravec@gmail.com> --- Rebased on master
- Split buttons wrapping badly on saved reports page and serials search results
It's not as easy as it could looks like... I tried solution from here: https://github.com/twbs/bootstrap/issues/9939, another possibility is using flex, if we decide we can adapt it, see http://caniuse.com/#search=flexbox for browser support.
I added more specifity for the split button style just to affect only the buttons in tables, not other (like in toolbars for example) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57772|0 |1 is obsolete| | --- Comment #64 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58067&action=edit Bug 16239: Update Bootstrap to 3.3.7 Customization tool used. Javascript modules: alert button dropdown modal tooltip popover transition CSS modules: type code grid tables forms buttons responsive-utilities button-groups input-groups navs navbar breadcrumbs pagination pager labels badges thumbnails alerts progress-bars media list-group panels responsive-embed close component-animations dropdowns tooltip popovers modals Test plan: 1) Apply the patch 2) Try to go through interface to find problems, inconsistencies, etc. 3) Read the diff Migration guide for bootstrap: http://getbootstrap.com/migration/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57773|0 |1 is obsolete| | --- Comment #65 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58068&action=edit Bug 16239: Update templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57774|0 |1 is obsolete| | --- Comment #66 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58069&action=edit Bug 16239: Update css files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57775|0 |1 is obsolete| | --- Comment #67 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58070&action=edit Bug 16239: Update javascript files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57776|0 |1 is obsolete| | --- Comment #68 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58071&action=edit Bug 16239: Use inline-block for split buttons only in tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17398 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58067|0 |1 is obsolete| | --- Comment #69 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58317&action=edit Bug 16239: Update Bootstrap to 3.3.7 Customization tool used. Javascript modules: alert button dropdown modal tooltip popover transition CSS modules: type code grid tables forms buttons responsive-utilities button-groups input-groups navs navbar breadcrumbs pagination pager labels badges thumbnails alerts progress-bars media list-group panels responsive-embed close component-animations dropdowns tooltip popovers modals Test plan: 1) Apply the patch 2) Try to go through interface to find problems, inconsistencies, etc. 3) Read the diff Migration guide for bootstrap: http://getbootstrap.com/migration/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58317|0 |1 is obsolete| | --- Comment #70 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58318&action=edit [SIGNED-OFF] Bug 16239: Update Bootstrap to 3.3.7 Customization tool used. Javascript modules: alert button dropdown modal tooltip popover transition CSS modules: type code grid tables forms buttons responsive-utilities button-groups input-groups navs navbar breadcrumbs pagination pager labels badges thumbnails alerts progress-bars media list-group panels responsive-embed close component-animations dropdowns tooltip popovers modals Test plan: 1) Apply the patch 2) Try to go through interface to find problems, inconsistencies, etc. 3) Read the diff Migration guide for bootstrap: http://getbootstrap.com/migration/ Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58068|0 |1 is obsolete| | --- Comment #71 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58319&action=edit [SIGNED-OFF] Bug 16239: Update templates Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58069|0 |1 is obsolete| | --- Comment #72 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58320&action=edit [SIGNED-OFF] Bug 16239: Update css files Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58070|0 |1 is obsolete| | --- Comment #73 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58321&action=edit [SIGNED-OFF] Bug 16239: Update javascript files Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58071|0 |1 is obsolete| | --- Comment #74 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58322&action=edit [SIGNED-OFF] Bug 16239: Use inline-block for split buttons only in tables Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #75 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58323&action=edit Bug 16239 [CSS Follow-up] Upgrade Bootstrap in the staff client This followup tweaks some CSS and markup in order to correct conflicts between default Bootstrap styles and the expected (previous) style of the staff client. Included: - Corrections to the widths of some modals. - Corrections to the style of the <pre> tag, seen often in MARC preview modals. - Corrections to the default active and hover states for dropdown menus. To test, apply the patch and view various pages which use Bootstrap modals, confirming that they look correct. - Add order from staged file MARC preview - Add order from external source MARC preview - Cataloging record merge MARC preview - Batch record modification MARC preview - Authorities Z39.50 search MARC preview -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Needs Signoff |Patch doesn't apply --- Comment #76 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58318|0 |1 is obsolete| | --- Comment #77 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58678&action=edit Bug 16239: Update Bootstrap to 3.3.7 Customization tool used. Javascript modules: alert button dropdown modal tooltip popover transition CSS modules: type code grid tables forms buttons responsive-utilities button-groups input-groups navs navbar breadcrumbs pagination pager labels badges thumbnails alerts progress-bars media list-group panels responsive-embed close component-animations dropdowns tooltip popovers modals Test plan: 1) Apply the patch 2) Try to go through interface to find problems, inconsistencies, etc. 3) Read the diff Migration guide for bootstrap: http://getbootstrap.com/migration/ Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58319|0 |1 is obsolete| | --- Comment #78 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58679&action=edit Bug 16239: Update templates Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58320|0 |1 is obsolete| | --- Comment #79 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58680&action=edit Bug 16239: Update css files Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58321|0 |1 is obsolete| | --- Comment #80 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58681&action=edit Bug 16239: Update javascript files Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58322|0 |1 is obsolete| | --- Comment #81 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58682&action=edit Bug 16239: Use inline-block for split buttons only in tables Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58323|0 |1 is obsolete| | --- Comment #82 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58683&action=edit Bug 16239 [CSS Follow-up] Upgrade Bootstrap in the staff client This followup tweaks some CSS and markup in order to correct conflicts between default Bootstrap styles and the expected (previous) style of the staff client. Included: - Corrections to the widths of some modals. - Corrections to the style of the <pre> tag, seen often in MARC preview modals. - Corrections to the default active and hover states for dropdown menus. To test, apply the patch and view various pages which use Bootstrap modals, confirming that they look correct. - Add order from staged file MARC preview - Add order from external source MARC preview - Cataloging record merge MARC preview - Batch record modification MARC preview - Authorities Z39.50 search MARC preview -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58683|0 |1 is obsolete| | --- Comment #83 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 58691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58691&action=edit Bug 16239 [CSS Follow-up] Upgrade Bootstrap in the staff client This followup tweaks some CSS and markup in order to correct conflicts between default Bootstrap styles and the expected (previous) style of the staff client. Included: - Corrections to the widths of some modals. - Corrections to the style of the <pre> tag, seen often in MARC preview modals. - Corrections to the default active and hover states for dropdown menus. To test, apply the patch and view various pages which use Bootstrap modals, confirming that they look correct. - Add order from staged file MARC preview - Add order from external source MARC preview - Cataloging record merge MARC preview - Batch record modification MARC preview - Authorities Z39.50 search MARC preview Signed-off-by: Claire <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58691|0 |1 is obsolete| | --- Comment #84 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 58697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58697&action=edit Bug 16239 [CSS Follow-up] Upgrade Bootstrap in the staff client This followup tweaks some CSS and markup in order to correct conflicts between default Bootstrap styles and the expected (previous) style of the staff client. Included: - Corrections to the widths of some modals. - Corrections to the style of the <pre> tag, seen often in MARC preview modals. - Corrections to the default active and hover states for dropdown menus. To test, apply the patch and view various pages which use Bootstrap modals, confirming that they look correct. - Add order from staged file MARC preview - Add order from external source MARC preview - Cataloging record merge MARC preview - Batch record modification MARC preview - Authorities Z39.50 search MARC preview Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #85 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Some quick remarks and questions: - Is it expected to have these "big" buttons everywhere? Why do we want to have bigger buttons? Note that some buttons have not been converted. - Some JS code have been commented in cateditor-ui.inc. I did not get why it is for. We should either add a comment to explain why it is commented, remove the code or let it as before. Otherwise everything looks fine, great job! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #86 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58722&action=edit Bug 16239: Update Bootstrap's license on the about page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #87 from Josef Moravec <josef.moravec@gmail.com> --- Thanks for testing and feedback Jonathan! (In reply to Jonathan Druart from comment #85)
Some quick remarks and questions: - Is it expected to have these "big" buttons everywhere? Why do we want to have bigger buttons?
The buttons in bootstrap 3 are a bit bigger than in version 2 by default. So button "levels" in Koha remains the same, but the absolute size of button is different. We can shift it down in Koha if we really wan't, but I don't think it is neccesary - from my point of view it more comfortable to use bigger buttons, but it's just my opinion, I don't have any data about that for now...
Note that some buttons have not been converted.
Many buttons weren't transformed to bootstrap ever yet, I plan to make followup (omnibus) bug for using bootstrap everywhere where it makes sense. Mayby some buttons which are new due to continuing the work on Koha master, I updated this patchset about a month ago - I can make a followup, or we can decide to make it on another bug, what do you think?
- Some JS code have been commented in cateditor-ui.inc. I did not get why it is for. We should either add a comment to explain why it is commented, remove the code or let it as before.
Yep, we should remove this code, it was for styling of modals, which is now made differently. I'll add the followup patch
Otherwise everything looks fine, great job!
Thanks! ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #88 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58729&action=edit Bug 16239: Followup - remove unusable js from cateditor-ui.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17873 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17873 [Bug 17873] Make all buttons Bootstrap styled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #89 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Josef Moravec from comment #87)
Many buttons weren't transformed to bootstrap ever yet, I plan to make followup (omnibus) bug for using bootstrap everywhere where it makes sense.
Bug 17873 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58678|0 |1 is obsolete| | --- Comment #90 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58731&action=edit Bug 16239: Update Bootstrap to 3.3.7 Customization tool used. Javascript modules: alert button dropdown modal tooltip popover transition CSS modules: type code grid tables forms buttons responsive-utilities button-groups input-groups navs navbar breadcrumbs pagination pager labels badges thumbnails alerts progress-bars media list-group panels responsive-embed close component-animations dropdowns tooltip popovers modals Test plan: 1) Apply the patch 2) Try to go through interface to find problems, inconsistencies, etc. 3) Read the diff Migration guide for bootstrap: http://getbootstrap.com/migration/ Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58679|0 |1 is obsolete| | --- Comment #91 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58732&action=edit Bug 16239: Update templates Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58680|0 |1 is obsolete| | --- Comment #92 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58733&action=edit Bug 16239: Update css files Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58681|0 |1 is obsolete| | --- Comment #93 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58734&action=edit Bug 16239: Update javascript files Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58682|0 |1 is obsolete| | --- Comment #94 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58735&action=edit Bug 16239: Use inline-block for split buttons only in tables Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58697|0 |1 is obsolete| | --- Comment #95 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58736&action=edit Bug 16239 [CSS Follow-up] Upgrade Bootstrap in the staff client This followup tweaks some CSS and markup in order to correct conflicts between default Bootstrap styles and the expected (previous) style of the staff client. Included: - Corrections to the widths of some modals. - Corrections to the style of the <pre> tag, seen often in MARC preview modals. - Corrections to the default active and hover states for dropdown menus. To test, apply the patch and view various pages which use Bootstrap modals, confirming that they look correct. - Add order from staged file MARC preview - Add order from external source MARC preview - Cataloging record merge MARC preview - Batch record modification MARC preview - Authorities Z39.50 search MARC preview Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58722|0 |1 is obsolete| | --- Comment #96 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58737&action=edit Bug 16239: Update Bootstrap's license on the about page Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58729|0 |1 is obsolete| | --- Comment #97 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58738&action=edit Bug 16239: Followup - remove unusable js from cateditor-ui.inc Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #98 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Josef, Yes, everything else on another bug report :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17874 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17874 [Bug 17874] Bug 16239 followup - update bootstrap 3 usage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #99 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Jonathan Druart from comment #98)
Josef, Yes, everything else on another bug report :)
;) I started working on it ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #100 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Josef, Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer@bsz-bw.de --- Comment #101 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Obviously: This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17929 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 [Bug 17929] You can't edit indicators in the cataloging screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #102 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Update your QA tests repo! commit 89a86cceb79b412a26b68cd8c2e4907060af2f6d Author: Jonathan Druart <jonathan.druart@gmail.com> Date: Wed Jan 18 13:16:57 2017 +0100 Add checkts for Bootstrap v3 (bug 16239) (arf typo) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #103 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Jonathan Druart from comment #102)
Update your QA tests repo!
commit 89a86cceb79b412a26b68cd8c2e4907060af2f6d Author: Jonathan Druart <jonathan.druart@gmail.com> Date: Wed Jan 18 13:16:57 2017 +0100
Add checkts for Bootstrap v3 (bug 16239)
(arf typo)
Great, thank you Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18005 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18005 [Bug 18005] Pagination of the search result displayed wrong -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18061 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18061 [Bug 18061] Enhance items page (moredetail.pl) with Bootstrap 3 panels -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19634 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19634 [Bug 19634] Advanced editor - Rancor - error in display of macro editor in firefox -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org