https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #56 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Owen Leonard from comment #51)
Do we need tab, affix, and collapse? tab and collapse are currently being provided by jQueryUI. We should pick one or the other.
I agree that we shouldn't duplicate the functionalities, so I removed these 3 modules and bootstrap js has 7 kB less in size now
Overall everything looks great, but I found some issues:
- <caption> inheriting the color #777 from the default Bootstrap CSS (should be black).
Fixed
- The MARC preview modal on the detail page is broken. There is some in-page CSS which changes the width of that modal (and some others -- cataloging merge for instance), and the update has broken it.
There were some other I fixed before, but I missed this one. Now fixed.
- DataTables "Processing" box which shows while tables are rendering looks bad.
Should be fixed.
- If you have translations installed with sub-languages (like en + en-GB), the menu link color on hover is white and thus unreadable.
Fixed, look at it please, if it's ok or need adjusting more
- Radio button alignment on the Calendar entry form is off
Fixed
- Split buttons wrapping badly on saved reports page and serials search results
It's not as easy as it could looks like... I tried solution from here: https://github.com/twbs/bootstrap/issues/9939, another possibility is using flex, if we decide we can adapt it, see http://caniuse.com/#search=flexbox for browser support. I also squashed the patches again. I hope I haven't break anything. Thanks for testing! -- You are receiving this mail because: You are watching all bug changes.