[Bug 41580] New: Tidy kohaTable block - tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Bug ID: 41580 Summary: Tidy kohaTable block - tools Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@gmail.com Status|NEW |ASSIGNED Blocks| |41324 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 [Bug 41324] Tidy kohaTable block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191163&action=edit Bug 41580: Tidy kohaTable - tools/batch_delete_records.tt Patch from commit 4cc3cd0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191164&action=edit Bug 41580: Tidy kohaTable - tools/batch_modify_holds.tt Patch from commit 4e7b21d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191165&action=edit Bug 41580: Tidy kohaTable - tools/batch_record_modification.tt Patch from commit a8cd9fe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191166&action=edit Bug 41580: Tidy kohaTable - tools/holidays.tt Patch from commit 1767e13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191167&action=edit Bug 41580: Tidy kohaTable - tools/inventory.tt Patch from commit b87b416 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191168&action=edit Bug 41580: Tidy kohaTable - tools/manage-marc-import.tt Patch from commit 54a27c1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191169&action=edit Bug 41580: Tidy kohaTable - tools/modborrowers.tt Patch from commit c175ba8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191170&action=edit Bug 41580: Tidy kohaTable - tools/upload.tt Patch from commit 0c45d77 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191171&action=edit Bug 41580: tools - auto tidy Patch from commit 52c6b50 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39715 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39715 [Bug 39715] Do not quote DataTables options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41562 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41562 [Bug 41562] Introduce the concept of "stores" for regular javascript -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191163|0 |1 is obsolete| | Attachment #191164|0 |1 is obsolete| | Attachment #191165|0 |1 is obsolete| | Attachment #191166|0 |1 is obsolete| | Attachment #191167|0 |1 is obsolete| | Attachment #191168|0 |1 is obsolete| | Attachment #191169|0 |1 is obsolete| | Attachment #191170|0 |1 is obsolete| | Attachment #191171|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191697&action=edit Bug 41580: Tidy kohaTable - tools/batch_delete_records.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191698&action=edit Bug 41580: Tidy kohaTable - tools/batch_modify_holds.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191699&action=edit Bug 41580: Tidy kohaTable - tools/batch_record_modification.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191700&action=edit Bug 41580: Tidy kohaTable - tools/holidays.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191701&action=edit Bug 41580: Tidy kohaTable - tools/inventory.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191702&action=edit Bug 41580: Tidy kohaTable - tools/manage-marc-import.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191703&action=edit Bug 41580: Tidy kohaTable - tools/modborrowers.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191704&action=edit Bug 41580: Tidy kohaTable - tools/upload.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191705&action=edit Bug 41580: tools - auto tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191706&action=edit Bug 41580: (follow-up) Fixes for errors - In Cataloging -> Manage staged MARC records: the logic around showing the "Edit" button was not correct - In Tools -> Batch patron modification: There was sometimes an error in the console about a variable not existing which can be resolved by moving the corresponding (and related) JS into the conditional which depends on the table of results existing. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191707&action=edit Bug 41580: (follow-up) More tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191697|0 |1 is obsolete| | --- Comment #21 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194965&action=edit Bug 41580: Tidy kohaTable - tools/batch_delete_records.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191698|0 |1 is obsolete| | --- Comment #22 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194966&action=edit Bug 41580: Tidy kohaTable - tools/batch_modify_holds.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191699|0 |1 is obsolete| | --- Comment #23 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194967&action=edit Bug 41580: Tidy kohaTable - tools/batch_record_modification.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191700|0 |1 is obsolete| | --- Comment #24 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194968&action=edit Bug 41580: Tidy kohaTable - tools/holidays.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191701|0 |1 is obsolete| | --- Comment #25 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194969&action=edit Bug 41580: Tidy kohaTable - tools/inventory.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191702|0 |1 is obsolete| | --- Comment #26 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194970&action=edit Bug 41580: Tidy kohaTable - tools/manage-marc-import.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191703|0 |1 is obsolete| | --- Comment #27 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194971&action=edit Bug 41580: Tidy kohaTable - tools/modborrowers.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191704|0 |1 is obsolete| | --- Comment #28 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194972&action=edit Bug 41580: Tidy kohaTable - tools/upload.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191705|0 |1 is obsolete| | --- Comment #29 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194973&action=edit Bug 41580: tools - auto tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191706|0 |1 is obsolete| | --- Comment #30 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194974&action=edit Bug 41580: (follow-up) Fixes for errors - In Cataloging -> Manage staged MARC records: the logic around showing the "Edit" button was not correct - In Tools -> Batch patron modification: There was sometimes an error in the console about a variable not existing which can be resolved by moving the corresponding (and related) JS into the conditional which depends on the table of results existing. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191707|0 |1 is obsolete| | --- Comment #31 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194975&action=edit Bug 41580: (follow-up) More tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #32 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194976&action=edit Bug 41580: (QA follow-up) Fix syntax error in holidays calendar options - The tidy introduced a semicolon inside the flatpickr options object literal which is a syntax error, breaking the calendar widget entirely - The syntax error also prevented the auto tidy from normalizing the surrounding code formatting - Replace with comma to match object property separator syntax To test: - Go to Tools → Calendar - Verify the calendar widget renders without JS errors Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #33 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194977&action=edit Bug 41580: (QA follow-up) Fix suspend status check in batch modify holds - Fix typo: hold.suspened → hold.suspended, the suspension check never fired because the property name was misspelled - Restore DOM update: the tidy replaced \$("#new_suspend_status").val("1") with a local variable assignment that had no effect on the submitted form data To test: - Go to Tools → Batch modify holds - Load holds that are not suspended - Set a suspend date without changing suspend status - Submit and verify the suspend status is automatically set to 1 Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #34 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194978&action=edit Bug 41580: (QA follow-up) Fix variable name mismatch in batch delete records - The tidy declared const record_type but the code references recordtype (no underscore), causing a ReferenceError - Rename to match the existing usage To test: - Go to Tools → Batch delete records - Upload/select bibliographic records with checked out items - Verify the red cross and yellow highlight appear for non-deletable records Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #35 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194979&action=edit Bug 41580: (QA follow-up) Fix msg type coercion in upload alerts - The tidy wrapped the msg variable in quotes, coercing a JS object literal to a string which breaks ShowAlerts iteration over file properties - The original also used | html which would HTML-escape the JSON quotes, a pre-existing bug - Use | $raw with a TT IF guard, matching the codebase convention for passing JSON from Perl to JS (e.g. TablesSettings) To test: - Go to Administration → Authorized values → UPLOAD and create a category - Go to Tools → Upload, select the category, upload a file - Search uploads by category to find the uploaded file - Delete the file - Verify the alert shows "<filename>: File has been deleted." - Without the fix, the page shows "0: undefined, 1: undefined, ..." because ShowAlerts iterates over character indices of a string instead of properties of a JSON object Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #36 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Paul Derscheid from comment #35)
Created attachment 194979 [details] [review] Bug 41580: (QA follow-up) Fix msg type coercion in upload alerts
XSS detected: /cgi-bin/koha/tools/upload.pl?op=search&id=&msg=alert(%22booh%22); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #37 from Jonathan Druart <jonathan.druart@gmail.com> --- Actually the error handling on this controller is not working at all since... commit dcd1f5d48c758aee17b6c6f069c6146b42efe117 Date: Fri Jan 23 13:18:54 2015 +0100 Bug 13618: Add html filters to all the variables I suggest to keep the html escape and deal with the error handling on a separate bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194979|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #38 from Jonathan Druart <jonathan.druart@gmail.com> --- Paul, I let you switch back to PQA (without the last patch that I already obsoleted) if you agree. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42025 --- Comment #39 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #37)
Actually the error handling on this controller is not working at all since...
commit dcd1f5d48c758aee17b6c6f069c6146b42efe117 Date: Fri Jan 23 13:18:54 2015 +0100 Bug 13618: Add html filters to all the variables
I suggest to keep the html escape and deal with the error handling on a separate bug.
Opened bug 42025. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #40 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Without that last patch being handled in Bug 42025, I'd say this is good to go. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #41 from Paul Derscheid <paul.derscheid@lmscloud.de> --- With that last patch being handled in Bug 42025, I'd say this is good to go. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 --- Comment #42 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41580 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara@openfifth.co.uk Status|Pushed to main |Needs documenting --- Comment #43 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Enhancement, not backporting. Scream at me if you feel strongly it should be backported. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org