[Bug 41573] New: Tidy kohaTable block - patron_lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Bug ID: 41573 Summary: Tidy kohaTable block - patron_lists Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41324 Assignee|oleonard@myacpl.org |jonathan.druart@gmail.com Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 [Bug 41324] Tidy kohaTable block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191139&action=edit Bug 41573: Tidy kohaTable - patron_lists/list.tt Patch from commit af517c6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191140&action=edit Bug 41573: Tidy kohaTable - patron_lists/lists.tt Patch from commit 0f6896a -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191141&action=edit Bug 41573: Tidy kohaTable - patron_lists/patron-lists-tab.tt Patch from commit 5737619 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191142&action=edit Bug 41573: patron_lists - auto tidy Patch from commit 5c4eabb -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39715 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39715 [Bug 39715] Do not quote DataTables options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41562 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41562 [Bug 41562] Introduce the concept of "stores" for regular javascript -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191139|0 |1 is obsolete| | --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194733&action=edit Bug 41573: Tidy kohaTable - patron_lists/list.tt Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191140|0 |1 is obsolete| | --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194734&action=edit Bug 41573: Tidy kohaTable - patron_lists/lists.tt Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191141|0 |1 is obsolete| | --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194735&action=edit Bug 41573: Tidy kohaTable - patron_lists/patron-lists-tab.tt Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191142|0 |1 is obsolete| | --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194736&action=edit Bug 41573: patron_lists - auto tidy Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194737&action=edit Bug 41573: (QA follow-up) Fix missing closing backtick in template literal - The conversion from string concatenation to a template literal in addToList() missed the closing backtick - This causes a syntax error breaking the add-to-list functionality on the patron lists tab Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194738&action=edit Bug 41573: (QA follow-up) Use var instead of const for dynamically loaded template - patron-lists-tab.tt is loaded dynamically via jQuery .load() - Using const for patron_id and cardnumber causes a redeclaration error when the tab reloads after adding/removing a patron - Change to var which allows redeclaration in the global scope Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194733|0 |1 is obsolete| | --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194746&action=edit Bug 41573: Tidy kohaTable - patron_lists/list.tt Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194734|0 |1 is obsolete| | --- Comment #12 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194747&action=edit Bug 41573: Tidy kohaTable - patron_lists/lists.tt Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194735|0 |1 is obsolete| | --- Comment #13 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194748&action=edit Bug 41573: Tidy kohaTable - patron_lists/patron-lists-tab.tt Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194736|0 |1 is obsolete| | --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194749&action=edit Bug 41573: patron_lists - auto tidy Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194737|0 |1 is obsolete| | --- Comment #15 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194750&action=edit Bug 41573: (QA follow-up) Fix missing closing backtick in template literal - The conversion from string concatenation to a template literal in addToList() missed the closing backtick - This causes a syntax error breaking the add-to-list functionality on the patron lists tab Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194738|0 |1 is obsolete| | --- Comment #16 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194751&action=edit Bug 41573: (QA follow-up) Use var instead of const for dynamically loaded template - patron-lists-tab.tt is loaded dynamically via jQuery .load() - Using const for patron_id and cardnumber causes a redeclaration error when the tab reloads after adding/removing a patron - Change to var which allows redeclaration in the global scope Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194751|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195158&action=edit Bug 41573: (QA follow-up) Use var instead of const for dynamically loaded template - patron-lists-tab.tt is loaded dynamically via jQuery .load() - Using const for patron_id and cardnumber causes a redeclaration error when the tab reloads after adding/removing a patron - Change to var which allows redeclaration in the global scope Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Fixed error: sha1 information is lacking or useless (koh a-tmpl/intranet-tmpl/prog/en/modules/patron_lists/patron-lists-tab.tt). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194746|0 |1 is obsolete| | --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 195233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195233&action=edit Bug 41573: Tidy kohaTable - patron_lists/list.tt Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194747|0 |1 is obsolete| | --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 195234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195234&action=edit Bug 41573: Tidy kohaTable - patron_lists/lists.tt Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194748|0 |1 is obsolete| | --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 195235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195235&action=edit Bug 41573: Tidy kohaTable - patron_lists/patron-lists-tab.tt Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194749|0 |1 is obsolete| | --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 195236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195236&action=edit Bug 41573: patron_lists - auto tidy Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194750|0 |1 is obsolete| | --- Comment #23 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 195237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195237&action=edit Bug 41573: (QA follow-up) Fix missing closing backtick in template literal - The conversion from string concatenation to a template literal in addToList() missed the closing backtick - This causes a syntax error breaking the add-to-list functionality on the patron lists tab Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195158|0 |1 is obsolete| | --- Comment #24 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 195238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195238&action=edit Bug 41573: (QA follow-up) Use var instead of const for dynamically loaded template - patron-lists-tab.tt is loaded dynamically via jQuery .load() - Using const for patron_id and cardnumber causes a redeclaration error when the tab reloads after adding/removing a patron - Change to var which allows redeclaration in the global scope Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 --- Comment #25 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41573 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |jacob.omara@openfifth.co.uk --- Comment #26 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Enhancement, not backporting. Scream at me if you feel strongly it should be backported. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org