[Bug 14956] New: C4::Dates from files opac/*.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Bug ID: 14956 Summary: C4::Dates from files opac/*.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org C4::Dates from files: - opac/opac-memberentry.pl - opac/opac-reserve.pl - opac/opac-search-history.pl - opac/opac-showreviews.pl - opac/opac-suggestions.pl - opac/opac-serial-issues.pl - opac/opac-alert-subscribe.pl - opac/opac-ics.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 43123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43123&action=edit Bug 14956 - C4::Dates from files opac/*.pl Remove C4::Dates from files: - opac/opac-memberentry.pl - opac/opac-reserve.pl - opac/opac-search-history.pl - opac/opac-showreviews.pl - opac/opac-suggestions.pl - opac/opac-serial-issues.pl - opac/opac-alert-subscribe.pl - opac/opac-ics.pl To test: - Apply patch - Verify, that self registration and holds work as before - Verify that tabs in catalog item detail work and display as before - For serials: Verify that subscriptions work as before. It is a little bit hidden, in tab Subscriptions, then 'More details', then tab 'Brief history', button 'Subscribe to email notificatin on new issues' - For ics: Can not be tested at the moment, not yet used (Bug 5456), pls. have a look at the code changes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |veron@veron.ch Status|NEW |Needs Signoff Patch complexity|--- |Small patch Blocks| |14870 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|C4::Dates from files |Remove C4::Dates from files |opac/*.pl |opac/*.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |hector.hecaxmmx@gmail.com --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Marc After applying patch I've found this: /opac/opac-showreviews.pl got C4::Dates declaration in line 59, 116 and patch only eliminate the declaration 'use C4::Dates' Regards -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43123|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 43356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43356&action=edit Bug 14956 - C4::Dates from files opac/*.pl Remove C4::Dates from files: - opac/opac-memberentry.pl - opac/opac-reserve.pl - opac/opac-search-history.pl - opac/opac-showreviews.pl - opac/opac-suggestions.pl - opac/opac-serial-issues.pl - opac/opac-alert-subscribe.pl - opac/opac-ics.pl To test: - Apply patch - Verify, that self registration and holds work as before - Verify that tabs in catalog item detail work and display as before - For serials: Verify that subscriptions work as before. It is a little bit hidden, in tab Subscriptions, then 'More details', then tab 'Brief history', button 'Subscribe to email notificatin on new issues' - For ics: Can not be tested at the moment, not yet used (Bug 5456), pls. have a look at the code changes (Amended following comment #2) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Marc When you go to "your personal details" (opac/opac-memberentry.pl) and if you alter to an invalid date the form it doesn't fail but when you go to staff in Home > Patrons requesting modifications, at the bottom of screen this redirect to members/members-update.pl and you get noticed that the date sent is '0000-00-00' (depends in which format you have dateformat syspref) this data shown in a table: Field From To Date of birth 2015-11-01 0000-00-00 To prevent this (IMHO) I suggest to add readonly="" to the input text or follow the example as koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt Patch follow -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #5 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 43357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43357&action=edit Bug 14956 - (follow) Prevent patrons to insert invalid dates in opac/opac-memberentry.pl Prevent to insert dates like 0000-00-00, 1970-32-10, etc., according with comment 4. To test 1) Apply last patch 2) Go to 'your personal details in opac' (opac/opac-memberentry.pl) observe that field is readonly and patrons can't insert invalid dates. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43357|0 |1 is obsolete| | --- Comment #6 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 43359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43359&action=edit Bug 14956 - (follow) Prevent patrons to insert invalid dates in opac-memberentry.tt Prevent to insert invalid dates in opac-memberentry.tt. To test 1) Apply last patch (interactive) 2) Goto 'your personal details in opac' and modify date of birth with 2015-10-32 3) Goto staff in Home > Patrons requesting modifications, at the bottom of screen this redirect to members/members-update.pl and you get noticed that the date sent is '0000-00-00' 4) Apply patch 5) Go to 'your personal details in opac' (opac/opac-memberentry.pl) observe that field is readonly and patrons can't insert invalid dates. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43359|0 |1 is obsolete| | --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 43362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43362&action=edit Bug 14956 - (follow) Prevent patrons to insert invalid dates in opac-memberentry.tt Prevent to insert invalid dates in opac-memberentry.tt. To test 1) Apply last patch (interactive) 2) Goto 'your personal details in opac' and modify date of birth with 2015-10-32 3) Goto staff in Home > Patrons requesting modifications, at the bottom of screen this redirect to members/members-update.pl and you get noticed that the date sent is '0000-00-00' 4) Apply patch 5) Go to 'your personal details in opac' (opac/opac-memberentry.pl) observe that field is readonly and patrons can't insert invalid dates. Field 'Date of birth' in Opac is now restricted to date picker. Works as advertised. Signed-off-by: Marc Véron <veron@veron.ch> http://bugs.koha-community.org/show_bug.cgi?id=14920 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The second patch is not the way to do, especially at the OPAC: if the user turned off JS, he cannot enter a date. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43362|0 |1 is obsolete| | --- Comment #9 from Marc Véron <veron@veron.ch> --- Comment on attachment 43362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43362 Bug 14956 - (follow) Prevent patrons to insert invalid dates in opac-memberentry.tt Obsoleted this patch becaues of comment #8, replacment patch follows. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #10 from Marc Véron <veron@veron.ch> --- Created attachment 43408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43408&action=edit Bug 14956 - (follow) Validate incoming birth date This patch validates the birthdate and resets it to empty if date is not valid. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #11 from Marc Véron <veron@veron.ch> --- Still applies -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #12 from Marc Véron <veron@veron.ch> --- Still applies -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43356|0 |1 is obsolete| | --- Comment #13 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 44352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44352&action=edit [SIGNED-OFF]Bug 14956 - C4::Dates from files opac/*.pl Remove C4::Dates from files: - opac/opac-memberentry.pl - opac/opac-reserve.pl - opac/opac-search-history.pl - opac/opac-showreviews.pl - opac/opac-suggestions.pl - opac/opac-serial-issues.pl - opac/opac-alert-subscribe.pl - opac/opac-ics.pl To test: - Apply patch - Verify, that self registration and holds work as before - Verify that tabs in catalog item detail work and display as before - For serials: Verify that subscriptions work as before. It is a little bit hidden, in tab Subscriptions, then 'More details', then tab 'Brief history', button 'Subscribe to email notificatin on new issues' - For ics: Can not be tested at the moment, not yet used (Bug 5456), pls. have a look at the code changes (Amended following comment #2) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43408|0 |1 is obsolete| | --- Comment #14 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 44353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44353&action=edit [SIGNED-OFF]Bug 14956 - (follow) Validate incoming birth date This patch validates the birthdate and resets it to empty if date is not valid. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- After long, long test, finally signed off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Define a date of birth at the opac, validate the changes. Clear the date, go and see the changes: the new date is today. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44353|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44353|0 |1 is patch| | Attachment #44353|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #17 from Marc Véron <veron@veron.ch> --- Created attachment 44518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44518&action=edit Bug 14956: (followup) Fix birthday date validation in Opac To reproduce / test: - In Opac: Go to 'your personal details' - Enter a valid birtday date - In Staff client: Go to Home > Patrons > Update patron records (Link on start page: Patrons requesting modification) - Verify that the birtday date is correct - Back in Opac, clear the birthday date, try to submit => Validation message appears - Enter an invalid date (32/32/2999 or 00/00/0000), try to submit => Birthday date field is cleared, validation message appears. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44518|0 |1 is obsolete| | --- Comment #18 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 44534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44534&action=edit [SIGNED-OFF]Bug 14956: (followup) Fix birthday date validation in Opac To reproduce / test: - In Opac: Go to 'your personal details' - Enter a valid birtday date - In Staff client: Go to Home > Patrons > Update patron records (Link on start page: Patrons requesting modification) - Verify that the birtday date is correct - Back in Opac, clear the birthday date, try to submit => Validation message appears - Enter an invalid date (32/32/2999 or 00/00/0000), try to submit => Birthday date field is cleared, validation message appears. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Wrong today corrected -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #19 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Just one comment, Marc The Patrons requesting modification (Home > Patrons > Update patron records) does not follow dateformat syspref. file: members/members-update.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15146 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #20 from Marc Véron <veron@veron.ch> --- (In reply to Héctor Eduardo Castro Avalos from comment #19)
Just one comment, Marc
The Patrons requesting modification (Home > Patrons > Update patron records) does not follow dateformat syspref.
file: members/members-update.pl
Thanks, Héctor, I filed Bug14956 (needs sign-off) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #21 from Marc Véron <veron@veron.ch> --- Sorry, mistaked: Bug 15146 (Need a double espresso) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44352|0 |1 is obsolete| | Attachment #44534|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44593&action=edit [PASSED QA] Bug 14956 - C4::Dates from files opac/*.pl Remove C4::Dates from files: - opac/opac-memberentry.pl - opac/opac-reserve.pl - opac/opac-search-history.pl - opac/opac-showreviews.pl - opac/opac-suggestions.pl - opac/opac-serial-issues.pl - opac/opac-alert-subscribe.pl - opac/opac-ics.pl To test: - Apply patch - Verify, that self registration and holds work as before - Verify that tabs in catalog item detail work and display as before - For serials: Verify that subscriptions work as before. It is a little bit hidden, in tab Subscriptions, then 'More details', then tab 'Brief history', button 'Subscribe to email notificatin on new issues' - For ics: Can not be tested at the moment, not yet used (Bug 5456), pls. have a look at the code changes (Amended following comment #2) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44594&action=edit [PASSED QA] Bug 14956: (followup) Fix birthday date validation in Opac To reproduce / test: - In Opac: Go to 'your personal details' - Enter a valid birtday date - In Staff client: Go to Home > Patrons > Update patron records (Link on start page: Patrons requesting modification) - Verify that the birtday date is correct - Back in Opac, clear the birthday date, try to submit => Validation message appears - Enter an invalid date (32/32/2999 or 00/00/0000), try to submit => Birthday date field is cleared, validation message appears. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Wrong today corrected Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org