[Bug 14202] New: Unexpected parameter for window.open in marc21_linking_section plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14202 Bug ID: 14202 Summary: Unexpected parameter for window.open in marc21_linking_section plugin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Code contains: window.open(\"/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=marc21_linking_section.pl&index=\" + i + \"&result=\"+defaultvalue,\"marc21_field_7\"+i+\"\",'width=900,height=700,toolbar=false,scrollbars=yes'); The part ,\"marc21_field_7\"+i+\"\", is somewhat unexpected. If I am correct, js could interpret this as the name parameter of window.open. Note that this name is not the title. I propose to remove it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14202 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13437 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14202 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 41004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41004&action=edit Bug 14202: Unexpected parameter for window.open in marc21_linking_section.pl The builder of this plugin includes a window.open call with the name parameter: \"marc21_field_7\"+ event.data.id +\"\" Note that this is not the name of the new window. This trivial patch adjusts this unusual name by tag_editor like other plugins. Test plan: Attach marc21_linking_section to 773$9. Click on the Tag editor button. If it opens, it still works :) Note that the name of the popup is still: Koha > Cataloguing > plugin for links -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14202 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14202 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41004|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 44451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44451&action=edit Bug 14202: Unexpected parameter for window.open in marc21_linking_section.pl The builder of this plugin includes a window.open call with the name parameter: \"marc21_field_7\"+ event.data.id +\"\" Note that this is not the name of the new window. This trivial patch adjusts this unusual name by tag_editor like other plugins. Test plan: Attach marc21_linking_section to 773$9. Click on the Tag editor button. If it opens, it still works :) Note that the name of the popup is still: Koha > Cataloguing > plugin for links Signed-off-by: Fredreic Demians <f.demians@tamil.fr> Plugin still working, with a valid pop-pup window id. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14202 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14202 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14202 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44451|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44583&action=edit [PASSED QA] Bug 14202: Unexpected parameter for window.open in marc21_linking_section.pl The builder of this plugin includes a window.open call with the name parameter: \"marc21_field_7\"+ event.data.id +\"\" Note that this is not the name of the new window. This trivial patch adjusts this unusual name by tag_editor like other plugins. Test plan: Attach marc21_linking_section to 773$9. Click on the Tag editor button. If it opens, it still works :) Note that the name of the popup is still: Koha > Cataloguing > plugin for links Signed-off-by: Fredreic Demians <f.demians@tamil.fr> Plugin still working, with a valid pop-pup window id. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14202 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org