[Bug 10520] New: Add i18n function to English mysql files for webinstaller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 Bug ID: 10520 Summary: Add i18n function to English mysql files for webinstaller Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: m.de.rooy@rijksmuseum.nl Reporter: m.de.rooy@rijksmuseum.nl CC: gmcharlt@gmail.com See bug 10590. This bug is a followup to convert the English files to the new style using the i18n function. This function translates the strings for the non-English languages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10509 Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10521 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10526 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19439&action=edit Bug 10520: Add i18n function to en/mandatory mysql files Main goal: Adds i18n calls around translatable columns. Additionally: Removes backtics. Adds column names in inserts (where missing). Uses consistent style (based on my interpretation of coding guidelines). Test plan: Make sure that you apply this patch on top of the 10509 patches! Run English mysql install. Verify that you include all mandatory files. Check if webinstaller does not report errors. Inspect table contents via interface or mysql. Search for a column not using i18n where you would expect translation. Note: If you prefer to run the mysql files from command line, please make sure now that you define a 'fake' i18n, doing nothing (see Installer.pm code). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested both ways myself. Noticed that I missed one message_transport_type (phone) and one language description (180 vs. 181). If needed, will handle these on a separate report. They do not directly relate to this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19440&action=edit Bug 10520: Add i18n function to en/optional mysql files Main goal: Adds i18n calls around translatable columns. Additionally: Removes backtics. Adds column names in inserts (where missing). Uses consistent style (based on my interpretation of coding guidelines). Removed some locking statements in sample_creator_data. NOTE: Some scripts insert numbers in auto-increment columns. Although this works, I would not prefer to do so. This patch however is not meant to change that, so leaves them for now. Test plan: Make sure that you apply this patch on top of the 10509 patches! Run English mysql install. Verify that you include all OPTIONAL files (in the OTHER DATA section). Check if webinstaller does not report errors. Inspect table contents via interface or mysql. Search for a column not using i18n where you would expect translation. Note: If you prefer to run the mysql files from command line, please make sure now that you define a 'fake' i18n, doing nothing (see Installer.pm code). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested all optional data via webinstaller. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |bgkriegel@gmail.com --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- The first two patches are ready for signoff. The last patch should cover all files in marcflavour section. I still wait a few days in the hope to catch all MARC21 changes too from Bernardo in bug 5858. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Just to be clear: last patch refers to the third patch not yet attached :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Marcel should I wait for all 3 before signing off? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Chris: Thanks for testing. You are welcome to sign off what is available.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19542&action=edit Bug 10520: Add i18n function to en/marflavour mysql files IMPORTANT: Patch file is too big for git-bz. Please download this .gz and unzip the patch file to apply it manually. Thank you. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19542|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19542|Bug 10520: Add i18n |[PATCH_IN_GZIP] Bug 10520: description|function to en/marflavour |Add i18n function to |mysql files |en/marflavour mysql files -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- The size of the simple_bib file and its 'redundant' contents would almost make me split it up in multiple files. It would be even nicer if we could do an insert..select for the marc structure and just update the status column on the tags/subfields to make them visible or hidden in the several frameworks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10572 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19439|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20078&action=edit Bug 10520: Add i18n function to en/mandatory mysql files Main goal: Adds i18n calls around translatable columns. Additionally: Removes backtics. Adds column names in inserts (where missing). Uses consistent style (based on my interpretation of coding guidelines). Test plan: Make sure that you apply this patch on top of the 10509 patches! Run English mysql install. Verify that you include all mandatory files. Check if webinstaller does not report errors. Inspect table contents via interface or mysql. Search for a column not using i18n where you would expect translation. Note: If you prefer to run the mysql files from command line, please make sure now that you define a 'fake' i18n, doing nothing (see Installer.pm code). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested both ways myself. Noticed that I missed one message_transport_type (phone) and one language description (180 vs. 181). If needed, will handle these on a separate report. They do not directly relate to this patch. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19440|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20079&action=edit Bug 10520: Add i18n function to en/optional mysql files Main goal: Adds i18n calls around translatable columns. Additionally: Removes backtics. Adds column names in inserts (where missing). Uses consistent style (based on my interpretation of coding guidelines). Removed some locking statements in sample_creator_data. NOTE: Some scripts insert numbers in auto-increment columns. Although this works, I would not prefer to do so. This patch however is not meant to change that, so leaves them for now. Test plan: Make sure that you apply this patch on top of the 10509 patches! Run English mysql install. Verify that you include all OPTIONAL files (in the OTHER DATA section). Check if webinstaller does not report errors. Inspect table contents via interface or mysql. Search for a column not using i18n where you would expect translation. Note: If you prefer to run the mysql files from command line, please make sure now that you define a 'fake' i18n, doing nothing (see Installer.pm code). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested all optional data via webinstaller. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19542|0 |1 is obsolete| | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20080&action=edit [PATCH_IN_GZIP] Bug 10520: Add i18n function to en/marflavour mysql files -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Depends on bug 10509 that doesn't apply - moving to blocked for now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20079|0 |1 is obsolete| | --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 21118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21118&action=edit Bug 10520: Add i18n function to en/optional mysql files Main goal: Adds i18n calls around translatable columns. Additionally: Removes backtics. Adds column names in inserts (where missing). Uses consistent style (based on my interpretation of coding guidelines). Removed some locking statements in sample_creator_data. NOTE: Some scripts insert numbers in auto-increment columns. Although this works, I would not prefer to do so. This patch however is not meant to change that, so leaves them for now. Test plan: Make sure that you apply this patch on top of the 10509 patches! Run English mysql install. Verify that you include all OPTIONAL files (in the OTHER DATA section). Check if webinstaller does not report errors. Inspect table contents via interface or mysql. Search for a column not using i18n where you would expect translation. Note: If you prefer to run the mysql files from command line, please make sure now that you define a 'fake' i18n, doing nothing (see Installer.pm code). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested all optional data via webinstaller. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Rebased for trivial withdrawn change in auth_val.sql -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- The third patch for marcflavour is huge and does not apply anymore. It was signed by Kyle. Please let me know if you want to start QA on that file; I will rebase it then. Back to Signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20080|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #16 from Magnus Enger <magnus@enger.priv.no> --- Marcel: The status is now RESOLVED WONTFIX - is that a mistake? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Magnus Enger from comment #16)
Marcel: The status is now RESOLVED WONTFIX - is that a mistake?
No. I gave up on this report. No support.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 Bug 10520 depends on bug 10509, which changed state. Bug 10509 Summary: Using i18n function for translation in webinstaller mysql files http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |CLOSED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org