http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19440&action=edit Bug 10520: Add i18n function to en/optional mysql files Main goal: Adds i18n calls around translatable columns. Additionally: Removes backtics. Adds column names in inserts (where missing). Uses consistent style (based on my interpretation of coding guidelines). Removed some locking statements in sample_creator_data. NOTE: Some scripts insert numbers in auto-increment columns. Although this works, I would not prefer to do so. This patch however is not meant to change that, so leaves them for now. Test plan: Make sure that you apply this patch on top of the 10509 patches! Run English mysql install. Verify that you include all OPTIONAL files (in the OTHER DATA section). Check if webinstaller does not report errors. Inspect table contents via interface or mysql. Search for a column not using i18n where you would expect translation. Note: If you prefer to run the mysql files from command line, please make sure now that you define a 'fake' i18n, doing nothing (see Installer.pm code). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested all optional data via webinstaller. -- You are receiving this mail because: You are watching all bug changes.