[Bug 37829] New: Allow additional fields for bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Bug ID: 37829 Summary: Allow additional fields for bookings Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: paul.derscheid@lmscloud.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Directly from LMSCloud's requirements:
As a Koha library, we want to be able to use configurable additional fields for bookings in order to enable patrons to provide additional information with bookings like the persons who need to be informed when the material is available or a contact person of the institution. The additional fields will be editable and stored with the booking and should be also available in booking notifications.
I think this is interesting because these use-cases seems like a perfect fit for the bookings feature. For example when working with schools or something of the like. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |paul.derscheid@lmscloud.de |ity.org | Depends on| |29002 Circulation| |bookings function| | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Change sponsored?|--- |Sponsored CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Bug 37829 depends on bug 29002, which changed state. Bug 29002 Summary: Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #1 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 181034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181034&action=edit Bug 37829: Module, Controller, DBIx::Class changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #2 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 181035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181035&action=edit Bug 37829: API specification changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #3 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 181036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181036&action=edit Bug 37829: Add bookings as config option in additional-fields.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #4 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 181037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181037&action=edit Bug 37829: Expose additional fields API client, add needed methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 181038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181038&action=edit Bug 37829: Add additional fields module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 181039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181039&action=edit Bug 37829: Add entry point for additional fields in place_booking.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 181040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181040&action=edit Bug 37829: Add additional fields support to modal, tables To test: 1) Setup: a) Apply the db seed provided: koha-mysql < test_bug_37829.sql --- or --- b) Setup authorised values and additional fields manually: i) Navigate to Administration -> Authorized Values and click '+ New Category'. ii) Define a new authorised value category (e.g., prefix with BOOKINGS_ for easy identification). iii) Click '+ Add a new authorized value'. iv) Add a value, filling in at least 'Authorized Value' and 'Description'. v) Save the value. vi) Navigate to Administration -> Additional Fields. vii) Click 'Bookings (bookings)'. viii)Click '+ New field'. ix) Add a plain text field (fill 'Name' and save). x) Add a repeatable text field. xi) Add a field tied to your previously created authorized value category. xii) Add another field tied to any authorised value (e.g., YES_NO) and make it repeatable. 2) Item Configuration: Make an item bookable. Either: a) Navigate to Administration -> Item types, select an item type (e.g., BK), and check 'bookable'. b) Navigate to the 'Items' view for a specific item (catalogue/moredetail.pl) and set Priority -> Bookable -> 'Yes'. 3) Create Booking: Click the 'Place booking' button on the item's record. The configured additional fields should load dynamically in the modal. 4) Fill and Save Booking: Fill out the default booking fields and then the additional fields. Use the 'Remove' and 'New' buttons for repeatable fields. Save the booking. 5) Verify Display in Tables: Confirm that the additional fields for the booking are displayed correctly in the following locations: a) The bookings table within the bibliographic record's detail view. b) The 'Check out' view (circ/circulation.pl -> Bookings tab). c) The 'Patron's details' view (members/moremember.pl -> Bookings tab). d) The 'Bookings to collect' view (circ/pendingbookings.pl) (adjust filters if necessary). 6) Verify Edit/Move Functionality: Return to the bookings view of the bibliographic record. a) Verify the additional fields are correctly pre-filled and saved when you move the booking using the timeline component. b) Verify the additional fields are correctly pre-filled and saved when you edit the booking using the edit button in the bookings table. 7) Repeat Testing: Repeat steps 4 through 6.b with additional bookings to ensure consistency. 8) Sign-off and/or give your feedback. Here's some things I'd would still like to improve/try: - Incorporate the neighboring additional-fields-entry.js to have a single library for additional fields - Restructure the buttons to be consistent with other usage of additional fields in Koha (noticed this way to late) - Test this with the freshly added support for additional fields on branches (libraries) - Make the additional field values searchable in the table - Clean up and DRY some of the JSDoc types (but this could easily become its own tree of bugs if done from the source :D) - Use mockData.js for the mocha tests instead of hardcoding them I actually need this for a customer and the current state will be alright for that, but now it's good enough to work and improve it together. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 181041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181041&action=edit Bug 37829: Add unit tests (mocha) and testing dependencies This also acts as a proposal on how to easily test our assets without having to turn them into modules. Not that I am against modules in any way, but rewire also allows us to add tests for older JS in Koha :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 181042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181042&action=edit Bug 37829: Isolated yarn.lock changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 181043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181043&action=edit Bug 37829: [DO NOT PUSH] Add db seed for SO + QA This file can just be run against the db to: - Make books bookable in general - Add some authorised values targeted at testing the different types - Add some additional fields, some of which using the aforementioned authorised values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Addendum to the test plan: Setup: 1) Run 'yarn api:bundle' to rebuild the api spec with the new changes. 2) Reload plack to load the new spec: 'koha-plack --reload kohadev'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #12 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Just another note, with '+ // @ts-check' at the top of the file, you can also observe that there are currently no type errors in additional-fields.js except for complaining about __ not being defined (which can be ignored). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #13 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- This is lovely. 1) "Bookings" should be alphabetically placed in cgi-bin/koha/admin/additional-fields.pl 2) Is there absolutely no way we use/extend the current established pattern of additional-fields-entry.inc and additional-fields-entry.js? This patchset is now introducing a 3rd implementation of additional fields into Koha (vanilla tt, VueJS, now this JS). Some things work differently here to the vanilla Koha implementation e.g. repeatable fields start hidden here where in vanilla Koha it always start with showing at least one. Repeatable AV fields in vanilla Koha are shown as checkboxes, here they're shown as multiple dropdowns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, please remember alphabetic has no meaning with translations... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #15 from Paul Derscheid <paul.derscheid@lmscloud.de> ---
1) "Bookings" should be alphabetically placed in cgi-bin/koha/admin/additional-fields.pl Yes, will fix that shortly.
2) Is there absolutely no way we use/extend the current established pattern of additional-fields-entry.inc and additional-fields-entry.js? I actually wanted it to be the other way around. Since additional-fields-entry.js is so small in scope, I just wanted to keep it as an interface to the new additional-fields.js, and cover that functionality as well.
This patchset is now introducing a 3rd implementation of additional fields into Koha (vanilla tt, VueJS, now this JS). That's true, for the time being I'd like to move to vanilla.tt + one consolidated js library + Vue. And in the future move to a singular implementation based on optional tt + vue islands.
Some things work differently here to the vanilla Koha implementation e.g. repeatable fields start hidden here where in vanilla Koha it always start with showing at least one. I had that initially, will reintroduce that behaviour to be consistent.
Repeatable AV fields in vanilla Koha are shown as checkboxes, here they're shown as multiple dropdowns. Do you have a prominent spot I can look at that you would describe as some sort of reference implementation?
Thanks for taking the time to look at this :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #16 from Paul Derscheid <paul.derscheid@lmscloud.de> ---
That's true, for the time being I'd like to move to vanilla.tt + one consolidated js library + Vue. And in the future move to a singular implementation based on optional tt + vue islands.
In addition to keep using the native Vue component in Vue apps of course. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #17 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Paul Derscheid from comment #15)
Do you have a prominent spot I can look at that you would describe as some sort of reference implementation?
Yeah I just discovered bug 39664 while testing this, the steps there provide you with an example of the current implementation. (In reply to Paul Derscheid from comment #15)
I actually wanted it to be the other way around. Since additional-fields-entry.js is so small in scope, I just wanted to keep it as an interface to the new additional-fields.js, and cover that functionality as well.
That works just the same imo, this is why I said use/extend the current implementation. As long as we don't add a new standalone implementation of additional fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #18 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Katrin Fischer from comment #14)
Hm, please remember alphabetic has no meaning with translations...
Fair point. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #19 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Yes, that's also not my intention as you might be able to tell :D I will make a round of adjustments and try consolidating the diverging approaches. Thanks for the pointers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot@biblibre.co | |m Status|Needs Signoff |Patch doesn't apply --- Comment #20 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Hello Paul, Some conflict on the first patch and maybe others ( koha-tmpl/intranet-tmpl/prog/js/fetch/http-client.js ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #21 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Salut Thibaud, thanks for taking another look at this. I was going to rebase but then noticed that I still have a wip commit locally that attempts to fix the areas Pedro highlighted. Will soon rebase with these fixes included. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Did this get merged into your Vue submission for 41129 Paul.. or should it perhaps be moved to after that bug and rebased appropriately? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #23 from Paul Derscheid <paul.derscheid@lmscloud.de> --- No, I threw the integration out of Bug 41129 to not overload that bug with too much new stuff. This one is still valid but needs to be properly rebased, as you said. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181034|0 |1 is obsolete| | --- Comment #24 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 193769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193769&action=edit Bug 37829: Module, Controller, DBIx::Class changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181034|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193769|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181034|0 |1 is obsolete| | --- Comment #25 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 193840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193840&action=edit Bug 37829: Module, Controller, DBIx::Class changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181035|0 |1 is obsolete| | --- Comment #26 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 193841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193841&action=edit Bug 37829: API specification changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181036|0 |1 is obsolete| | --- Comment #27 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 193842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193842&action=edit Bug 37829: Add bookings as config option in additional-fields.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181037|0 |1 is obsolete| | --- Comment #28 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 193843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193843&action=edit Bug 37829: Expose additional fields API client, add needed methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181038|0 |1 is obsolete| | --- Comment #29 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 193844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193844&action=edit Bug 37829: Add additional fields module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181039|0 |1 is obsolete| | --- Comment #30 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 193845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193845&action=edit Bug 37829: Add entry point for additional fields in place_booking.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181040|0 |1 is obsolete| | --- Comment #31 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 193846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193846&action=edit Bug 37829: Add additional fields support to modal, tables To test: 1) Setup: a) Apply the db seed provided: koha-mysql < test_bug_37829.sql --- or --- b) Setup authorised values and additional fields manually: i) Navigate to Administration -> Authorized Values and click '+ New Category'. ii) Define a new authorised value category (e.g., prefix with BOOKINGS_ for easy identification). iii) Click '+ Add a new authorized value'. iv) Add a value, filling in at least 'Authorized Value' and 'Description'. v) Save the value. vi) Navigate to Administration -> Additional Fields. vii) Click 'Bookings (bookings)'. viii)Click '+ New field'. ix) Add a plain text field (fill 'Name' and save). x) Add a repeatable text field. xi) Add a field tied to your previously created authorized value category. xii) Add another field tied to any authorised value (e.g., YES_NO) and make it repeatable. 2) Item Configuration: Make an item bookable. Either: a) Navigate to Administration -> Item types, select an item type (e.g., BK), and check 'bookable'. b) Navigate to the 'Items' view for a specific item (catalogue/moredetail.pl) and set Priority -> Bookable -> 'Yes'. 3) Create Booking: Click the 'Place booking' button on the item's record. The configured additional fields should load dynamically in the modal. 4) Fill and Save Booking: Fill out the default booking fields and then the additional fields. Use the 'Remove' and 'New' buttons for repeatable fields. Save the booking. 5) Verify Display in Tables: Confirm that the additional fields for the booking are displayed correctly in the following locations: a) The bookings table within the bibliographic record's detail view. b) The 'Check out' view (circ/circulation.pl -> Bookings tab). c) The 'Patron's details' view (members/moremember.pl -> Bookings tab). d) The 'Bookings to collect' view (circ/pendingbookings.pl) (adjust filters if necessary). 6) Verify Edit/Move Functionality: Return to the bookings view of the bibliographic record. a) Verify the additional fields are correctly pre-filled and saved when you move the booking using the timeline component. b) Verify the additional fields are correctly pre-filled and saved when you edit the booking using the edit button in the bookings table. 7) Repeat Testing: Repeat steps 4 through 6.b with additional bookings to ensure consistency. 8) Sign-off and/or give your feedback. Here's some things I'd would still like to improve/try: - Incorporate the neighboring additional-fields-entry.js to have a single library for additional fields - Restructure the buttons to be consistent with other usage of additional fields in Koha (noticed this way to late) - Test this with the freshly added support for additional fields on branches (libraries) - Make the additional field values searchable in the table - Clean up and DRY some of the JSDoc types (but this could easily become its own tree of bugs if done from the source :D) - Use mockData.js for the mocha tests instead of hardcoding them I actually need this for a customer and the current state will be alright for that, but now it's good enough to work and improve it together. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181041|0 |1 is obsolete| | --- Comment #32 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 193847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193847&action=edit Bug 37829: Add unit tests (mocha) and testing dependencies This also acts as a proposal on how to easily test our assets without having to turn them into modules. Not that I am against modules in any way, but rewire also allows us to add tests for older JS in Koha :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181042|0 |1 is obsolete| | --- Comment #33 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 193848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193848&action=edit Bug 37829: Isolated yarn.lock changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 --- Comment #34 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 193849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193849&action=edit Bug 37829: Fix aliases import in js file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 Cécile Garcia-Belmonte <cecilegarciabelmonte@loireforez.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cecilegarciabelmonte@loiref | |orez.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #35 from David Nind <david@davidnind.com> --- Th epatches no longer apply 8-(.. git bz apply 37829 📋 Bug 37829 - Allow additional fields for bookings • 181043 - Bug 37829: [DO NOT PUSH] Add db seed for SO + QA • 193840 - Bug 37829: Module, Controller, DBIx::Class changes • 193841 - Bug 37829: API specification changes • 193842 - Bug 37829: Add bookings as config option in additional-fields.tt • 193843 - Bug 37829: Expose additional fields API client, add needed methods • 193844 - Bug 37829: Add additional fields module • 193845 - Bug 37829: Add entry point for additional fields in place_booking.inc • 193846 - Bug 37829: Add additional fields support to modal, tables • 193847 - Bug 37829: Add unit tests (mocha) and testing dependencies • 193848 - Bug 37829: Isolated yarn.lock changes • 193849 - Bug 37829: Fix aliases import in js file Apply? [(y)es, (n)o, (i)nteractive] y Preparing 11 patch(es): ✓ Prepared 11 patch(es) Applying 11 patch(es): ✓ [1/11] Applied Bug 37829: [DO NOT PUSH] Add db seed for SO + QA ✓ [2/11] Applied Bug 37829: Module, Controller, DBIx::Class changes ✓ [3/11] Applied Bug 37829: API specification changes ✓ [4/11] Applied Bug 37829: Add bookings as config option in additional-fields.tt ✓ [5/11] Applied Bug 37829: Expose additional fields API client, add needed methods ✓ [6/11] Applied Bug 37829: Add additional fields module ✓ [7/11] Applied Bug 37829: Add entry point for additional fields in place_booking.inc Patch application failed for attachment 193846 - Bug 37829: Add additional fields support to modal, tables -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org