[Bug 15584] New: Staff client list errors are incorrectly styled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Bug ID: 15584 Summary: Staff client list errors are incorrectly styled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Lists Assignee: gmcharlt@gmail.com Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When an error is triggered by the lists system in the staff client the "dialog" <div> has the wrong class. It has <div class="dialog error"> but the correct class is <div class="dialog alert"> The message or alert class is a template variable, so the script will have to be modified. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 46739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46739&action=edit Bug 15584 - References to Koha::Branches remain in unit tests The unit tests BiblioObject.t and Hold.t still have references to Koha::Branches that need to be changed to Koha::Libraries. These tests currently fail because of this. Test Plan: 1) prove t/db_dependent/BiblioObject.t should fail 2) prove t/db_dependent/Hold.t should fail 3) Apply this patch 1) prove t/db_dependent/BiblioObject.t should pass 2) prove t/db_dependent/Hold.t should pass Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- The content of attachment 46739 has been deleted -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Gus Ellerm <gel1163@stacmail.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gel1163@stacmail.net --- Comment #3 from Gus Ellerm <gel1163@stacmail.net> --- Could you please tell us what URL to go too to create the error message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- In the Staff Client, go to Lists (/cgi-bin/koha/virtualshelves/shelves.pl) and create a new list with the same name as an existing one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Chloe Alabaster <chloealabaster@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |chloealabaster@gmail.com CC| |chloealabaster@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Chloe Alabaster <chloealabaster@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #5 from Chloe Alabaster <chloealabaster@gmail.com> --- Created attachment 47078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47078&action=edit Bug 15584 - Staff client list errors are incorrectly styled To Test- 1-In the Staff Client, go to Lists (/cgi-bin/koha/virtualshelves/shelves.pl) and create a new list with the same name as an existing one. --note that it has some red in it like an error 2- apply patch 3-In the Staff Client, go to Lists (/cgi-bin/koha/virtualshelves/shelves.pl) and create a new list with the same name as an existing one. --note that now it should be just yellow with black writing as an alert -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47078|0 |1 is obsolete| | --- Comment #6 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 47081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47081&action=edit Bug 15584 - Staff client list errors are incorrectly styled To Test- 1-In the Staff Client, go to Lists (/cgi-bin/koha/virtualshelves/shelves.pl) and create a new list with the same name as an existing one. --note that it has some red in it like an error 2- apply patch 3-In the Staff Client, go to Lists (/cgi-bin/koha/virtualshelves/shelves.pl) and create a new list with the same name as an existing one. --note that now it should be just yellow with black writing as an alert Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I disagree with this patch, the "already exist" case is taken into account with the Koha::Exceptions::Virtualshelves::DuplicateObject exception. In some case, an error could happen, it's wrong to change all 'error' with 'alert' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47138&action=edit Bug 15584: Example -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #8)
Created attachment 47138 [details] [review] Bug 15584: Example
Gus, With this patch, we have the correct style for the duplicate message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Jonathan I don't understand your comments. Are you saying that there are cases where the "error" value is required for some other aspect of the code? There is no standard interface element with an "error" class. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #10)
Jonathan I don't understand your comments. Are you saying that there are cases where the "error" value is required for some other aspect of the code? There is no standard interface element with an "error" class.
Haa! Sorry, I have not got it! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47138|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have found acqui/parcel.tt: <div class="dialog error"> acqui/parcel.tt: <div class="dialog error"> tools/batch_delete_records.tt: <div class="dialog error" style="margin:auto;"> tools/batch_record_modification.tt: <div class="dialog error" style="margin:auto;"> Are they wrong? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #12)
Are they wrong?
Yes, as far as I'm concerned they are. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Looking at an instance where "dialog error" is used, I see this in itemtypes.tt: [% IF message.type == 'success' %] <div class="dialog message"> [% ELSIF message.type == 'warning' %] <div class="dialog alert"> [% ELSIF message.type == 'error' %] <div class="dialog error" style="margin:auto;"> [% END %] In the past we have not distinguished between warnings and errors. Both were styled with the "dialog alert" style. But I'm not opposed to defining a new style specifically for errors and setting up a guideline for its use. I can imagine it being useful to say this, for instance: - "dialog alert" used in cases where there is a problem which requires the user to respond to a question: Yes or no, proceed or cancel. - "dialog error" used in cases where the process is stopped, blocked by an error and there is no path forward. I prefer simplicity if this distinction is not necessary. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #14)
Looking at an instance where "dialog error" is used, I see this in itemtypes.tt:
[% IF message.type == 'success' %] <div class="dialog message"> [% ELSIF message.type == 'warning' %] <div class="dialog alert"> [% ELSIF message.type == 'error' %] <div class="dialog error" style="margin:auto;"> [% END %]
In the past we have not distinguished between warnings and errors. Both were styled with the "dialog alert" style. But I'm not opposed to defining a new style specifically for errors and setting up a guideline for its use. I can imagine it being useful to say this, for instance:
- "dialog alert" used in cases where there is a problem which requires the user to respond to a question: Yes or no, proceed or cancel.
- "dialog error" used in cases where the process is stopped, blocked by an error and there is no path forward.
I prefer simplicity if this distinction is not necessary.
Actually the "dialog error" is used in a lot of places: admin/authorised_values.tt admin/authtypes.tt admin/biblio_framework.tt admin/branches.tt admin/categories.tt admin/cities.tt tools/batch_record_modification.tt at least. Almost all of them have been introduced by myself. Actually we have a definition for the div.error in staff-global.css: 931 div.error { 932 >---border : 2px dashed #990000; 933 >---background-color : #FFFF99; 934 >---padding : .5em; 935 >---margin : 1em; 936 } We could adapt it if the style is not the one we expect. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- I think the essence of the issue is: Is it useful to the user to have a different style for 'alerts' and 'errors?' Would it convey information to them which helps them understand what's going on? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #16)
I think the essence of the issue is: Is it useful to the user to have a different style for 'alerts' and 'errors?' Would it convey information to them which helps them understand what's going on?
In a perfect world, we should not display the error messages after the user has submitted the form, because the values filled are lost. The check should be done when filling the form. IMO it would make sense to separate the 2 behaviors: alert the user that a choice must be made, or display an error because something wrong happened (i.e. the code needs to be fixed to prevent that). If you don't think it's necessary, I can provide a global fix to correct all occurrences. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org