http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #14)
Looking at an instance where "dialog error" is used, I see this in itemtypes.tt:
[% IF message.type == 'success' %] <div class="dialog message"> [% ELSIF message.type == 'warning' %] <div class="dialog alert"> [% ELSIF message.type == 'error' %] <div class="dialog error" style="margin:auto;"> [% END %]
In the past we have not distinguished between warnings and errors. Both were styled with the "dialog alert" style. But I'm not opposed to defining a new style specifically for errors and setting up a guideline for its use. I can imagine it being useful to say this, for instance:
- "dialog alert" used in cases where there is a problem which requires the user to respond to a question: Yes or no, proceed or cancel.
- "dialog error" used in cases where the process is stopped, blocked by an error and there is no path forward.
I prefer simplicity if this distinction is not necessary.
Actually the "dialog error" is used in a lot of places: admin/authorised_values.tt admin/authtypes.tt admin/biblio_framework.tt admin/branches.tt admin/categories.tt admin/cities.tt tools/batch_record_modification.tt at least. Almost all of them have been introduced by myself. Actually we have a definition for the div.error in staff-global.css: 931 div.error { 932 >---border : 2px dashed #990000; 933 >---background-color : #FFFF99; 934 >---padding : .5em; 935 >---margin : 1em; 936 } We could adapt it if the style is not the one we expect. -- You are receiving this mail because: You are watching all bug changes.