[Bug 22975] New: Remove type attribute from script tags: Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22975 Bug ID: 22975 Summary: Remove type attribute from script tags: Acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 22956 Target Milestone: --- This patch will remove the obsolete "type" attribute from <script> tags in the following acquisitions templates: - intranet-tmpl\prog\en\modules\acqui\basketgroup.tt - intranet-tmpl\prog\en\modules\acqui\parcels.tt - intranet-tmpl\prog\en\modules\acqui\transferorder.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22956 [Bug 22956] Omnibus: Remove type attribute from script tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22975 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22975 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22975 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 90039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90039&action=edit Bug 22975: Remove type attribute from script tags: Acquisitions This patch removes the "type" attribute from <script> tags in several acquisitions templates. Also removed: Obsolete "//<![CDATA[ //]]>" markers. This patch also makes minor indentation changes, so diff using the "-w" flag. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Acquisitions -> Vendors -> Vendor -> Basket groups - Acquisitions -> Vendors -> Vendor -> Receive shipments - Acquisitions -> Vendors -> Vendor -> Basket: In the table of orders, click "Transfer." Transfer an order Validating the HTML source of any of these pages should return no errors related to the "type" attribute. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22975 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22975 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22975 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90039|0 |1 is obsolete| | --- Comment #2 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 90056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90056&action=edit Bug 22975: Remove type attribute from script tags: Acquisitions This patch removes the "type" attribute from <script> tags in several acquisitions templates. Also removed: Obsolete "//<![CDATA[ //]]>" markers. This patch also makes minor indentation changes, so diff using the "-w" flag. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Acquisitions -> Vendors -> Vendor -> Basket groups - Acquisitions -> Vendors -> Vendor -> Receive shipments - Acquisitions -> Vendors -> Vendor -> Basket: In the table of orders, click "Transfer." Transfer an order Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22975 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22975 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90056|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 90125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90125&action=edit Bug 22975: Remove type attribute from script tags: Acquisitions This patch removes the "type" attribute from <script> tags in several acquisitions templates. Also removed: Obsolete "//<![CDATA[ //]]>" markers. This patch also makes minor indentation changes, so diff using the "-w" flag. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Acquisitions -> Vendors -> Vendor -> Basket groups - Acquisitions -> Vendors -> Vendor -> Receive shipments - Acquisitions -> Vendors -> Vendor -> Basket: In the table of orders, click "Transfer." Transfer an order Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22975 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org