[Bug 8043] New: today's checkouts are in Previous checkouts in circulation.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Priority: P5 - low Change sponsored?: --- Bug ID: 8043 CC: gmcharlt@gmail.com Assignee: kyle.m.hall@gmail.com Summary: today's checkouts are in Previous checkouts in circulation.pl Severity: enhancement Classification: Unclassified OS: All Reporter: stephane.delaune@biblibre.com Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha for a borrower, if you add a new checkout, it appears after Previous checkouts (cgi-bin/koha/circ/circulation.pl?borrowernumber=123) instead of before. Verification of today's checkouts is made between iso's date (e.g. 2012-05-04) and iso's date+time (e.g. 2012-05-04T10:31:00) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 --- Comment #1 from stephane.delaune@biblibre.com --- Created attachment 9411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9411&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 stephane.delaune@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Status|NEW |Needs Signoff Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9411|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 9455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9455&action=edit [SIGNED-OFF] Bug 8043: today's checkouts are in Previous checkouts in circulation.pl Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- It looks to me like this was signed off. Marking the bug as such. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comments: I think it is better to compare C4::Dates->new($it->{issuedate}, 'iso')->output('iso') and $todaysdate ( = C4::Dates->new->output('iso')) rather than an obscured substr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 --- Comment #5 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9891&action=edit Bug 8043 - today's checkouts are in Previous checkouts in circulation.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Hmm I think the plan is to slowly kill C4::Dates, because it doesnt understand times at all. I am not sure on that, so will check but I think that was the plan -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9455|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #7 from Nicole C. Engard <nengard@gmail.com> --- *** Bug 7925 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 --- Comment #8 from Nicole C. Engard <nengard@gmail.com> --- Just a note from the other bug report: On the checkout summary it used to split today's checkouts and previous checkouts: http://manual.koha-community.org/3.6/en/images/circ/checkoutsummary.png -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux@biblibre.co | |m --- Comment #9 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- A simple solution could be to only get date in sql request : SELECT DATE(issuedate), DATE(date_due), ... But if all thoses columns are now Datetime, I suppose that's because we need the time somewhere (I didn't see where). If C4::Dates should be abandonned, we could use DateTime module and truncate date variables to day before comparison where we don't need time. I think some kind of global best practice should be written to handle date and time consistantly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #9)
A simple solution could be to only get date in sql request : SELECT DATE(issuedate), DATE(date_due), ... But if all thoses columns are now Datetime, I suppose that's because we need the time somewhere (I didn't see where).
In circulation now, you can specify hourly loans, so times are used for calculating overdues etc.
If C4::Dates should be abandonned, we could use DateTime module and truncate date variables to day before comparison where we don't need time.
I think some kind of global best practice should be written to handle date and time consistantly.
Definitely -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9891|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 10273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10273&action=edit Bug 8043 - today's checkouts are in Previous checkouts in circulation.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10273|0 |1 is obsolete| | --- Comment #12 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 10277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10277&action=edit [SIGNED-OFF] Bug 8043 - today's checkouts are in Previous checkouts in circulation.pl Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7444 --- Comment #13 from Nicole C. Engard <nengard@gmail.com> --- The one problem here is related to bug 7444 and that's that the time has been removed. The timestamp was there because of hourly loans and needs to be there. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer@bsz-bw.de Version|rel_3_8 |master --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Switching this to "Signed off", because of Nicole's comment and attached patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: While waiting for more spectacular improvements on dates/datetimes in Koha, this simple fix works: e.g. 2012-06-20 13:00 gt 2012-06-20 in order to get today's issues. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.3. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org