[Bug 8154] New: The export today's checked in barcodes generated file is always empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Priority: P5 - low Change sponsored?: --- Bug ID: 8154 CC: gmcharlt@gmail.com Assignee: kyle.m.hall@gmail.com Summary: The export today's checked in barcodes generated file is always empty Severity: enhancement Classification: Unclassified OS: All Reporter: jonathan.druart@biblibre.com Hardware: All Status: NEW Version: unspecified Component: Circulation Product: Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6751, 6430 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle.m.hall@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9774&action=edit Bug 8154 - The export today's checked in barcodes generated file is always empty This patch is a fix for Bug 6751 already pushed in master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |blocker -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Francois Charbonnier <francois.charbonnier@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9774|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 10000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10000&action=edit Bug 8154 - The export today's checked in barcodes generated file is always empty Comparation of date and datetime is always false Signed-off-by: Francois Charbonnier <francois.charbonnier@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Francois Charbonnier <francois.charbonnier@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@biblib | |re.com --- Comment #4 from Francois Charbonnier <francois.charbonnier@biblibre.com> --- I did 2 tests : 1/ - checked-out 2 books - checked-in these books through returns.pl page - exported today's checkins barcode 2/ - checked-out 2 books - checked-in these books through circulation.pl page - exported today's checkins barcode In both cases it works. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |koha.sekjal@gmail.com --- Comment #5 from Ian Walls <koha.sekjal@gmail.com> --- Reformats the datetime in issue->{returndate} into iso-formatted date. Uses C4::Dates, rather than DateTime, though, which we're looking to phase out. if ( ($input->param('op') eq 'export_barcodes') and ($today eq C4::Dates->new( $issue->{'returndate'}, 'iso' )->output("iso")) ) { could be my $return_dt = Koha::DateUtils::dt_from_string($issue->{'returndate'}, 'iso'); if ( ($input->param('op') eq 'export_barcodes') and ($today eq $return_dt->ymd() ) { My initial testing shows this change should work, and it won't introduce a new dependence on C4::Dates we'll just have to replace later. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10000|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10344&action=edit Bug 8154: The export today's checked in barcodes generated file is always empty Comparation of date and datetime is always false -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10344|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 10364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10364&action=edit Bug 8154: The export today's checked in barcodes generated file is always empty Comparation of date and datetime is always false Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Exported file contains the list of checked in items. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Ian Walls <koha.sekjal@gmail.com> --- As this patch implements something I suggested, perhaps I'm not the best person to QA it, but from what I can tell, it does the job of fixing the comparison types most handily, and using modern Koha modules. Marking Passed QA.... if anyone objects to this, please say so. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|unspecified |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org