[Bug 38964] New: Fix column span in footer of staff interface account payment page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 Bug ID: 38964 Summary: Fix column span in footer of staff interface account payment page Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 33137 The footer of the table of charges on the account payment page has incorrect column spans, resulting in the rows having incorrect alignment. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 [Bug 33137] Make sure columns on transactions and 'pay fines' tab are matching up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177128&action=edit Bug 38964: Fix column span in footer of staff interface account payment page This patch fixes the column span in the table footer rows of the account payment page (pay.tt). I've also added a couple of lines of CSS to style the footer rows. To test, apply the patch and rebuild the staff interface CSS. - In the staff client, locate a patron with charges. - If necessary, go to a patrons "Accounting" tab and use the "Create manual invoice" page to add one or more charges to the account. - Under the "Make a payment" tab there should be one or more footer rows including "Total due." The "Total due" cell should be aligned right, with a grey background. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177128|0 |1 is obsolete| | --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 177129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177129&action=edit Bug 38964: Fix column span in footer of staff interface account payment page This patch fixes the column span in the table footer rows of the account payment page (pay.tt). I've also added a couple of lines of CSS to style the footer rows. To test, apply the patch and rebuild the staff interface CSS. - In the staff client, locate a patron with charges. - If necessary, go to a patrons "Accounting" tab and use the "Create manual invoice" page to add one or more charges to the account. - Under the "Make a payment" tab there should be one or more footer rows including "Total due." The "Total due" cell should be aligned right, with a grey background. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177129|0 |1 is obsolete| | --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177358&action=edit Bug 38964: Fix column span in footer of staff interface account payment page This patch fixes the column span in the table footer rows of the account payment page (pay.tt). I've also added a couple of lines of CSS to style the footer rows. To test, apply the patch and rebuild the staff interface CSS. - In the staff client, locate a patron with charges. - If necessary, go to a patrons "Accounting" tab and use the "Create manual invoice" page to add one or more charges to the account. - Under the "Make a payment" tab there should be one or more footer rows including "Total due." The "Total due" cell should be aligned right, with a grey background. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | CC| |lucas@bywatersolutions.com Text to go in the| |This patch fixes an release notes| |alignment problem on the | |'Make a payment' screen | |where the table footer had | |an inconsistent number of | |columns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch fixes an |This fixes an alignment release notes|alignment problem on the |problem on the 'Make a |'Make a payment' screen |payment' screen where the |where the table footer had |table footer had an |an inconsistent number of |inconsistent number of |columns. |columns. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk --- Comment #5 from Aude Charillon <aude.charillon@openfifth.co.uk> --- I believe this is also an issue in versions 24.11 and 23.11: when the Payment note column is hidden, the Total due value disappears. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39526 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 40147 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber@cityoffargo.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Wonder if this has slipped through with the release of 25.05/change of maints? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- *** Bug 40721 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 --- Comment #9 from Christopher Brannon <cbrannon@cdalibrary.org> --- Can this be backported to 24.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 --- Comment #10 from Christopher Brannon <cbrannon@cdalibrary.org> --- Workaround until backported: //Workaround for bug 177358 - Fixing payment tab in patron accounting $('#pat_pay #finest td.total').attr('colspan','14'); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 Lucy Vaux-Harvey <lucy.vaux-harvey@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@openfifth. | |co.uk --- Comment #11 from Lucy Vaux-Harvey <lucy.vaux-harvey@openfifth.co.uk> --- +1 for the workaround Christopher, much appreciated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|25.05.00 |25.05.00,24.11.09 released in| | --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #13 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Note: Without this patch, xls export is also broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #14 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38964 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #15 from Aude Charillon <aude.charillon@openfifth.co.uk> --- No need for any updates to the Koha Manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org