[Bug 39389] New: Cannot use dataTables export function on checkout table in members/moremember.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Bug ID: 39389 Summary: Cannot use dataTables export function on checkout table in members/moremember.pl Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. Find a patron with some checkouts 2. Go to members/moremember.pl?borrowernumber=X where x is the borrowernumber 3. Load the checkout table 4. Click 'Export' and choose any option. Uncaught TypeError: t.aoFooter[(intermediate value)][e] is undefined -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Carolyn Hughesman <chughesman@cclsny.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chughesman@cclsny.org --- Comment #1 from Carolyn Hughesman <chughesman@cclsny.org> --- We are experiencing this bug too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180402&action=edit Bug 39389: Don't stringify the system preference value This bug is caused by the code that is intended to hide the export column when disabled failing because the value of exports_enabled is "0" and not 0 To test: 1 - Checkout an item to a patron 2 - Disable ExportCircHistory 3 - Load the patron's circulation table on the Check Out tab 4 - Notice no export column 5 - Click 'Export' above the table and you can export 6 - Go to the patron's circulation table on the Details tab 7 - The export column shows 8 - Try to export - JS error 9 - Apply patch 10 - Clear local storage in the browser 11 - Repeat 3-6 - no more export column and you can export 12 - Enable ExportCircHistory 13 - Confirm the circ table on both pages hsows the export column and can be exported (You may need to clear local storage again) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180402|0 |1 is obsolete| | --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Created attachment 180570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180570&action=edit Bug 39389: Don't stringify the system preference value This bug is caused by the code that is intended to hide the export column when disabled failing because the value of exports_enabled is "0" and not 0 To test: 1 - Checkout an item to a patron 2 - Disable ExportCircHistory 3 - Load the patron's circulation table on the Check Out tab 4 - Notice no export column 5 - Click 'Export' above the table and you can export 6 - Go to the patron's circulation table on the Details tab 7 - The export column shows 8 - Try to export - JS error 9 - Apply patch 10 - Clear local storage in the browser 11 - Repeat 3-6 - no more export column and you can export 12 - Enable ExportCircHistory 13 - Confirm the circ table on both pages hsows the export column and can be exported (You may need to clear local storage again) Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180570|0 |1 is obsolete| | --- Comment #4 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 180626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180626&action=edit Bug 39389: Don't stringify the system preference value This bug is caused by the code that is intended to hide the export column when disabled failing because the value of exports_enabled is "0" and not 0 To test: 1 - Checkout an item to a patron 2 - Disable ExportCircHistory 3 - Load the patron's circulation table on the Check Out tab 4 - Notice no export column 5 - Click 'Export' above the table and you can export 6 - Go to the patron's circulation table on the Details tab 7 - The export column shows 8 - Try to export - JS error 9 - Apply patch 10 - Clear local storage in the browser 11 - Repeat 3-6 - no more export column and you can export 12 - Enable ExportCircHistory 13 - Confirm the circ table on both pages hsows the export column and can be exported (You may need to clear local storage again) Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Janne <janne.seppanen@lahti.fi> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 karie.straube@yavapaiaz.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karie.straube@yavapaiaz.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|lucas@bywatersolutions.com |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Trivial fix that makes perfect sense, QAing here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180626|0 |1 is obsolete| | --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181878&action=edit Bug 39389: Don't stringify the system preference value This bug is caused by the code that is intended to hide the export column when disabled failing because the value of exports_enabled is "0" and not 0 To test: 1 - Checkout an item to a patron 2 - Disable ExportCircHistory 3 - Load the patron's circulation table on the Check Out tab 4 - Notice no export column 5 - Click 'Export' above the table and you can export 6 - Go to the patron's circulation table on the Details tab 7 - The export column shows 8 - Try to export - JS error 9 - Apply patch 10 - Clear local storage in the browser 11 - Repeat 3-6 - no more export column and you can export 12 - Enable ExportCircHistory 13 - Confirm the circ table on both pages hsows the export column and can be exported (You may need to clear local storage again) Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Janne <janne.seppanen@lahti.fi> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Yep looks good at a glance. Generally I don't like to see quotes disappear from Javascript, but this is a sensible change which doesn't introduce any security issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g --- Comment #9 from Kristi <kkrueger@cuyahogalibrary.org> --- Could this be considered for backport? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40147 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I also have an error on this page, but it's: Uncaught TypeError: document.referrer.split(...)[1] is undefined Could bug 40147 be a similar issue? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk --- Comment #11 from Aude Charillon <aude.charillon@openfifth.co.uk> --- This is also an issue in 24.11 (tested on 24.11.07) and it would be good for the fix to be backported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |januszop@gmail.com --- Comment #12 from Janusz Kaczmarek <januszop@gmail.com> --- *** Bug 40733 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 --- Comment #13 from Janusz Kaczmarek <januszop@gmail.com> --- Please port it to 24.11 -- see Bug 40733. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.10 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
for i in $(cat sysprefs.txt) ; do grep $i installer/data/mysql/mandatory/sysprefs.sql | grep YesNo ; done ('ExtendedPatronAttributes','1',NULL,'Use extended patron IDs and attributes','YesNo'), ('OPACPlayMusicalInscripts','0','','If displayed musical inscripts, play midi conversion on the OPAC record details page.','YesNo'), ('OPACPopupAuthorsSearch','0','','Display the list of authors when clicking on one author.','YesNo'), ('StaffHighlightedWords','1','','Highlight search terms on staff interface','YesNo'), ('UnseenRenewals','0','','Allow renewals to be recorded as "unseen" by the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- There may be other cases I've run some grep : git grep -E '= ?"\[% Koha.Preference' -- koha-tmpl/ | awk -F '(\(|\))' '{print $2}' | sort -u > sysprefs.txt Then filter on boolean prefs : library, and count against the patrons unseen renewals limit.','YesNo'), We may have a closer look -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40623 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41314 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #16 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39389 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #17 from Aude Charillon <aude.charillon@openfifth.co.uk> --- No need for any updates to the Koha Manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org