[Bug 39917] New: Display a prompt for status alias when completing a request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 Bug ID: 39917 Summary: Display a prompt for status alias when completing a request Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: pedro.amorim@openfifth.co.uk Reporter: pedro.amorim@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: pedro.amorim@openfifth.co.uk, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 182517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182517&action=edit Bug 39917: Add tests prove t/db_dependent/Koha/ILL/Requests.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 182518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182518&action=edit Bug 39917: Add new optional 'mark_completed' ILL screen This new 'Mark completed' screen only shows when ILL_STATUS_ALIAS is not empty, i.e. Koha installations that are not using ILL_STATUS_ALIAS will not see any change in their workflow. Backends that don't implement 'mark_completed' are inherently already making use of core 'mark_completed' and will automatically adopt this enhancement. Backends that do implement their own mark_completed don't automatically adopt this enhancement and will not see any change in their workflow. Test plan: 1) Enable ILLModule sys pref 2) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Add a type, cardnumber and library. Click 'Create'. 4) You should now be on the manage request screen. Click 'Confirm' and 'Confirm request'. 5) You should be on the manage request screen again. Click 'Mark completed'. The request's status became 'Completed'. 6) Add at least one AV entry to ILL_STATUS_ALIAS av category, visit: <staff_url>/cgi-bin/koha/admin/authorised_values.pl?op=add_form&category=ILL_STATUS_ALIAS 7) Add 'abc_code' to 'Authorized value' and 'abc_description' to 'Description'. Click 'Save'. 8) Repeat steps 2 to 5. Notice that when you 'Mark completed' now, a new screen is shown prompting for a status_alias. 9) Pick a status_alias and save. Notice the 'status' now shows the alias. Sponsored-by: NHS England -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 182541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182541&action=edit Bug 39917: (QA follow-up): Fix xt/find-missing-filters.t prove xt/find-missing-filters.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182517|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 183091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183091&action=edit Bug 39917: Add tests prove t/db_dependent/Koha/ILL/Requests.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182518|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 183092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183092&action=edit Bug 39917: Add new optional 'mark_completed' ILL screen This new 'Mark completed' screen only shows when ILL_STATUS_ALIAS is not empty, i.e. Koha installations that are not using ILL_STATUS_ALIAS will not see any change in their workflow. Backends that don't implement 'mark_completed' are inherently already making use of core 'mark_completed' and will automatically adopt this enhancement. Backends that do implement their own mark_completed don't automatically adopt this enhancement and will not see any change in their workflow. Test plan: 1) Enable ILLModule sys pref 2) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Add a type, cardnumber and library. Click 'Create'. 4) You should now be on the manage request screen. Click 'Confirm' and 'Confirm request'. 5) You should be on the manage request screen again. Click 'Mark completed'. The request's status became 'Completed'. 6) Add at least one AV entry to ILL_STATUS_ALIAS av category, visit: <staff_url>/cgi-bin/koha/admin/authorised_values.pl?op=add_form&category=ILL_STATUS_ALIAS 7) Add 'abc_code' to 'Authorized value' and 'abc_description' to 'Description'. Click 'Save'. 8) Repeat steps 2 to 5. Notice that when you 'Mark completed' now, a new screen is shown prompting for a status_alias. 9) Pick a status_alias and save. Notice the 'status' now shows the alias. Sponsored-by: NHS England Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182541|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 183093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183093&action=edit Bug 39917: (QA follow-up): Fix xt/find-missing-filters.t prove xt/find-missing-filters.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement to ILL release notes| |requests lets you select a | |'status alias' when marking | |requests as complete. This | |is only shown when values | |are defined for the | |ILL_STATUS_ALIAS authorized | |values category. The alias | |is then shown in the status | |field on the request | |details page, and in the | |status column for the list | |of ILL requests. If there | |are no values defined, then | |you are not prompted to | |select a status alias. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display a prompt for status |Display a prompt for status |alias when completing a |alias when completing a |request |request if ILL_STATUS_ALIAS | |in use --- Comment #7 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Pedro Amorim from comment #2)
Backends that do implement their own mark_completed don't automatically adopt this enhancement and will not see any change in their workflow.
This is false. 'mark_completed' is always used by core and requests from any backend will adopt this new feature, meaning the screen will show as long as ILL_STATUS_ALIAS is in use. I've updated the bug title to clarify this further. The release notes are accurate as is. If that were required, a new backend_mark_completed in Koha::ILL::Request would need to be implemented and ill-requests.pl would have to invoke that instead (similar to how it does for backend_cancel or backend_confirm). Should the above be required it should be a new bug entry as it's a change in behavior. The feature in this patchset works as intended, I just wanted to correct my original comment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183091|0 |1 is obsolete| | --- Comment #8 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 185046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185046&action=edit Bug 39917: Add tests prove t/db_dependent/Koha/ILL/Requests.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183092|0 |1 is obsolete| | --- Comment #9 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 185047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185047&action=edit Bug 39917: Add new optional 'mark_completed' ILL screen This new 'Mark completed' screen only shows when ILL_STATUS_ALIAS is not empty, i.e. Koha installations that are not using ILL_STATUS_ALIAS will not see any change in their workflow. Backends that don't implement 'mark_completed' are inherently already making use of core 'mark_completed' and will automatically adopt this enhancement. Backends that do implement their own mark_completed don't automatically adopt this enhancement and will not see any change in their workflow. Test plan: 1) Enable ILLModule sys pref 2) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Add a type, cardnumber and library. Click 'Create'. 4) You should now be on the manage request screen. Click 'Confirm' and 'Confirm request'. 5) You should be on the manage request screen again. Click 'Mark completed'. The request's status became 'Completed'. 6) Add at least one AV entry to ILL_STATUS_ALIAS av category, visit: <staff_url>/cgi-bin/koha/admin/authorised_values.pl?op=add_form&category=ILL_STATUS_ALIAS 7) Add 'abc_code' to 'Authorized value' and 'abc_description' to 'Description'. Click 'Save'. 8) Repeat steps 2 to 5. Notice that when you 'Mark completed' now, a new screen is shown prompting for a status_alias. 9) Pick a status_alias and save. Notice the 'status' now shows the alias. Sponsored-by: NHS England Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183093|0 |1 is obsolete| | --- Comment #10 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 185048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185048&action=edit Bug 39917: (QA follow-up): Fix xt/find-missing-filters.t prove xt/find-missing-filters.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 --- Comment #11 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 185049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185049&action=edit Bug 39917: (QA follow-up) Correct spelling and remove <p> tag around form QA tools complained -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 --- Comment #13 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39917 Irene Tortorella <i.tortorella@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i.tortorella@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org