[Bug 38819] New: ILL - 'Switch provider' should use AutoILLBackendPriority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Bug ID: 38819 Summary: ILL - 'Switch provider' should use AutoILLBackendPriority Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: pedro.amorim@ptfs-europe.com Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: andrew.auld@ptfs-europe.com, martin.renvoize@ptfs-europe.com, pedro.amorim@ptfs-europe.com, tomascohen@gmail.com Depends on: 38669 Currently, the 'Switch provider' option lists all other installed backends and forces the user to pick one. If AutoILLBackendPriority is enabled, this action should make use of it, i.e. present the automatic backend screen, query all installed backends for availability and suggest the most appropriate one. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38669 [Bug 38669] ILL - Staff: Automatic backend screen should provide option to go back to form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176121&action=edit Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loa... 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176122&action=edit Bug 38819: Auto switch: Breadcrumbs+header titles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176123&action=edit Bug 38819: 'Return to form' vs 'return to request' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38751 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38751 [Bug 38751] Creating ILL request through OPAC openURL explodes if same attribute defined twice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176121|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 176139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176139&action=edit Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loa... 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176122|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 176140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176140&action=edit Bug 38819: Auto switch: Breadcrumbs+header titles Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176123|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 176141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176141&action=edit Bug 38819: 'Return to form' vs 'return to request' Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- I've signed off, but just a question. The "Switch provider" option disappeared for the ILL request once it switched to PluginBackend. Is that what should be expected? Testing notes (using KTD): 1. Apply the patches (and all the dependencies). 2. Update the database: updatedatabase 3. Restart everything: restart_all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to David Nind from comment #7)
I've signed off, but just a question.
The "Switch provider" option disappeared for the ILL request once it switched to PluginBackend. Is that what should be expected?
Testing notes (using KTD): 1. Apply the patches (and all the dependencies). 2. Update the database: updatedatabase 3. Restart everything: restart_all
Thank you for testing and sign-off, David! =D I can't reproduce that, the 'switch provider' option always shows for me following the test plan again. The installed plugin must be release v2.0.6, are you able to double-check if that is the release you're using? Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 --- Comment #9 from David Nind <david@davidnind.com> --- (In reply to Pedro Amorim from comment #8)
(In reply to David Nind from comment #7)
I've signed off, but just a question.
The "Switch provider" option disappeared for the ILL request once it switched to PluginBackend. Is that what should be expected?
Testing notes (using KTD): 1. Apply the patches (and all the dependencies). 2. Update the database: updatedatabase 3. Restart everything: restart_all
Thank you for testing and sign-off, David! =D I can't reproduce that, the 'switch provider' option always shows for me following the test plan again. The installed plugin must be release v2.0.6, are you able to double-check if that is the release you're using? Thanks!
You are right! Looks like I used the wrong version of the plugin. I retested, and everything works as expected + the "Switch provider" is available irrespective of the provider. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176139|0 |1 is obsolete| | --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176519&action=edit Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loa... 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176140|0 |1 is obsolete| | --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176520&action=edit Bug 38819: Auto switch: Breadcrumbs+header titles Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176141|0 |1 is obsolete| | --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176521&action=edit Bug 38819: 'Return to form' vs 'return to request' Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176575&action=edit Bug 38819: (QA follow-up): Fix find-missing-filters.t prove xt/find-missing-filters.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Somewhere in the process with all dependencies in PQA, this does not apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176519|0 |1 is obsolete| | --- Comment #15 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179733&action=edit Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loa... 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176520|0 |1 is obsolete| | --- Comment #16 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179734&action=edit Bug 38819: Auto switch: Breadcrumbs+header titles Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176521|0 |1 is obsolete| | --- Comment #17 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179735&action=edit Bug 38819: 'Return to form' vs 'return to request' Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176575|0 |1 is obsolete| | --- Comment #18 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179736&action=edit Bug 38819: (QA follow-up): Fix find-missing-filters.t prove xt/find-missing-filters.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #19 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Rebased for main (on top of tidied bug 38669) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179733|0 |1 is obsolete| | --- Comment #20 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179754&action=edit Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loa... 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179734|0 |1 is obsolete| | --- Comment #21 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179755&action=edit Bug 38819: Auto switch: Breadcrumbs+header titles Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179735|0 |1 is obsolete| | --- Comment #22 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179756&action=edit Bug 38819: 'Return to form' vs 'return to request' Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179736|0 |1 is obsolete| | --- Comment #23 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179757&action=edit Bug 38819: (QA follow-up): Fix find-missing-filters.t prove xt/find-missing-filters.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179754|0 |1 is obsolete| | --- Comment #24 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179759&action=edit Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loa... 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179755|0 |1 is obsolete| | --- Comment #25 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179760&action=edit Bug 38819: Auto switch: Breadcrumbs+header titles Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179756|0 |1 is obsolete| | --- Comment #26 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179761&action=edit Bug 38819: 'Return to form' vs 'return to request' Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179757|0 |1 is obsolete| | --- Comment #27 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179762&action=edit Bug 38819: (QA follow-up): Fix find-missing-filters.t prove xt/find-missing-filters.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179759|0 |1 is obsolete| | --- Comment #28 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180340&action=edit Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loa... 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180340|0 |1 is obsolete| | --- Comment #29 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180341&action=edit Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loa... 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180341|0 |1 is obsolete| | --- Comment #30 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180345&action=edit Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loa... 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180345|0 |1 is obsolete| | --- Comment #31 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180346&action=edit Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loa... 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180346|0 |1 is obsolete| | --- Comment #32 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180349&action=edit Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loa... 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180349|0 |1 is obsolete| | --- Comment #33 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180351&action=edit Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loa... 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180351|0 |1 is obsolete| | --- Comment #34 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180353&action=edit Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loa... 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180353|0 |1 is obsolete| | --- Comment #35 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180367&action=edit Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loa... 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180367|0 |1 is obsolete| | --- Comment #36 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180390&action=edit Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loa... 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179760|0 |1 is obsolete| | --- Comment #37 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180391&action=edit Bug 38819: Auto switch: Breadcrumbs+header titles Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179761|0 |1 is obsolete| | --- Comment #38 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180392&action=edit Bug 38819: 'Return to form' vs 'return to request' Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179762|0 |1 is obsolete| | --- Comment #39 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180393&action=edit Bug 38819: (QA follow-up): Fix find-missing-filters.t prove xt/find-missing-filters.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #40 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- `ill-requests.tt` has some stray merge markers. Please fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180390|0 |1 is obsolete| | --- Comment #41 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180509&action=edit Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loa... 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180391|0 |1 is obsolete| | --- Comment #42 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180510&action=edit Bug 38819: Auto switch: Breadcrumbs+header titles Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180392|0 |1 is obsolete| | --- Comment #43 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180511&action=edit Bug 38819: 'Return to form' vs 'return to request' Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180393|0 |1 is obsolete| | --- Comment #44 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180512&action=edit Bug 38819: (QA follow-up): Fix find-missing-filters.t prove xt/find-missing-filters.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 --- Comment #45 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #40)
`ill-requests.tt` has some stray merge markers. Please fix.
Thanks for spotting that! Fixed and reran qa script, all happy. Changed to PQA as discussed. Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180509|0 |1 is obsolete| | Attachment #180510|0 |1 is obsolete| | Attachment #180511|0 |1 is obsolete| | Attachment #180512|0 |1 is obsolete| | --- Comment #46 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 180514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180514&action=edit Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loa... 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 --- Comment #47 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 180515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180515&action=edit Bug 38819: Auto switch: Breadcrumbs+header titles Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 --- Comment #48 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 180516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180516&action=edit Bug 38819: 'Return to form' vs 'return to request' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 --- Comment #49 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 180517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180517&action=edit Bug 38819: (QA follow-up): Fix find-missing-filters.t prove xt/find-missing-filters.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply Keywords| |release-notes-needed --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Pedro, can you please rebase on latest main? Hope I didn't miss a dependency? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 38819: Auto migrate controller logic Applying: Bug 38819: Auto switch: Breadcrumbs+header titles error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt). error: could not build fake ancestor Patch failed at 0001 Bug 38819: Auto switch: Breadcrumbs+header titles hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-38819-Auto-switch-Breadcrumbsheader-titles-qzi0v8nr.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180514|0 |1 is obsolete| | --- Comment #51 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181348&action=edit Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loa... 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180515|0 |1 is obsolete| | --- Comment #52 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181349&action=edit Bug 38819: Auto switch: Breadcrumbs+header titles Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180516|0 |1 is obsolete| | --- Comment #53 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181350&action=edit Bug 38819: 'Return to form' vs 'return to request' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180517|0 |1 is obsolete| | --- Comment #54 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181351&action=edit Bug 38819: (QA follow-up): Fix find-missing-filters.t prove xt/find-missing-filters.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 --- Comment #55 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Looks like a slight rebase on top of bug 38685 was required. I must've forgotten to set this dependency. Apologies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- + <span>Confirm switch provider</span> Just wondering if we might want to switch to "Confirm switching provider" or "Confirm provider switch" (I am not a native speaker, so happy to be told I am talking nonsense :) ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 --- Comment #57 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 --- Comment #58 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Katrin Fischer from comment #56)
+ <span>Confirm switch provider</span>
Just wondering if we might want to switch to "Confirm switching provider" or "Confirm provider switch" (I am not a native speaker, so happy to be told I am talking nonsense :) )
Fair, I agree. Though the button clicked to visit the page is labeled "Switch provider", for that reason I think it makes sense to use those 2 words exactly. "Switch provider confirmation"? Or just simply "Switch provider" as this is the page header+breadcrumbs and the "confirm/confirmation" part may be redundant. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 --- Comment #59 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #58)
(In reply to Katrin Fischer from comment #56)
+ <span>Confirm switch provider</span>
Just wondering if we might want to switch to "Confirm switching provider" or "Confirm provider switch" (I am not a native speaker, so happy to be told I am talking nonsense :) )
Fair, I agree. Though the button clicked to visit the page is labeled "Switch provider", for that reason I think it makes sense to use those 2 words exactly. "Switch provider confirmation"? Or just simply "Switch provider" as this is the page header+breadcrumbs and the "confirm/confirmation" part may be redundant.
We can still do that later - I think we have some existing patterns in the administration module for deleting things. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #60 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Dropping the question about string change - as noted earlier, we can deal with that later/separately if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | CC| |lisette@bywatersolutions.co | |m Text to go in the| |This enhancement changes release notes| |the 'Switch provider' | |button on ILl requests to | |use the | |AutoILLBackendPriority | |feature when configured. | |The button will now present | |the automatic backend | |screen, query all installed | |backends for availability | |and suggest the most | |appropriate one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement changes |This enhancement changes release notes|the 'Switch provider' |the 'Switch provider' |button on ILl requests to |button on ILl requests to |use the |use the |AutoILLBackendPriority |`AutoILLBackendPriority` |feature when configured. |feature when configured. |The button will now present |The button will now present |the automatic backend |the automatic backend |screen, query all installed |screen, query all installed |backends for availability |backends for availability |and suggest the most |and suggest the most |appropriate one. |appropriate one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement changes |This enhancement changes release notes|the 'Switch provider' |the 'Switch provider' |button on ILl requests to |button on ILL requests to |use the |use the |`AutoILLBackendPriority` |`AutoILLBackendPriority` |feature when configured. |feature when configured. |The button will now present |The button will now present |the automatic backend |the automatic backend |screen, query all installed |screen, query all installed |backends for availability |backends for availability |and suggest the most |and suggest the most |appropriate one. |appropriate one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #61 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 38669 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38819 Bug 38819 depends on bug 38751, which changed state. Bug 38751 Summary: Creating ILL request through OPAC openURL explodes if same attribute defined twice https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38751 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org