[Bug 8791] New: OPAC UNIMARC XSLT details : subject with subfield 3
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8791 Priority: P5 - low Change sponsored?: --- Bug ID: 8791 Assignee: oleonard@myacpl.org Summary: OPAC UNIMARC XSLT details : subject with subfield 3 Severity: normal Classification: Unclassified OS: All Reporter: fridolyn.somers@biblibre.com Hardware: All Status: NEW Version: master Component: OPAC Product: Koha On OPAC details page with XSLT, when a subject field has $3, $9 and other subfields, $9 is displayed instead of other subfields. Example : <datafield tag="606" ind1=" " ind2=" "> <subfield code="9">331978</subfield> <subfield code="3">027214724</subfield> <subfield code="a">Revolution</subfield> </datafield> This comes from UNIMARCslimUtils.xsl tag_onesubject template : Subfields $2 and $3 stops the display variable computing. Without XSLT, subjects are displayed with only non-numerical subfields [a-zA-Z]. So $2 and $3 should just be avoid in display var. Example should be displayed : <a href="/cgi-bin/koha/opac-search.pl?q=an:331978">Revolution</a> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8791 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 12334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12334&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8791 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6314 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8791 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #2 from Frédéric Demians <frederic@tamil.fr> ---
Example : <datafield tag="606" ind1=" " ind2=" "> <subfield code="9">331978</subfield> <subfield code="3">027214724</subfield> <subfield code="a">Revolution</subfield> </datafield>
For me such a field is properly displayed with the current UNIMARC XSL. Could you provide a complete sample record (in ISO2709)? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8791 --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- Sorry I was wrong! I was testing with your patch already applied! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8791 --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 12687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12687&action=edit Bug 8791: OPAC UNIMARC XSLT details: subject with subfield 3 Signed-off-by: Frédéric Demians <f.demians@tamil.fr> I can reproduce the bug, and confirm that this patch fix it. The issue arises when $9 come first, and then $3, which is not that usual. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8791 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12334|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8791 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8791 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment * tiny fix * UNIMARC XSLT related only, no side-effect risk * koha-qa.pl OK passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8791 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8791 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- No string changes pushed to 3.8.x, will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org