[Bug 5755] New: Control facets truncation on OPAC result page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 Summary: Control facets truncation on OPAC result page Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Searching AssignedTo: gmcharlt@gmail.com ReportedBy: frederic@tamil.fr QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 On OPAC result page facets are truncated to 20 characters. On some OPAC layout, it's not enough. A new syspref FacetOpacMaxLength defines the length to cut facets if necessary. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|gmcharlt@gmail.com |frederic@tamil.fr -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 --- Comment #1 from Frédéric Demians <frederic@tamil.fr> 2011-02-14 08:30:31 UTC --- Created attachment 3143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3143 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |nengard@gmail.com Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@gmail.com --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-02-15 11:24:32 UTC --- (In reply to comment #1)
Created attachment 3143 [details] Proposed patch
I think "FacetOpacMaxLength" is too ambiguous. It may signify the number of biblio used in the computation of facets. Also, Search.pm is for both OPAC and Intranet. So both will be impacted by the system pref, no? I suggest "FacetLabelMaxLength". Regards, -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 --- Comment #3 from Frédéric Demians <frederic@tamil.fr> 2011-02-15 16:32:01 UTC ---
I think "FacetOpacMaxLength" is too ambiguous. It may signify the number of biblio used in the computation of facets.
An English speaking person may have to say his word on that.
Also, Search.pm is for both OPAC and Intranet. So both will be impacted by the system pref, no?
Yes, you get a point.
I suggest "FacetLabelMaxLength".
Or FacetTruncationLength? Thanks. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 --- Comment #4 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-02-16 07:49:32 UTC --- (In reply to comment #3)
Or FacetTruncationLength?
Ok, but with "label" : FacetLabelTruncationLength Regards, -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 --- Comment #5 from Frédéric Demians <frederic@tamil.fr> 2011-02-16 15:58:11 UTC --- Created attachment 3161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3161 Version with Frydolin syspref name -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 --- Comment #6 from Frédéric Demians <frederic@tamil.fr> 2011-02-16 15:58:41 UTC ---
Version with Frydolin syspref name
Fridolyn... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Patch Status|Needs Signoff |Does not apply --- Comment #7 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-03-06 15:43:54 UTC --- This bug is mentioned in: Bug 5755: Syspref to control facets truncation http://lists.koha-community.org/pipermail/koha-patches/2011-February/013849.... Bug 5755: Syspref to control facets truncation http://lists.koha-community.org/pipermail/koha-patches/2011-February/013851.... Bug 5755: Syspref to control facets truncation http://lists.koha-community.org/pipermail/koha-patches/2011-February/013853.... Bug 5755: Syspref to control facets truncation http://lists.koha-community.org/pipermail/koha-patches/2011-February/013875.... --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-11 10:43:47 UTC --- Patch does not apply. I think it comes from '\ No newline at end of file' lines. These lines are present in both proposed patches. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 --- Comment #9 from Frédéric Demians <frederic@tamil.fr> 2011-03-11 12:06:02 UTC --- (In reply to comment #8)
Patch does not apply. I think it comes from '\ No newline at end of file' lines. These lines are present in both proposed patches.
Thanks Julian for trying. This is due to a merge conflict. This patch affects syspref definition files which have changed since the patch submission. I will try to find time to rebase it to master and resubmit. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 --- Comment #10 from Frédéric Demians <frederic@tamil.fr> 2011-03-11 12:17:15 UTC --- Created attachment 3283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3283 New version rebased on HEAD -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-11 12:55:48 UTC --- Tested, it works. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-16 23:25:25 UTC --- Are we sure we dont want to add an updatedatabase for this? That means no one who ever upgrades can get this new feature. Only people who newly install can ... Please submit a follow up patch doing the updatedatabase to insert the syspref, defaulting it to 20, so that people upgrading can now (or in the future) turn this on. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 --- Comment #13 from Frédéric Demians <frederic@tamil.fr> 2011-03-17 06:12:07 UTC ---
Are we sure we dont want to add an updatedatabase for this? That means no one who ever upgrades can get this new feature. Only people who newly install can ...
System preferences > Searching tab > Result Display section. Their,
It isn't actually correct. People will just have to go in Administration they will find FacetLabelTruncationLength syspref since the patch add it to search.tmpl. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-17 06:49:58 UTC --- I am not sure this will not add confusion. If I understand this correctly there will be no entry in the sys pref table until the sys pref is changed? Perhaps we should not do this different from the other sys prefs without a good reason. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 --- Comment #15 from Frédéric Demians <frederic@tamil.fr> 2011-03-17 09:11:42 UTC ---
I am not sure this will not add confusion. If I understand this correctly there will be no entry in the sys pref table until the sys pref is changed?
You understand correctly! Chris, please, just confirm you want an DB update for this syspref. I will send it. Thanks. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-18 01:41:06 UTC --- Yes please, lets do it the same as the others a least until 3.4 is released :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #17 from Nicole C. Engard <nengard@gmail.com> 2011-03-19 15:38:17 UTC --- Signed off on the two patches. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #18 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-22 08:16:19 UTC --- Pushed please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5755 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org