[Bug 19376] New: Add 655$a (Genre/Form) to zebra search facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Bug ID: 19376 Summary: Add 655$a (Genre/Form) to zebra search facets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Zebra Assignee: david.bourgault@inlibro.com Reporter: david.bourgault@inlibro.com This is a functionality we have with some clients, that we would like to push to the Koha community. It has no impact on libraries that ignore the 655$a tag, but enhances search filtering for those who do. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.bourgault@inlibro.com | |, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
You should see the "Genre form" filter appear on the left
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 --- Comment #1 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 67412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67412&action=edit Bug 19376 - Adds 655$a to Zebra facets Test plan: 0) Apply patch 1) Depending on your setup, copy the content of the following files to their counterparts in /etc/ (or where your Koha configuration files are) : <git>/etc/zebradb/biblios/etc/bib1.att <git>/etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml <git>/etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xsl <git>/etc/zebradb/marc_defs/marc21/biblios/record.abs <git>/etc/zebradb/ccl.properties 2) Edit a record to use the 655$a MARC tag, if you don't already 3) In the OPAC or Intranet, execute a search that would get a hit on the record you edited. 4) Click on the entry under "Genre form"
You should now only see the records with the matching 655$a tag.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 67412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67412 Bug 19376 - Adds 655$a to Zebra facets Review of attachment 67412: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19376&attachment=67412) ----------------------------------------------------------------- ::: etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml @@ -777,5 @@
- <target_index>Subject:p</target_index> - </index_data_field> - <!--record.abs line 189: melm 656$9 Koha-Auth-Number --> - <index_subfields tag="656" subfields="9"> - <target_index>Koha-Auth-Number:w</target_index>
Why are you removing these lines? It will break search when using authorities with 655 (link build using $9) and libraries using more than the $a subfield. (http://www.loc.gov/marc/bibliographic/bd655.html) ::: etc/zebradb/marc_defs/marc21/biblios/record.abs @@ -198,2 @@
melm 655$9 Koha-Auth-Number -melm 655 Subject,Subject:p
These changes are not necessary as grs-1 is deprecated, but will also be a regression if you want to search for sufields other than $a: http://www.loc.gov/marc/bibliographic/bd655.html ::: koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc @@ +15,4 @@
[% IF facets_loo.type_label_Authors %]<span id="facet-authors">Authors</span>[% END %] [% IF facets_loo.type_label_Titles %]<span id="facet-titles">Titles</span>[% END %] [% IF facets_loo.type_label_Topics %]<span id="facet-topics">Topics</span>[% END %] +[% IF facets_loo.type_label_GenreForm %]<span id="facet-genreform">Genre form</span>[% END %]
I think it should probably be Genre/Form matching the detail page :) ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc @@ +21,4 @@
<li id="[% facets_loo.type_id %]"> [% IF facets_loo.type_label_Authors %]<h5 id="facet-authors">Authors</h5>[% END %] [% IF facets_loo.type_label_Titles %]<h5 id="facet-titles">Titles</h5>[% END %] + [% IF facets_loo.type_label_GenreForm %]<h5 id="facet-genreform">Genre form</h5>[% END %]
Same here as above: Genre/Form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 --- Comment #3 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 68221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68221&action=edit Bug 19376 - Follow-up on QA Reverted useless/bad modifications. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 --- Comment #4 from David Bourgault <david.bourgault@inlibro.com> --- I corrected configuration files and renamed 'Genre form' to 'Genre/Form' per Katrin's comment. The test plan is that same as before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68221|0 |1 is obsolete| | --- Comment #5 from Hugo Agud <hagud@orex.es> --- Created attachment 68245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68245&action=edit Bug 19376 - Follow-up on QA Reverted useless/bad modifications. Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es Attachment #68245|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68221|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
You should see the "Genre form" filter appear on the left
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67412|0 |1 is obsolete| | --- Comment #6 from Hugo Agud <hagud@orex.es> --- Created attachment 68388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68388&action=edit Bug 19376 - Adds 655$a to Zebra facets Test plan: 0) Apply patch 1) Depending on your setup, copy the content of the following files to their counterparts in /etc/ (or where your Koha configuration files are) : <git>/etc/zebradb/biblios/etc/bib1.att <git>/etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml <git>/etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xsl <git>/etc/zebradb/marc_defs/marc21/biblios/record.abs <git>/etc/zebradb/ccl.properties 2) Edit a record to use the 655$a MARC tag, if you don't already 3) In the OPAC or Intranet, execute a search that would get a hit on the record you edited. 4) Click on the entry under "Genre form"
You should now only see the records with the matching 655$a tag.
Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68221|0 |1 is obsolete| | --- Comment #7 from Hugo Agud <hagud@orex.es> --- Created attachment 68389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68389&action=edit Bug 19376 - Follow-up on QA Reverted useless/bad modifications. Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi David, this is almost there, sorry to bug you again: <index_subfields tag="655" subfields="a"> <target_index>Index-term-genre:w</target_index> <target_index>Index-term-genre:p</target_index> - <target_index>Subject:w</target_index> - <target_index>Subject:p</target_index> + <target_index>gen-for:w</target_index> + <target_index>gen-for:p</target_index> </index_subfields> These lines remove 655 from the general Subject index. Could you please keep it in the general index and only add your specific one? Otherwise I think this looks good! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 --- Comment #9 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 71978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71978&action=edit Bug 19376 - Keep 655 in the general Subject index -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |charles.farmer@inlibro.com --- Comment #10 from Charles Farmer <charles.farmer@inlibro.com> --- Added this bit back into /etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml:
<target_index>Subject:w</target_index> <target_index>Subject:p</target_index>
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68388|0 |1 is obsolete| | Attachment #68389|0 |1 is obsolete| | Attachment #71978|0 |1 is obsolete| | --- Comment #11 from Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> --- Created attachment 84377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84377&action=edit Rebased on current master. Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 --- Comment #12 from Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> --- Created attachment 84378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84378&action=edit Bug 19376 - Adds 655$a to Zebra facets Rebased on current master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 --- Comment #13 from Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> --- Created attachment 84379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84379&action=edit Bug 19376 - Follow-up on QA Reverted useless/bad modifications. Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 --- Comment #14 from Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> --- Created attachment 84380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84380&action=edit Bug 19376 - Keep 655 in the general Subject index -- You are receiving this mail because: You are watching all bug changes.
You should see the "Genre form" filter appear on the left
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84377|0 |1 is obsolete| | Attachment #84378|0 |1 is obsolete| | Attachment #84379|0 |1 is obsolete| | Attachment #84380|0 |1 is obsolete| | --- Comment #15 from Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> --- Created attachment 84383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84383&action=edit Bug 19376 - Adds 655$a to Zebra facets Test plan: 0) Apply patch 1) Depending on your setup, copy the content of the following files to their counterparts in /etc/ (or where your Koha configuration files are) : <git>/etc/zebradb/biblios/etc/bib1.att <git>/etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml <git>/etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xsl <git>/etc/zebradb/marc_defs/marc21/biblios/record.abs <git>/etc/zebradb/ccl.properties 2) Edit a record to use the 655$a MARC tag, if you don't already 3) In the OPAC or Intranet, execute a search that would get a hit on the record you edited. 4) Click on the entry under "Genre form"
You should now only see the records with the matching 655$a tag.
Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 --- Comment #16 from Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> --- Created attachment 84384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84384&action=edit Bug 19376 - Follow-up on QA Reverted useless/bad modifications. Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 --- Comment #17 from Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> --- Created attachment 84385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84385&action=edit Bug 19376 - Keep 655 in the general Subject index -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Nadine Pierre <nadine.pierre@InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nadine.pierre@InLibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mazen.i.khallaf@gmail.com --- Comment #18 from Mazen Khallaf <mazen.i.khallaf@gmail.com> --- Could not apply patch git bz apply 19376 Bug 19376 - Add 655$a (Genre/Form) to zebra search facets 84383 - Bug 19376 - Adds 655$a to Zebra facets 84384 - Bug 19376 - Follow-up on QA 84385 - Bug 19376 - Keep 655 in the general Subject index Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19376 - Adds 655$a to Zebra facets Using index info to reconstruct a base tree... M C4/Koha.pm M C4/Search.pm M etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml M etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl M koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc M koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc Auto-merging etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl Auto-merging etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml Auto-merging C4/Search.pm Auto-merging C4/Koha.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 19376 - Adds 655$a to Zebra facets The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-19376---Adds-655a-to-Zebra-facets-gCwpao.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|charles.farmer@inlibro.com, |caroline.cyr-la-rose@inlibr |david.bourgault@inlibro.com |o.com |, | |francois.charbonnier@inlibr | |o.com, | |nadine.pierre@InLibro.com | Assignee|david.bourgault@inlibro.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org