[Bug 19368] New: Add syspref to ignore words when sorting serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Bug ID: 19368 Summary: Add syspref to ignore words when sorting serials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: david.bourgault@inlibro.com Reporter: david.bourgault@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com, philippe.blouin@inlibro.com This is a functionality we offer some of our clients that we would like to push to the community. It adds a system preference containing a list of words, which are ignored when sorting the serial search results table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #1 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 67373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67373&action=edit Bug 19368 - Ignore words when sorting serial search This adds the 'SerialSortIgnoreWords' system preference. It is empty by default, since words to ignore are very much language-specific. The functionality is achieved by adding a hidden column to the table, and sorting by this column by default. The downfall of this solution is that if the user sorts by another column, they cannot go back to this sorting without refreshing the page. To test: 0) Apply patch 1) Run updatedatabase.pl 2) Add test subscriptions if you have none. Make sure to have subscriptions starting with "The An A" or similar 3) Go to system preferences and edit the SerialSortIgnoreWords pref Add the words "The An A" or the ones you used in your subscriptions 4) Go to Serials 5) Search serials (empty field will return all serials) 6) Result table should be sorted ignoring leading "The An A..." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 67373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67373 Bug 19368 - Ignore words when sorting serial search Review of attachment 67373: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19368&attachment=67373) ----------------------------------------------------------------- Nice enhancement David. Just few comments/issues, all looks easy to fix ;) In update database file, don't use INSERT IGNORE, it is mysqlism. Better to make update files using perl skeleton and do needed db tests in the code. ::: installer/data/mysql/sysprefs.sql @@ +475,4 @@
('SelfCheckTimeout','120','','Define the number of seconds before the Web-based Self Checkout times out a patron','Integer'), ('SeparateHoldings','0',NULL,'Separate current branch holdings from other holdings','YesNo'), ('SeparateHoldingsBranch','homebranch','homebranch|holdingbranch','Branch used to separate holdings','Choice'), +('SerialSortIgnoreWords','des du de la le les leur d l an a the',NULL,'Words to ignore in serial search','Free'),
Your commit message says, it's empty by default... which is good idea IMHO ::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt @@ +38,4 @@
return confirm(_("Are you sure you want to reopen this subscription?")); }); }); + $
typo? ::: serials/serials-search.pl @@ +139,5 @@
+ } + $subsctitle =~ s/^\s+//; + $sub->{titlesort} = ucfirst($subsctitle); + + warn $subsctitle;
please, remove this warn -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #3 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 67447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67447&action=edit Bug 19368 - Correction on QA feedback - Removed 'IGNORE' in the atomicupdate SQL. There is currently no other systempreference by that name in master so that should work fine - Removed leftover test values from syspref.sql - Removed extra '$' in serial-search.tt - Removed leftover 'warn' in serial-search.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67373|0 |1 is obsolete| | --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 67580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67580&action=edit Bug 19368 - Ignore words when sorting serial search This adds the 'SerialSortIgnoreWords' system preference. It is empty by default, since words to ignore are very much language-specific. The functionality is achieved by adding a hidden column to the table, and sorting by this column by default. The downfall of this solution is that if the user sorts by another column, they cannot go back to this sorting without refreshing the page. To test: 0) Apply patch 1) Run updatedatabase.pl 2) Add test subscriptions if you have none. Make sure to have subscriptions starting with "The An A" or similar 3) Go to system preferences and edit the SerialSortIgnoreWords pref Add the words "The An A" or the ones you used in your subscriptions 4) Go to Serials 5) Search serials (empty field will return all serials) 6) Result table should be sorted ignoring leading "The An A..." Followed test plan, patch works as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67447|0 |1 is obsolete| | --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 67581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67581&action=edit Bug 19368 - Correction on QA feedback * I removed the IGNORE in the atomicupdate SQL. There is currently no other systempreference by that name in Master so that should work fine - Removed leftover test values from syspref.sql - Removed extra $ in serial-search.tt - Removed leftover warn in serial-search.pl Passes QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel like this is trying to achieve something for one table, that we need a more general solution for. At the moment we already do something like this for other tables using a translatable string: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet... var CONFIG_EXCLUDE_ARTICLES_FROM_SORT = _("a an the"); Maybe we should just move this string to be a system preference and then use it for serials too? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think with the patch both methods would be used at the same time - anti-the and the new perl based method. Note: Example content of the pref should at least also contain English articles! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #8 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 67612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67612&action=edit Bug 19368 - Syspref now "SortIgnoreArticles", used in datatables.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #9 from David Bourgault <david.bourgault@inlibro.com> --- I updated the systempreference name to something more global (SortIgnoreWords) and updated datatables.inc to use it (opac and intranet). Test plan is same as before, plus testing any table that uses datatables.inc. Sponsored by : CCSR -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |alexbuckley@catalyst.net.nz --- Comment #10 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi David The syspref SortIgnoreArticles is not being displaying in the Global System preferences module to fix this can you please add SortIgnoreArticles syspref to the admin.pref YAML file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67612|0 |1 is obsolete| | --- Comment #11 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 69005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69005&action=edit Bug 19368 - Syspref now "SortIgnoreArticles", used in datatables.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #12 from David Bourgault <david.bourgault@inlibro.com> --- Updated incorrect YAML preference file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #13 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (Reply to David Bourgault in comment 12) Yes I would have thought the serials.pref file would be the most suitable YAML file to be updated. I think I was wrong in comment 10. Can you please add a patch to add SortIgnoreArticles to serials.pref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As this now not only works for Serials, but for datatables in general, I think maybe it would better fit on the 'staff client' tab? Hope I didn't misunderstand the change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67580|0 |1 is obsolete| | --- Comment #15 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 70051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70051&action=edit Bug 19368 - Ignore words when sorting serial search This adds the 'SerialSortIgnoreWords' system preference. It is empty by default, since words to ignore are very much language-specific. The functionality is achieved by adding a hidden column to the table, and sorting by this column by default. The downfall of this solution is that if the user sorts by another column, they cannot go back to this sorting without refreshing the page. To test: 0) Apply patch 1) Run updatedatabase.pl 2) Add test subscriptions if you have none. Make sure to have subscriptions starting with "The An A" or similar 3) Go to system preferences and edit the SerialSortIgnoreWords pref Add the words "The An A" or the ones you used in your subscriptions 4) Go to Serials 5) Search serials (empty field will return all serials) 6) Result table should be sorted ignoring leading "The An A..." Followed test plan, patch works as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67581|0 |1 is obsolete| | --- Comment #16 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 70052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70052&action=edit Bug 19368 - Correction on QA feedback * I removed the IGNORE in the atomicupdate SQL. There is currently no other systempreference by that name in Master so that should work fine - Removed leftover test values from syspref.sql - Removed extra $ in serial-search.tt - Removed leftover warn in serial-search.pl Passes QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69005|0 |1 is obsolete| | --- Comment #17 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 70053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70053&action=edit Bug 19368 - Syspref now "SortIgnoreArticles", used in datatables.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer@inlibro.com --- Comment #18 from Charles Farmer <charles.farmer@inlibro.com> --- Necessary rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #19 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 70125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70125&action=edit Bug 19368 - Removed the old preference 'SerialSortIgnoreWords' that was left hanging in serials.pref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #20 from Charles Farmer <charles.farmer@inlibro.com> --- (In reply to Katrin Fischer from comment #14)
As this now not only works for Serials, but for datatables in general, I think maybe it would better fit on the 'staff client' tab? Hope I didn't misunderstand the change.
The preference was recently moved from serials.pref to searching.pref to account, as you said, for the more 'global' impact the change has on datatables. I have no qualms moving it though, if admin/preferences/searching.pref is not where you feel it should be. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70051|0 |1 is obsolete| | --- Comment #21 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 71962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71962&action=edit Bug 19368 - Ignore words when sorting serial search This adds the 'SerialSortIgnoreWords' system preference. It is empty by default, since words to ignore are very much language-specific. The functionality is achieved by adding a hidden column to the table, and sorting by this column by default. The downfall of this solution is that if the user sorts by another column, they cannot go back to this sorting without refreshing the page. To test: 0) Apply patch 1) Run updatedatabase.pl 2) Add test subscriptions if you have none. Make sure to have subscriptions starting with "The An A" or similar 3) Go to system preferences and edit the SerialSortIgnoreWords pref Add the words "The An A" or the ones you used in your subscriptions 4) Go to Serials 5) Search serials (empty field will return all serials) 6) Result table should be sorted ignoring leading "The An A..." Followed test plan, patch works as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70052|0 |1 is obsolete| | --- Comment #22 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 71963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71963&action=edit Bug 19368 - Correction on QA feedback * I removed the IGNORE in the atomicupdate SQL. There is currently no other systempreference by that name in Master so that should work fine - Removed leftover test values from syspref.sql - Removed extra $ in serial-search.tt - Removed leftover warn in serial-search.pl Passes QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70053|0 |1 is obsolete| | --- Comment #23 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 71964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71964&action=edit Bug 19368 - Syspref now "SortIgnoreArticles", used in datatables.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70125|0 |1 is obsolete| | --- Comment #24 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 71965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71965&action=edit Bug 19368 - Removed the old preference 'SerialSortIgnoreWords' that was left hanging in serials.pref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #25 from Charles Farmer <charles.farmer@inlibro.com> --- Rebased on current master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@joensuu.fi --- Comment #26 from paxed <pasi.kallinen@joensuu.fi> --- Comment on attachment 71962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71962 Bug 19368 - Ignore words when sorting serial search You're comparing the stopwords to the _unaccented_ subscription title. This isn't mentioned in the SerialSortIgnoreWords description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71962|0 |1 is obsolete| | --- Comment #27 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 72043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72043&action=edit Bug 19368 - Ignore words when sorting serial search This adds the 'SerialSortIgnoreWords' system preference. It is empty by default, since words to ignore are very much language-specific. The functionality is achieved by adding a hidden column to the table, and sorting by this column by default. The downfall of this solution is that if the user sorts by another column, they cannot go back to this sorting without refreshing the page. To test: 0) Apply patch 1) Run updatedatabase.pl 2) Add test subscriptions if you have none. Make sure to have subscriptions starting with "The An A" or similar 3) Go to system preferences and edit the SerialSortIgnoreWords pref Add the words "The An A" or the ones you used in your subscriptions 4) Go to Serials 5) Search serials (empty field will return all serials) 6) Result table should be sorted ignoring leading "The An A..." Followed test plan, patch works as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71963|0 |1 is obsolete| | --- Comment #28 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 72044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72044&action=edit Bug 19368 - Correction on QA feedback * I removed the IGNORE in the atomicupdate SQL. There is currently no other systempreference by that name in Master so that should work fine - Removed leftover test values from syspref.sql - Removed extra $ in serial-search.tt - Removed leftover warn in serial-search.pl Passes QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71964|0 |1 is obsolete| | --- Comment #29 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 72045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72045&action=edit Bug 19368 - Syspref now "SortIgnoreArticles", used in datatables.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71965|0 |1 is obsolete| | --- Comment #30 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 72046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72046&action=edit Bug 19368 - Removed the old preference 'SerialSortIgnoreWords' that was left hanging in serials.pref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #31 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 72047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72047&action=edit Bug 19368 - clearly state, in the pref's desc, that the comparison is done against unaccented title -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #32 from Charles Farmer <charles.farmer@inlibro.com> --- As per comment#26, I made sure to warn the end-user, in the pref's description, that the comparison was done against the unaccented title. Rebased the rest on the current master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #33 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72043|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72044|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72045|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72046|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72047|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #34 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 72655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72655&action=edit Bug 19368 - Ignore words when sorting serial search This adds the 'SerialSortIgnoreWords' system preference. It is empty by default, since words to ignore are very much language-specific. The functionality is achieved by adding a hidden column to the table, and sorting by this column by default. The downfall of this solution is that if the user sorts by another column, they cannot go back to this sorting without refreshing the page. To test: 0) Apply patch 1) Run updatedatabase.pl 2) Add test subscriptions if you have none. Make sure to have subscriptions starting with "The An A" or similar 3) Go to system preferences and edit the SerialSortIgnoreWords pref Add the words "The An A" or the ones you used in your subscriptions 4) Go to Serials 5) Search serials (empty field will return all serials) 6) Result table should be sorted ignoring leading "The An A..." Followed test plan, patch works as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #35 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 72656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72656&action=edit Bug 19368 - Correction on QA feedback * I removed the IGNORE in the atomicupdate SQL. There is currently no other systempreference by that name in Master so that should work fine - Removed leftover test values from syspref.sql - Removed extra $ in serial-search.tt - Removed leftover warn in serial-search.pl Passes QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #36 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 72657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72657&action=edit Bug 19368 - Syspref now "SortIgnoreArticles", used in datatables.inc Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #37 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 72658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72658&action=edit Bug 19368 - Removed the old preference 'SerialSortIgnoreWords' that was left hanging in serials.pref Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #38 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 72659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72659&action=edit Bug 19368 - clearly state, in the pref's desc, that the comparison is done against unaccented title Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #39 from Séverine Queune <severine.queune@bulac.fr> --- This patch works perfectly ! A detail : the syspref is "SortIgnoreArticles" and not "SerialSortIgnoreWords". Thanks for this work ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72655|0 |1 is obsolete| | --- Comment #40 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 74262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74262&action=edit Bug 19368 - Ignore words when sorting serial search This adds the 'SerialSortIgnoreWords' system preference. It is empty by default, since words to ignore are very much language-specific. The functionality is achieved by adding a hidden column to the table, and sorting by this column by default. The downfall of this solution is that if the user sorts by another column, they cannot go back to this sorting without refreshing the page. To test: 0) Apply patch 1) Run updatedatabase.pl 2) Add test subscriptions if you have none. Make sure to have subscriptions starting with "The An A" or similar 3) Go to system preferences and edit the SerialSortIgnoreWords pref Add the words "The An A" or the ones you used in your subscriptions 4) Go to Serials 5) Search serials (empty field will return all serials) 6) Result table should be sorted ignoring leading "The An A..." Followed test plan, patch works as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72656|0 |1 is obsolete| | --- Comment #41 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 74263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74263&action=edit Bug 19368 - Correction on QA feedback * I removed the IGNORE in the atomicupdate SQL. There is currently no other systempreference by that name in Master so that should work fine - Removed leftover test values from syspref.sql - Removed extra $ in serial-search.tt - Removed leftover warn in serial-search.pl Passes QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #42 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 74264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74264&action=edit Bug 19368 - Syspref now SortIgnoreArticles, used in datatables.inc Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72658|0 |1 is obsolete| | --- Comment #43 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 74265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74265&action=edit Bug 19368 - Removed the old preference 'SerialSortIgnoreWords' that was left hanging in serials.pref Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72659|0 |1 is obsolete| | --- Comment #44 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 74266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74266&action=edit Bug 19368 - clearly state, in the pref's desc, that the comparison is done against unaccented title Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #45 from Charles Farmer <charles.farmer@inlibro.com> --- New rebase. For some reason, patch couldn't be applied on master and failed with the useful "error: could not build fake ancestor". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72657|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #46 from Nick Clemens <nick@bywatersolutions.com> --- I like this idea, but I think I am confused here. The pref now affects all datatables where we use anti-the, however, we still generate the extra column in serials-search and sort against that initially? This code also seems to automatically strip articles before apostrophes - this works for some languages, but would it work for all? I don't know if the 'anti-the' plugin works with apostrophe'd articles, can you weigh in on that severine or someone else? I find it confusing that the table is initially sorted by one column, then uses another if you click. Adding this to datatables seems to allow sorting by a hidden column: { 'orderData': 2, 'targets': 0}, -- You are receiving this mail because: You are watching all bug changes.
The pref now affects all datatables where we use anti-the, When you say 'all databases using anti-the', can you tell me which one are concernd ? Do you have some ideas it could impact staff client and so where I should test ? I've tried on the /cgi-bin/koha/circ/circulation.pl page for the issues-table :
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #47 from Séverine Queune <severine.queune@bulac.fr> --- Hi Nick ! I'm not sure I understood all your comments, but I've tested once more and here are my feedbacks. (In reply to Nick Clemens from comment #46) articles are ignored even when the syspref is empty.
however, we still generate the extra column in serials-search and sort against that initially? I don't understand that part.
This code also seems to automatically strip articles before apostrophes - this works for some languages, but would it work for all? I don't know if the 'anti-the' plugin works with apostrophe'd articles, can you weigh in on that severine or someone else? I tested with " L' " and " D' ", used very often in french and they are correctly ignore for sorting if I save them on the syspref. Do you have ideas of what of strings / articles / apostrophes use could be a problem ?
I find it confusing that the table is initially sorted by one column, then uses another if you click. Adding this to datatables seems to allow sorting by a hidden column: { 'orderData': 2, 'targets': 0}, I don't understand that part either...
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|david.bourgault@inlibro.com |charles.farmer@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Nadine Pierre <nadine.pierre@InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74262|0 |1 is obsolete| | --- Comment #48 from Nadine Pierre <nadine.pierre@InLibro.com> --- Created attachment 90915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90915&action=edit Bug 19368 - Ignore words when sorting serial search This adds the 'SerialSortIgnoreWords' system preference. It is empty by default, since words to ignore are very much language-specific. The functionality is achieved by adding a hidden column to the table, and sorting by this column by default. The downfall of this solution is that if the user sorts by another column, they cannot go back to this sorting without refreshing the page. To test: 0) Apply patch 1) Run updatedatabase.pl 2) Add test subscriptions if you have none. Make sure to have subscriptions starting with "The An A" or similar 3) Go to system preferences and edit the SerialSortIgnoreWords pref Add the words "The An A" or the ones you used in your subscriptions 4) Go to Serials 5) Search serials (empty field will return all serials) 6) Result table should be sorted ignoring leading "The An A..." Followed test plan, patch works as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Nadine Pierre <nadine.pierre@InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74263|0 |1 is obsolete| | --- Comment #49 from Nadine Pierre <nadine.pierre@InLibro.com> --- Created attachment 90916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90916&action=edit Bug 19368 - Correction on QA feedback * I removed the IGNORE in the atomicupdate SQL. There is currently no other systempreference by that name in Master so that should work fine - Removed leftover test values from syspref.sql - Removed extra $ in serial-search.tt - Removed leftover warn in serial-search.pl Passes QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Nadine Pierre <nadine.pierre@InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74264|0 |1 is obsolete| | --- Comment #50 from Nadine Pierre <nadine.pierre@InLibro.com> --- Created attachment 90918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90918&action=edit Bug 19368 - Syspref now SortIgnoreArticles, used in datatables.inc Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Nadine Pierre <nadine.pierre@InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74265|0 |1 is obsolete| | --- Comment #51 from Nadine Pierre <nadine.pierre@InLibro.com> --- Created attachment 90919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90919&action=edit Bug 19368 - Removed the old preference 'SerialSortIgnoreWords' that was left hanging in serials.pref Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Nadine Pierre <nadine.pierre@InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74266|0 |1 is obsolete| | --- Comment #52 from Nadine Pierre <nadine.pierre@InLibro.com> --- Created attachment 90920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90920&action=edit Bug 19368 - clearly state, in the pref's desc, that the comparison is done against unaccented title Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #53 from Nadine Pierre <nadine.pierre@InLibro.com> --- Created attachment 90921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90921&action=edit Bug 19368 - Added missing closing bracket at the end of serials-search.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Nadine Pierre <nadine.pierre@InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |nadine.pierre@InLibro.com --- Comment #54 from Nadine Pierre <nadine.pierre@InLibro.com> --- Rebased on current master and added missing bracket after resolving conflicts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #55 from Séverine Queune <severine.queune@bulac.fr> --- Sorry Nadine I didn't try sooner, the patch doesn’t apply on more time. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19368 - Ignore words when sorting serial search Using index info to reconstruct a base tree... M installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref M koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref Auto-merging installer/data/mysql/sysprefs.sql Failed to merge in the changes. Patch failed at 0001 Bug 19368 - Ignore words when sorting serial search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90915|0 |1 is obsolete| | --- Comment #56 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 113018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113018&action=edit Bug 19368 - Ignore words when sorting serial search This adds the 'SerialSortIgnoreWords' system preference. It is empty by default, since words to ignore are very much language-specific. The functionality is achieved by adding a hidden column to the table, and sorting by this column by default. The downfall of this solution is that if the user sorts by another column, they cannot go back to this sorting without refreshing the page. To test: 0) Apply patch 1) Run updatedatabase.pl 2) Add test subscriptions if you have none. Make sure to have subscriptions starting with "The An A" or similar 3) Go to system preferences and edit the SerialSortIgnoreWords pref Add the words "The An A" or the ones you used in your subscriptions 4) Go to Serials 5) Search serials (empty field will return all serials) 6) Result table should be sorted ignoring leading "The An A..." Followed test plan, patch works as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90916|0 |1 is obsolete| | --- Comment #57 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 113019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113019&action=edit Bug 19368 - Correction on QA feedback * I removed the IGNORE in the atomicupdate SQL. There is currently no other systempreference by that name in Master so that should work fine - Removed leftover test values from syspref.sql - Removed extra $ in serial-search.tt - Removed leftover warn in serial-search.pl Passes QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90918|0 |1 is obsolete| | --- Comment #58 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 113020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113020&action=edit Bug 19368 - Syspref now SortIgnoreArticles, used in datatables.inc Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90919|0 |1 is obsolete| | --- Comment #59 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 113021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113021&action=edit Bug 19368 - Removed the old preference 'SerialSortIgnoreWords' that was left hanging in serials.pref Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90920|0 |1 is obsolete| | --- Comment #60 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 113022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113022&action=edit Bug 19368 - clearly state, in the pref's desc, that the comparison is done against unaccented title Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90921|0 |1 is obsolete| | --- Comment #61 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 113023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113023&action=edit Bug 19368 - Added missing closing bracket at the end of serials-search.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexis.ripetti@inLibro.com Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #62 from Séverine Queune <severine.queune@bulac.fr> --- Now I test it one more time, I noticed a few things... Unexpected characters like '' can't be ignored (we've got plenty of those in our titles because of some ugly imported datas...) I now most of devs won't agree with me, but I think it could be great if this feature finally doesn't ignore accents. For example, the word 'Thé' in French means tea and if I have a subscription beginning with it ('Thé ou café ?' for instance), I don't want it to be ignored. The same for A and À. I also have a question about sorting a title like 'À l'abordage !' or 'À l'ombre de mon arbre' : if i set the syspref to ignore both à and l' , should the 2 articles be ignored or only the first one ? For now, only the first is ignores. Except these 2 points, this patch is great and works as expected ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #63 from Blou <philippe.blouin@inlibro.com> --- Frankly, the accent part is arguable. The main reason it's like that is because comparing accents is a nightmare. They look the same, they sound the same, they ARE the same, except they are coded differently (UTF8 and friends) so the comparison fails and the patch is mosly useless in French and other accentuated languages. As for the last question, there's (again) no perfect answer. Right now it'd skip the À and keep the L'. This is one of those patches that we'd like to go through because it offers an improvement on the current code for most users (and usages) in its current form. Trying to solve the details will put it in In Discussion purgatory. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113018|0 |1 is obsolete| | --- Comment #64 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 113344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113344&action=edit Bug 19368 - Ignore words when sorting serial search This adds the 'SerialSortIgnoreWords' system preference. It is empty by default, since words to ignore are very much language-specific. The functionality is achieved by adding a hidden column to the table, and sorting by this column by default. The downfall of this solution is that if the user sorts by another column, they cannot go back to this sorting without refreshing the page. To test: 0) Apply patch 1) Run updatedatabase.pl 2) Add test subscriptions if you have none. Make sure to have subscriptions starting with "The An A" or similar 3) Go to system preferences and edit the SerialSortIgnoreWords pref Add the words "The An A" or the ones you used in your subscriptions 4) Go to Serials 5) Search serials (empty field will return all serials) 6) Result table should be sorted ignoring leading "The An A..." Followed test plan, patch works as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113019|0 |1 is obsolete| | --- Comment #65 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 113345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113345&action=edit Bug 19368 - Correction on QA feedback * I removed the IGNORE in the atomicupdate SQL. There is currently no other systempreference by that name in Master so that should work fine - Removed leftover test values from syspref.sql - Removed extra $ in serial-search.tt - Removed leftover warn in serial-search.pl Passes QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113020|0 |1 is obsolete| | --- Comment #66 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 113346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113346&action=edit Bug 19368 - Syspref now SortIgnoreArticles, used in datatables.inc Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113021|0 |1 is obsolete| | --- Comment #67 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 113347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113347&action=edit Bug 19368 - Removed the old preference 'SerialSortIgnoreWords' that was left hanging in serials.pref Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113022|0 |1 is obsolete| | --- Comment #68 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 113348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113348&action=edit Bug 19368 - clearly state, in the pref's desc, that the comparison is done against unaccented title Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113023|0 |1 is obsolete| | --- Comment #69 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 113349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113349&action=edit Bug 19368 - Added missing closing bracket at the end of serials-search.pl Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #70 from Séverine Queune <severine.queune@bulac.fr> --- I completely understand, I expected this kind of answer. Just pointing some complementary points. This patch behaves as it's expected and the information about accent is present in the syspref, so I don't see now reasons for not signing it :) A last detail : syspref is now named 'SortIgnoreArticles' and not 'SerialSortIgnoreWords' as in the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy@rijksmuseum.nl --- Comment #71 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Applying: Bug 19368 - Syspref now SortIgnoreArticles, used in datatables.inc error: sha1 information is lacking or useless (installer/data/mysql/mandatory/sysprefs.sql). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113344|0 |1 is obsolete| | --- Comment #72 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 118963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118963&action=edit Bug 19368 - Ignore words when sorting serial search This adds the 'SerialSortIgnoreWords' system preference. It is empty by default, since words to ignore are very much language-specific. The functionality is achieved by adding a hidden column to the table, and sorting by this column by default. The downfall of this solution is that if the user sorts by another column, they cannot go back to this sorting without refreshing the page. To test: 0) Apply patch 1) Run updatedatabase.pl 2) Add test subscriptions if you have none. Make sure to have subscriptions starting with "The An A" or similar 3) Go to system preferences and edit the SerialSortIgnoreWords pref Add the words "The An A" or the ones you used in your subscriptions 4) Go to Serials 5) Search serials (empty field will return all serials) 6) Result table should be sorted ignoring leading "The An A..." Followed test plan, patch works as described -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113345|0 |1 is obsolete| | --- Comment #73 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 118964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118964&action=edit Bug 19368 - Correction on QA feedback * I removed the IGNORE in the atomicupdate SQL. There is currently no other systempreference by that name in Master so that should work fine - Removed leftover test values from syspref.sql - Removed extra $ in serial-search.tt - Removed leftover warn in serial-search.pl Passes QA test tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113346|0 |1 is obsolete| | --- Comment #74 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 118965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118965&action=edit Bug 19368 - Syspref now SortIgnoreArticles, used in datatables.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113347|0 |1 is obsolete| | --- Comment #75 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 118966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118966&action=edit Bug 19368 - Removed the old preference 'SerialSortIgnoreWords' that was left hanging in serials.pref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113348|0 |1 is obsolete| | --- Comment #76 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 118967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118967&action=edit Bug 19368 - clearly state, in the pref's desc, that the comparison is done against unaccented title -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113349|0 |1 is obsolete| | --- Comment #77 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 118968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118968&action=edit Bug 19368 - Added missing closing bracket at the end of serials-search.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #78 from Owen Leonard <oleonard@myacpl.org> --- - Are the changes to datatables.inc necessary? I think this has made the one change you want (CONFIG_EXCLUDE_ARTICLES_FROM_SORT) obsolete: https://git.koha-community.org/Koha-community/Koha/commit/0c9b39a66dff00d2d7... - Shouldn't the preference description omit the reference to serial search results since the its use is theoretically general? - Is it necessary to replace [% INCLUDE subscriptions_table %] in serials-search.tt? Going back to all that markup after switching to an include seems like a step backwards. - Don't forget to run the QA tool to check for other issues after making corrections. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118963|0 |1 is obsolete| | --- Comment #79 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 124090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124090&action=edit Bug 19368 - Ignore words when sorting serial search This adds the 'SerialSortIgnoreWords' system preference. It is empty by default, since words to ignore are very much language-specific. The functionality is achieved by adding a hidden column to the table, and sorting by this column by default. The downfall of this solution is that if the user sorts by another column, they cannot go back to this sorting without refreshing the page. To test: 0) Apply patch 1) Run updatedatabase.pl 2) Add test subscriptions if you have none. Make sure to have subscriptions starting with "The An A" or similar 3) Go to system preferences and edit the SortIgnoreArticles pref Add the words "The An A" or the ones you used in your subscriptions 4) Go to Serials 5) Search serials (empty field will return all serials) 6) Result table should be sorted ignoring leading "The An A..." Followed test plan, patch works as described -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118964|0 |1 is obsolete| | --- Comment #80 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 124091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124091&action=edit Bug 19368 - Correction on QA feedback * I removed the IGNORE in the atomicupdate SQL. There is currently no other systempreference by that name in Master so that should work fine - Removed leftover test values from syspref.sql - Removed extra $ in serial-search.tt - Removed leftover warn in serial-search.pl Passes QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118965|0 |1 is obsolete| | --- Comment #81 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 124092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124092&action=edit Bug 19368 - Syspref now SortIgnoreArticles, used in datatables.inc Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118966|0 |1 is obsolete| | --- Comment #82 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 124093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124093&action=edit Bug 19368 - Removed the old preference 'SerialSortIgnoreWords' that was left hanging in serials.pref Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118967|0 |1 is obsolete| | --- Comment #83 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 124094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124094&action=edit Bug 19368 - clearly state, in the pref's desc, that the comparison is done against unaccented title Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118968|0 |1 is obsolete| | --- Comment #84 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 124095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124095&action=edit Bug 19368 - Added missing closing bracket at the end of serials-search.pl Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #85 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 124096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124096&action=edit Bug 19368 - (QA follow-up) Correction on QA feedback -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #86 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 124097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124097&action=edit Bug 19368 - Deleting useless variables in datatables.inc I tried to understand where it was used but I finally came to the conclusion that this is useless. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #87 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- (In reply to Owen Leonard from comment #78)
- Are the changes to datatables.inc necessary? I think this has made the one change you want (CONFIG_EXCLUDE_ARTICLES_FROM_SORT) obsolete: https://git.koha-community.org/Koha-community/Koha/commit/ 0c9b39a66dff00d2d76effc42824c2051484f9c5
- Shouldn't the preference description omit the reference to serial search results since the its use is theoretically general?
- Is it necessary to replace [% INCLUDE subscriptions_table %] in serials-search.tt? Going back to all that markup after switching to an include seems like a step backwards.
- Don't forget to run the QA tool to check for other issues after making corrections.
No they are not necessary. They have been removed. We are only using this patch on the serials search. So for now this description is good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #88 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Alexis, did you run the QA script on those patches? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124090|0 |1 is obsolete| | --- Comment #89 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 124104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124104&action=edit Bug 19368 - Ignore words when sorting serial search This adds the 'SerialSortIgnoreWords' system preference. It is empty by default, since words to ignore are very much language-specific. The functionality is achieved by adding a hidden column to the table, and sorting by this column by default. The downfall of this solution is that if the user sorts by another column, they cannot go back to this sorting without refreshing the page. To test: 0) Apply patch 1) Run updatedatabase.pl 2) Add test subscriptions if you have none. Make sure to have subscriptions starting with "The An A" or similar 3) Go to system preferences and edit the SerialSortIgnoreWords pref Add the words "The An A" or the ones you used in your subscriptions 4) Go to Serials 5) Search serials (empty field will return all serials) 6) Result table should be sorted ignoring leading "The An A..." Followed test plan, patch works as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124091|0 |1 is obsolete| | --- Comment #90 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 124105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124105&action=edit Bug 19368 - Correction on QA feedback * I removed the IGNORE in the atomicupdate SQL. There is currently no other systempreference by that name in Master so that should work fine - Removed leftover test values from syspref.sql - Removed extra $ in serial-search.tt - Removed leftover warn in serial-search.pl Passes QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124092|0 |1 is obsolete| | --- Comment #91 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 124106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124106&action=edit Bug 19368 - Syspref now SortIgnoreArticles, used in datatables.inc Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124093|0 |1 is obsolete| | --- Comment #92 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 124107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124107&action=edit Bug 19368 - Removed the old preference 'SerialSortIgnoreWords' that was left hanging in serials.pref Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124094|0 |1 is obsolete| | --- Comment #93 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 124108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124108&action=edit Bug 19368 - clearly state, in the pref's desc, that the comparison is done against unaccented title Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124095|0 |1 is obsolete| | --- Comment #94 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 124109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124109&action=edit Bug 19368 - Added missing closing bracket at the end of serials-search.pl Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124096|0 |1 is obsolete| | --- Comment #95 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 124110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124110&action=edit Bug 19368 - (QA follow-up) Correction on QA feedback -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124097|0 |1 is obsolete| | --- Comment #96 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 124111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124111&action=edit Bug 19368 - Deleting useless variables in datatables.inc I tried to understand where it was used but I finally came to the conclusion that this is useless. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #97 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- (In reply to Jonathan Druart from comment #88)
Alexis, did you run the QA script on those patches?
Yes I did. I missed one. I just fixed it. But the other one is just a git manipulation error and I don't know how to fix it. There are some spelling errors too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #98 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- You need to amend the commits and fix their title: % git rebase -i HEAD~X (with X the number of commit) Replace "pick" with "r" (reword), save. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #99 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The way this enhancement is implemented sounds weird to me. Why are you using perl when it can be done using Datatables (client-side)? Having the ability to define a list of word to ignore is great, but it can be done (at first glance) easily by extending the 'anti-the' plugin (and it will apply to *all* tables of Koha). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Assignee|charles.farmer@inlibro.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|alexis.ripetti@inLibro.com, | |charles.farmer@inlibro.com, | |francois.charbonnier@inlibr | |o.com, | |nadine.pierre@InLibro.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org