[Bug 21978] New: Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Bug ID: 21978 Summary: Add middle name field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com We would like there to be a middle name field. We don't want middle names shown in all cases, but would like it for authentication. Currently we add the middle name to the first name field. This is not ideal. Other names is used for nicknames and such, and not ideal for middle names. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- I cannot stress enough the importance of this field. I'm not sure why there is a hold back on this. I RARELY see a database that doesn't include a field for a middle name. Yes, I can probably hack something together with attributes, but this is information that really needs to be in the patron record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #2 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- +1. I agree - this would be very useful for librarians. The current set up leads to lots of confusion. Most staff lean to adding as much information as possible, especially with names which are common: e.g. First name: John Last name: Smith Becomes: First name: John David Last name: Smith But the addition of the middle name into the first name field means that the patron match feature doesn't work in all scenarios, because Koha (understandably) thinks that John David is a very different name to John. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- In German we don't have the same concept of a middle name than in the US I think. I've kind of thought that you'd end up using the initials field for the second name that seems common. Would you mind explaining how this usually works? We've had a request for the 'father's name' as used in Russian (we support some libraries located in Ukraine and Russia) and they have been quite happy with using one of the existing fields we relabelled (not sure if it was alias or initials) I think requirements are quite different between countries, I'd like to learn more about it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #4 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Hi Katrin, Ah yes, sorry, I can imagine that the differences between countries are quite pronounced - I think Christopher is in the US, but I'm in the UK. It's much more common here to have a middle name than not - there's a bit on Wikipedia about it, which refers to the UK and the US: https://en.wikipedia.org/wiki/Middle_name Koha has a comprehensive 'borrowersunwantedfield' system preference, so it would be great if we could offer this functionality because for those geographic areas where it's not relevant, it could be easily disabled. The issues with using Initials / Other Name: 1) Initials and Other Name are located at the foot of Patron Identity when joining a patron - this is not logical for a middle name, it should be Surname / First Name / Middle Name or First Name / Middle Name / Surname. The Patron Identity fields aren't trivial to move around with jquery (I think, please correct me if I'm wrong - I'm fairly new to jquery and happy to learn more). 2) If using Initials, the patron's middle name is never formatted within the patron's name on the checkout or details pages - it looks bizarre to UK eyes to have Mr John Smith on the details screen, and then the middle name below the patron's phone numbers; all of the names should be grouped together. 3) If using Other Name, the patron's middle name is bracketed - e.g. John (David) Smith, or quoted: Mr John Smith (card number) "David" - again, this looks really strange to UK eyes, because quotes and brackets imply that the name is fake or optional. This makes sense because that field is designed to be for a nickname that the patron prefers to be called - but it doesn't work for middle names at all. It's hard to explain, but I guess I would say that when it comes to identity, your middle name is a key part of your name - just as much as your first name or surname is. It would be great if: - Koha accepted middle names in a properly designed field - The middle name input field was located next to first name / surname on the patron identity screen - The content of the middle name field is displayed in context - e.g. on the details screen, instead of Title / First Name / Surname, it should be Title / First Name / Middle Name / Surname - Mr John David Smith. - It should be possible for the field to be entered into the borrowersunwantedfield system preference so other regions can switch the feature off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Sally, thanks for your answer, that's super helpful! I actually have multiple surnames too, but it's not so common here to use all of them. For me they only show up on my passport and when trying to enter them for a flight booking (because they insist it should match the passport and then complain when they are too long to fit :) ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #6 from Christopher Brannon <cbrannon@cdalibrary.org> --- Sally, thanks for the input. This helps. I've played around with othername and initials, and neither appear in search results or suggestions, although you can include them for searching. This makes distinguishing one patron from the other difficult when this information doesn't show. And Sally is right...the brackets around the othername doesn't make sense if it is a middle name. Middle names are used in the US for more formal identification (and some people have multiple middle names), but not commonly used in greetings or business letters. So, to have a middle name field that is searchable, and shows in searches, and properly laid out, but something that can be excluded in communications and notices, and on screen greetings would be preferred. Currently we are using othernames for nicknames, like if Mary Jo prefers to be called MJ. So, we can't really use that. And initials are not as visible as othernames. We can always adjust things like that, but as stated above, they are not visible in searches. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Mark Foster <markf@communitylibrary.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |markf@communitylibrary.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #7 from Mark Foster <markf@communitylibrary.net> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com --- Comment #8 from Lisette Scheer <lisetteslatah@gmail.com> --- +1 Especially in a consortium, it is part of how we indicate that this patron is not the same John Smith as the John Smith that lives in one of the other parts of our consortium. We sometimes get complaints from patrons that their notices say "Dear John David" instead of just "Dear John". I agree that having it be next to the first name field would be great and that is should be hidable for libraries that don't want/need it. Having it searchable would also be key. Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Holly <hc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc@interleaf.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26146 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #9 from Christopher Brannon <cbrannon@cdalibrary.org> --- I have managed to work around the short comings of the initials field not showing in the search results, but I have to use a report to fix each result in the results table. I imagine this is taxing on the server, as each time you do a vague patron search, and you end up with 10 possible patrons, for example, the jquery has to run 10 reports to grab the patron info needed. It doesn't seem to be too slow, but I don't like having to do this for something that is commonplace for the US. What if we could just get away from the name structures, and have 5 or 6 generic name fields (i.e. Name1, Name2, Name3 etc.), and we can label them in the editor for whatever purpose we need, and on screens they appear in the order that they are used. For example, Name1 is used as Surname, Name2 is First Name, Name3 is Middle Name, and so on. Sort will always sort in order of the fields (Name1 first, Name2 next, and so on), and would display similar to how they appear now: In results: Name1, Name2 [Name3] [Name4] [Name5] [Name6] On patron account: Name2 [Name3] [Name4] [Name5] [Name6] Name1 I suggest keeping othernames, initials, title, and such as is. Thoughts? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #10 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Christopher Brannon from comment #9)
I have managed to work around the short comings of the initials field not showing in the search results, but I have to use a report to fix each result in the results table. I imagine this is taxing on the server, as each time you do a vague patron search, and you end up with 10 possible patrons, for example, the jquery has to run 10 reports to grab the patron info needed. It doesn't seem to be too slow, but I don't like having to do this for something that is commonplace for the US.
I retract this statement. My workaround is horrible. There are latent issue with using the report. Changes made to the name take forever to refresh. The name is just to much a part of things to work around with via jQuery. This is best fixed by an enhancement. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #11 from Rebecca Coert <rcoert@arlingtonva.us> --- +1 I agree with the group that this would be an extremely useful field to have in Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #12 from Christopher Brannon <cbrannon@cdalibrary.org> --- Could someone just simply start off by adding a middle name field in the borrower tables, and putting the field on the patron edit page??? That would be a start. Please, lets get this ball rolling at least! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Mark Rogers <marcos.rogers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marcos.rogers@gmail.com --- Comment #13 from Mark Rogers <marcos.rogers@gmail.com> --- +1 Having a middle name field would be very useful. I work with a school in Bogotá, Colombia, where most Colombian students and staff also have a second surname (family name), which is treated much like middle (given) names are treated in the US and UK, namely, that they aren't usually used except for legal and disambiguation purposes. Having both "middle name" and "subsequent surnames" fields would be helpful. So in the case of someone named José Manuel Pérez Rodríguez, that would be First name: José Middle name: Manuel Surname ("last name"): Pérez Subsequent surnames: Rodríguez In general usage, the above person would just be called "José Pérez" while official documentation would have his name as "José Manuel Pérez Rodríguez" or "Pérez Rodríguez, José Manuel". Portuguese names also tend to have multiple surnames, but work opposite Spanish surnames, from what I understand, i.e. that the last surname is typically used in the shortened version of their name. Perhaps a solution like Christopher Brannon's for generic name fields would be best. In order to accommodate different naming conventions, perhaps a configuration field or two could also be added to allow for defining: - A "display name" (patron account), e.g. "name1 name3" (English-speaking and Spanish-speaking) "name1 name4" (Portuguese-speaking) "name3 name1" (Korea/China/Japan) - A "sort name" (in results), e.g. "name 3 [name4], name1 [name2]" (Spanish-speaking countries) "name3, name 1 [name2]" (English-speaking) "name 3 name1" (Korea/China/Japan) If we wanted even further configuration, we could even allow for multiple formats to be added as authorized values, with the possibility of setting a default value for the database, with the option to choose a different "display name" or "full name" for individual patrons. But perhaps this is too much customization. At the very least, having a middle name field and a subsequent surnames field would be very helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #14 from Christopher Brannon <cbrannon@cdalibrary.org> --- Mark, Thank you for your input. This is very valuable and helpful. I know our situation is unique to the US, and we do have some patrons with more than three names. I think anything we can do to make the names more definable and purposeful without lumping a bunch of them in a single field would be a tremendous help and improvement. The information you gave will help us come together on a good solution. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #15 from David Cook <dcook@prosentient.com.au> --- (In reply to Christopher Brannon from comment #14)
I know our situation is unique to the US, and we do have some patrons with more than three names.
It's not really unique to the US. It's common to "English" countries like the US, Canada, Australia, New Zealand, and the UK. That said, I don't often see fields in Australia for middle name. Typically I see either "First name" and "Last name", or "Given names" and "Last name". Occasionally I'll see a field for middle name. I actually have found previously that giving my middle name in situations has led to data errors. For some reason I end up being referred to by my middle name instead of my first name (both in Canada and Australia), so I try to omit it wherever possible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28633 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #16 from Christopher Brannon <cbrannon@cdalibrary.org> --- It seems like we've generated a lot of discussion on this. Would sure love it if this could get off the ground. Are there any developers who would be interested in giving a bid for this development? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think we need a clear specification before we can attempt this. It sounds simple of course.. just add a 'middle name' field.. but I'm already seeing a few questions to raise: 1. How do you want this to display in the various places in Koha. (i.e should we always combine these fields and in what order) 2. What features do you want this new field to work with (I already see requests for the patron matching) 3. Should this field be included in the default search fields? 4. How does this field compare to the existing 'othernames' and new 'preferred_name' fields (bug 28633) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #18 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Martin Renvoize from comment #17)
1. How do you want this to display in the various places in Koha. (i.e should we always combine these fields and in what order) 2. What features do you want this new field to work with (I already see requests for the patron matching) 3. Should this field be included in the default search fields? 4. How does this field compare to the existing 'othernames' and new 'preferred_name' fields (bug 28633)
1. I think maybe a new field like additional_names could be added, and it could include any other names that should be included that are not firstname or surname, and isn't a othername. 2-3. It should have the option of being included in patron searches. If so, these names should be included in any list that returns multiple results on patrons in a list, for easy identification, and should be on patron pages. 4. Othernames does not show on patron search results when you see multiple results. This is okay. I don't know what other countries use this for, but at least our libraries use this field for nicknames. The big difference is that this field is displayed, and othernames is not, on search results. Othernames also appears somewhat separately from the main name on the patron pages. This one would show with the other primary names as defined in #5 below. preferred_name sounds like what WE currently use othernames for, but better. Since that is becoming a new feature, we could enhance othernames for this purpose, but I wouldn't want to take away what people currently use othernames for, if not for nicknames (preferred_name). Plus, applying these options to othernames would only allow you to use it one way or the other. I think a new field (additional_names) would be best. 5. (new) Where ever this name shows, there should be a place to define the order the names show. Should it be after the firstname when displayed? After the surname? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133431&action=edit Bug 21978: Add middle_name field to the database This patch adds a new field, middle_name, to the borrowers, deletedborrowers and borrower_modifications tables. It also updates the DefaultPatronSearchFields preference to include the new field if the preference is still set to it's default settings from install. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133432&action=edit Bug 21978: Add middle_name to api specification This patch adds middle_name to the accaeptable fields in API requests and responses. Test plan 1) Search for a user using the API 2) Confirm the API responds with a 200 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133433&action=edit Bug 21978: Add support for middle name This patch adds the new 'Middle name' field to the patron record. To test: 1) Apply patches 2) Update database, restart all and clear the browser cache 3) Load a patron in the staff module 4) Confirm you can see and edit the new 'Middle name' field 5) Confirm the new middle name data displays on patron details 6) Confirm the new middle name data displays on patron search results 7) Confirm the new middle name data displays everywhere patron names are displayed. 8) Confirm the new middle name data displays on the OPAC 9) Confirm the 'Middle name' field appears in the OPAC borrower modification screens 10) Edit syspref BorrowerMandatoryFields and BorrowerUnwantedFields to confirm you can make the new field required or hidden 11) Verify that DefaultPatronSearchFields contains the new field if you already had 'firstname' in the field list 12) Enable PatronAutoComplete system preference 13) Type patrons surname into checkout or patron search but don't hit return 14) Confirm the patrons middle name is displayed in the preview -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133434&action=edit Bug 21978: Schema Update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133431|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133435&action=edit Bug 21978: Add middle_name field to the database This patch adds a new field, middle_name, to the borrowers, deletedborrowers and borrower_modifications tables. It also updates the DefaultPatronSearchFields preference to include the new field if the preference is still set to it's default settings from install. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133432|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133436&action=edit Bug 21978: Add middle_name to api specification This patch adds middle_name to the accaeptable fields in API requests and responses. Test plan 1) Search for a user using the API 2) Confirm the API responds with a 200 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133433|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133437&action=edit Bug 21978: Add support for middle name This patch adds the new 'Middle name' field to the patron record. To test: 1) Apply patches 2) Update database, restart all and clear the browser cache 3) Load a patron in the staff module 4) Confirm you can see and edit the new 'Middle name' field 5) Confirm the new middle name data displays on patron details 6) Confirm the new middle name data displays on patron search results 7) Confirm the new middle name data displays everywhere patron names are displayed. 8) Confirm the new middle name data displays on the OPAC 9) Confirm the 'Middle name' field appears in the OPAC borrower modification screens 10) Edit syspref BorrowerMandatoryFields and BorrowerUnwantedFields to confirm you can make the new field required or hidden 11) Verify that DefaultPatronSearchFields contains the new field if you already had 'firstname' in the field list 12) Enable PatronAutoComplete system preference 13) Type patrons surname into checkout or patron search but don't hit return 14) Confirm the patrons middle name is displayed in the preview -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133434|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133438&action=edit Bug 21978: Schema Update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've stuck to the basics here to get the ball rolling and I want to open a new bug for allowing for more fine-grained control over display and search ordering and things... there's some great idea's above around that so I'll copy those in to the new bug too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30568 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #28 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Sorry, Martin - patch doesn't apply with the following message: Applying: Bug 21978: Add support for middle name .git/rebase-apply/patch:75: trailing whitespace. .git/rebase-apply/patch:155: trailing whitespace. [%- ELSE %] warning: 2 lines add whitespace errors. Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc M koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt M koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt .git/rebase-apply/patch:75: trailing whitespace. .git/rebase-apply/patch:155: trailing whitespace. [%- ELSE %] warning: 2 lines applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 21978: Add support for middle name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133435|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133453&action=edit Bug 21978: Add middle_name field to the database This patch adds a new field, middle_name, to the borrowers, deletedborrowers and borrower_modifications tables. It also updates the DefaultPatronSearchFields preference to include the new field if the preference is still set to it's default settings from install. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133436|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133454&action=edit Bug 21978: Add middle_name to api specification This patch adds middle_name to the accaeptable fields in API requests and responses. Test plan 1) Search for a user using the API 2) Confirm the API responds with a 200 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133437|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133455&action=edit Bug 21978: Add support for middle name This patch adds the new 'Middle name' field to the patron record. To test: 1) Apply patches 2) Update database, restart all and clear the browser cache 3) Load a patron in the staff module 4) Confirm you can see and edit the new 'Middle name' field 5) Confirm the new middle name data displays on patron details 6) Confirm the new middle name data displays on patron search results 7) Confirm the new middle name data displays everywhere patron names are displayed. 8) Confirm the new middle name data displays on the OPAC 9) Confirm the 'Middle name' field appears in the OPAC borrower modification screens 10) Edit syspref BorrowerMandatoryFields and BorrowerUnwantedFields to confirm you can make the new field required or hidden 11) Verify that DefaultPatronSearchFields contains the new field if you already had 'firstname' in the field list 12) Enable PatronAutoComplete system preference 13) Type patrons surname into checkout or patron search but don't hit return 14) Confirm the patrons middle name is displayed in the preview -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133438|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133456&action=edit Bug 21978: Schema Update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Ooop.. master moved.. rebased for you Sally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #34 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Great, thanks Martin! It seems as though the patch changes the default patron search from the standard fields to surname only. To replicate: 1) Add two patrons called Henry - e.g. Henry Jones and Henry Smith 2) On the homepage, set the search to 'check out' and search for Henry Results: i) Note that at least two patrons are returned ii) Note that in the 'Search for patron' box on the left, the Search field is listed as 'Standard' iii) Note that the search text says: Patrons found for: Standard containing 'henry' Add the patch and repeat step 2. i) Note that the search brings back no results ii) Note that in the 'Search for patron' box on the left, the Search field is listed as 'Surname' iii) Note that the search text says: Patrons found for: Surname containing 'henry' iv) Note that if you attempt to change the Search field in the 'Search for patron' box, Standard is not available as an option. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133453|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133534&action=edit Bug 21978: Add middle_name field to the database This patch adds a new field, middle_name, to the borrowers, deletedborrowers and borrower_modifications tables. It also updates the DefaultPatronSearchFields preference to include the new field if the preference is still set to it's default settings from install. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133454|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133535&action=edit Bug 21978: Add middle_name to api specification This patch adds middle_name to the accaeptable fields in API requests and responses. Test plan 1) Search for a user using the API 2) Confirm the API responds with a 200 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133455|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133536&action=edit Bug 21978: Add support for middle name This patch adds the new 'Middle name' field to the patron record. To test: 1) Apply patches 2) Update database, restart all and clear the browser cache 3) Load a patron in the staff module 4) Confirm you can see and edit the new 'Middle name' field 5) Confirm the new middle name data displays on patron details 6) Confirm the new middle name data displays on patron search results 7) Confirm the new middle name data displays everywhere patron names are displayed. 8) Confirm the new middle name data displays on the OPAC 9) Confirm the 'Middle name' field appears in the OPAC borrower modification screens 10) Edit syspref BorrowerMandatoryFields and BorrowerUnwantedFields to confirm you can make the new field required or hidden 11) Verify that DefaultPatronSearchFields contains the new field if you already had 'firstname' in the field list 12) Enable PatronAutoComplete system preference 13) Type patrons surname into checkout or patron search but don't hit return 14) Confirm the patrons middle name is displayed in the preview 15) Go to tools > patron lists and attempt to add a patron to a list 16) Patrons middle name should appear in the autocomplete here too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133456|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133537&action=edit Bug 21978: Schema Update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch Sally, I think I've resolved that here now, but it has lead me to submit a new bug 'Bug 30576 - DefaultPatronSearchFields no longer takes effect' as I think the core feature has broken in the recent patron search changes push. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30576 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576 [Bug 30576] DefaultPatronSearchFields no longer takes effect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133534|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133544&action=edit Bug 21978: Add middle_name field to the database This patch adds a new field, middle_name, to the borrowers, deletedborrowers and borrower_modifications tables. It also updates the DefaultPatronSearchFields preference to include the new field if the preference is still set to it's default settings from install. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133535|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133545&action=edit Bug 21978: Add middle_name to api specification This patch adds middle_name to the accaeptable fields in API requests and responses. Test plan 1) Search for a user using the API 2) Confirm the API responds with a 200 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133536|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133546&action=edit Bug 21978: Add support for middle name This patch adds the new 'Middle name' field to the patron record. To test: 1) Apply patches 2) Update database, restart all and clear the browser cache 3) Load a patron in the staff module 4) Confirm you can see and edit the new 'Middle name' field 5) Confirm the new middle name data displays on patron details 6) Confirm the new middle name data displays on patron search results 7) Confirm the new middle name data displays everywhere patron names are displayed. 8) Confirm the new middle name data displays on the OPAC 9) Confirm the 'Middle name' field appears in the OPAC borrower modification screens 10) Edit syspref BorrowerMandatoryFields and BorrowerUnwantedFields to confirm you can make the new field required or hidden 11) Verify that DefaultPatronSearchFields contains the new field if you already had 'firstname' in the field list 12) Enable PatronAutoComplete system preference 13) Type patrons surname into checkout or patron search but don't hit return 14) Confirm the patrons middle name is displayed in the preview 15) Go to tools > patron lists and attempt to add a patron to a list 16) Patrons middle name should appear in the autocomplete here too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133537|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133547&action=edit Bug 21978: Schema Update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Added 30576 as a dependency here and rebased appropriately. That should fix the DefaultPatronSearchFields preference handling. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm reconsidering whether this should be hard coded to be included in the autocomplete searches. Those searches only allow for ten results at a time and adding another field into the mix could actually reduce their relevance.. How often is a staff user going to start typing a middle name in preference to a firstname, surname or cardnumber? We can still display the middle name in the results to allow easily picking between them, but actually searching on middle name seems like an odd practice..? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #46 from Christopher Brannon <cbrannon@cdalibrary.org> --- Some of these were in your test plan and didn't show. Others were not and need to be considered. * Middle name does not show when typing name to search for patron when placing hold (request.pl) * Middle name does not show in dialog at top of hold form (request.pl) * Middle name does not show in patron details at top of hold form (request.pl) * Middle name field does not show in opac-memberentry.pl * Middle name is not an option on SelfModificationBorrowerUnwantedField in preferences.pl * Middle name is not an option on PatronSelfModificationMandatoryField in preferences.pl * Middle name is not an option on PatronSelfRegistrationBorrowerMandatoryField in preferences.pl * Middle name is not an option on PatronSelfRegistrationBorrowerUnwantedField in preferences.pl * Middle name is not an option on BorrowerUnwantedField in preferences.pl * Middle name is not an option on BorrowerMandatoryField in preferences.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #47 from Christopher Brannon <cbrannon@cdalibrary.org> --- Otherwise, everything else looked great. Searching was not a problem. Just a few missed areas, and the controls are just not all there for mandatory or unwanted preferences. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133751&action=edit Bug 30576: Use DefaultPatronSearchFields in patron search This patch corrects the handling of the 'Standard' search field in patron searches such that it accurately reflects the contents of the DefaultPatronSearchFields system preference and falls back to a hard coded list instead of always using the hard coded list. To test: 1) Empty the contents of DefaultPatronSearchFields systempreference 2) Perform a patron search from the header search 3) Inspect the patrons API request and note that we search on the default fallback fields of firstname, surname, othernames, cardnumber and userid (and some extended attributes which are historically hard coded). 4) Navigate to the memebers-home by clicking the 'Patrons' button from the main page 5) Perform another search using the filters on the left with 'Standard' selected. 6) Note the same list of search fields used as above in the patrons API request. 7) Update the DefaultPatronSearchFields systempreference adding one or more borrower fields in a comma delimited list. 8) Repeat steps 2 -> 6 but this time upon inspecting the API request you should find that only the fields in your DefaultPatronSearchFields list are searched (along with the hard coded extended attributes list). 9) Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133544|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133752&action=edit Bug 21978: Add middle_name field to the database This patch adds a new field, middle_name, to the borrowers, deletedborrowers and borrower_modifications tables. It also updates the DefaultPatronSearchFields preference to include the new field if the preference is still set to it's default settings from install. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133545|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133753&action=edit Bug 21978: Add middle_name to api specification This patch adds middle_name to the accaeptable fields in API requests and responses. Test plan 1) Search for a user using the API 2) Confirm the API responds with a 200 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133546|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133754&action=edit Bug 21978: Add support for middle name This patch adds the new 'Middle name' field to the patron record. To test: 1) Apply patches 2) Update database, restart all and clear the browser cache 3) Load a patron in the staff module 4) Confirm you can see and edit the new 'Middle name' field 5) Confirm the new middle name data displays on patron details 6) Confirm the new middle name data displays on patron search results 7) Confirm the new middle name data displays everywhere patron names are displayed. 8) Confirm the new middle name data displays on the OPAC 9) Confirm the 'Middle name' field appears in the OPAC borrower modification screens 10) Edit sysprefs `BorrowerMandatoryFields`, `BorrowerUnwantedFields`, `SelfModificationBorrowerUnwantedField`, `PatronSelfModificationMandatoryField`, `PatronSelfRegistrationBorrowerMandatoryField` and `PatronSelfRegistrationBorrowerUnwantedField` to confirm you can make the new field required or hidden. 11) Verify that DefaultPatronSearchFields contains the new field if you already had 'firstname' in the field list 12) Enable PatronAutoComplete system preference 13) Type patrons surname into checkout or patron search but don't hit return 14) Confirm the patrons middle name is displayed in the preview 15) Go to tools > patron lists and attempt to add a patron to a list 16) Patrons middle name should appear in the autocomplete here too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133547|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133755&action=edit Bug 21978: Schema Update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133756&action=edit Bug 21978: Add middle_name into hold request autocomplete -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133757&action=edit Bug 21978: Use patron-title.inc in request.tt This patch updates all manual accurences of the patron title display to use the patron-title.inc include (so we get middlename handling) in request.tt. We also add the option to hide the cardnumber from the include and set the link_to to 'members_pay' to retain the current display format on this page. Test plan You'll need to trigger the following cases to test all cases: 1) Too many holds 2) Account expired 3) Has restrictions 4) Outstanding fines 5) Already has hold on item 6) No holds allowed 7) Too many holds for this record 8) Already in possession 9) Already has a hold 10) Already has a recall 11) Pickup library doesn't many patron home library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133751|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the thorough testing.. I think those issues should now all be resolved now :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30617 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617 [Bug 30617] We should consistently use includes for patron name display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Not to self, add in 'Sponsored-by: Cheshire Libraries' line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133752|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134254&action=edit Bug 21978: Add middle_name field to the database This patch adds a new field, middle_name, to the borrowers, deletedborrowers and borrower_modifications tables. It also updates the DefaultPatronSearchFields preference to include the new field if the preference is still set to it's default settings from install. Sponsored-by: Cheshire Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133753|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134255&action=edit Bug 21978: Add middle_name to api specification This patch adds middle_name to the accaeptable fields in API requests and responses. Test plan 1) Search for a user using the API 2) Confirm the API responds with a 200 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133754|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134256&action=edit Bug 21978: Add support for middle name This patch adds the new 'Middle name' field to the patron record. To test: 1) Apply patches 2) Update database, restart all and clear the browser cache 3) Load a patron in the staff module 4) Confirm you can see and edit the new 'Middle name' field 5) Confirm the new middle name data displays on patron details 6) Confirm the new middle name data displays on patron search results 7) Confirm the new middle name data displays everywhere patron names are displayed. 8) Confirm the new middle name data displays on the OPAC 9) Confirm the 'Middle name' field appears in the OPAC borrower modification screens 10) Edit sysprefs `BorrowerMandatoryFields`, `BorrowerUnwantedFields`, `SelfModificationBorrowerUnwantedField`, `PatronSelfModificationMandatoryField`, `PatronSelfRegistrationBorrowerMandatoryField` and `PatronSelfRegistrationBorrowerUnwantedField` to confirm you can make the new field required or hidden. 11) Verify that DefaultPatronSearchFields contains the new field if you already had 'firstname' in the field list 12) Enable PatronAutoComplete system preference 13) Type patrons surname into checkout or patron search but don't hit return 14) Confirm the patrons middle name is displayed in the preview 15) Go to tools > patron lists and attempt to add a patron to a list 16) Patrons middle name should appear in the autocomplete here too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133755|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134257&action=edit Bug 21978: Schema Update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133756|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134258&action=edit Bug 21978: Add middle_name into hold request autocomplete -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133757|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134259&action=edit Bug 21978: Use patron-title.inc in request.tt This patch updates all manual accurences of the patron title display to use the patron-title.inc include (so we get middlename handling) in request.tt. We also add the option to hide the cardnumber from the include and set the link_to to 'members_pay' to retain the current display format on this page. Test plan You'll need to trigger the following cases to test all cases: 1) Too many holds 2) Account expired 3) Has restrictions 4) Outstanding fines 5) Already has hold on item 6) No holds allowed 7) Too many holds for this record 8) Already in possession 9) Already has a hold 10) Already has a recall 11) Pickup library doesn't many patron home library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased and added the sponsorship line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #64 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Hi Martin, The bulk of it is perfect. I noticed that when you use PatronAutoComplete, first names and surnames will partially match, but middle names won't. e.g. - Set up two users: Henry James Johns and Henry Jameston Johnson - Do a search for 'Hen' - note that both are returned (Henry and Henry) - Do a search for 'John' - note that both are returned (Johns and Johnson) - Do a search for 'James' - note that only Henry James Johns is returned, and Henry Jameston Johnson isn't. I also noticed a few places where the middle name didn't display; to replicate: 1) - Load patron account - Press search to hold - Perform a search which brings back 2+ items (e.g. 'street') - Note that on the search results it says: Place hold for 'Firstname Surname' 2) - Load patron account - Press search to hold - Perform a search - Open a record - Press the Place hold button - Note that the drop down for 'Place hold for patron' doesn't include middle name 3) - Load patron account - Accounting - Make a payment (when patron owes no charges) - Note that it says 'Firstname Surname has no outstanding fines' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134495&action=edit Bug 21978: Use patron-title for holdfor handling in results This patch update the catalogue search results page to use the patron-title include to display patron titles for the 'Holds for' line in results and dropdown list. Test plan 1) Load patron account 2) Press search to hold 3) Perform a search which brings back 2+ items (e.g. 'street') 4) Note that on the search results it says: Place hold for 'firstname (othername) surname (cardnumber)' 5) Press the Place hold button and note that the dropdown includes "Place hold for 'firstname (othername) surname'" and "Forget 'firstname (othername) surname'" 6) Click through to an item from the results, press the 'Place hold' button and note the dropdown includes "Place hold for 'firstname (othername) surname'" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hi Sally, I've resolved the autocomplete issue you mentioned.. and have added another follow-up to correct the mentioned display issue. I have a feeling if you dig too deeply you'll find a lot more cases where the display isn't yet taken care of.. I've opened a bug to try and catch all of these occurrences.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134254|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134497&action=edit Bug 21978: Add middle_name field to the database This patch adds a new field, middle_name, to the borrowers, deletedborrowers and borrower_modifications tables. It also updates the DefaultPatronSearchFields preference to include the new field if the preference is still set to it's default settings from install. Sponsored-by: Cheshire Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134255|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134498&action=edit Bug 21978: Add middle_name to api specification This patch adds middle_name to the accaeptable fields in API requests and responses. Test plan 1) Search for a user using the API 2) Confirm the API responds with a 200 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134256|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134499&action=edit Bug 21978: Add support for middle name This patch adds the new 'Middle name' field to the patron record. To test: 1) Apply patches 2) Update database, restart all and clear the browser cache 3) Load a patron in the staff module 4) Confirm you can see and edit the new 'Middle name' field 5) Confirm the new middle name data displays on patron details 6) Confirm the new middle name data displays on patron search results 7) Confirm the new middle name data displays everywhere patron names are displayed. 8) Confirm the new middle name data displays on the OPAC 9) Confirm the 'Middle name' field appears in the OPAC borrower modification screens 10) Edit sysprefs `BorrowerMandatoryFields`, `BorrowerUnwantedFields`, `SelfModificationBorrowerUnwantedField`, `PatronSelfModificationMandatoryField`, `PatronSelfRegistrationBorrowerMandatoryField` and `PatronSelfRegistrationBorrowerUnwantedField` to confirm you can make the new field required or hidden. 11) Verify that DefaultPatronSearchFields contains the new field if you already had 'firstname' in the field list 12) Enable PatronAutoComplete system preference 13) Type patrons surname into checkout or patron search but don't hit return 14) Confirm the patrons middle name is displayed in the preview 15) Go to tools > patron lists and attempt to add a patron to a list 16) Patrons middle name should appear in the autocomplete here too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134257|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134500&action=edit Bug 21978: Schema Update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134258|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134501&action=edit Bug 21978: Add middle_name into hold request autocomplete -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134259|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134502&action=edit Bug 21978: Use patron-title.inc in request.tt This patch updates all manual accurences of the patron title display to use the patron-title.inc include (so we get middlename handling) in request.tt. We also add the option to hide the cardnumber from the include and set the link_to to 'members_pay' to retain the current display format on this page. Test plan You'll need to trigger the following cases to test all cases: 1) Too many holds 2) Account expired 3) Has restrictions 4) Outstanding fines 5) Already has hold on item 6) No holds allowed 7) Too many holds for this record 8) Already in possession 9) Already has a hold 10) Already has a recall 11) Pickup library doesn't many patron home library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134495|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134503&action=edit Bug 21978: Use patron-title for holdfor handling in results This patch update the catalogue search results page to use the patron-title include to display patron titles for the 'Holds for' line in results and dropdown list. Test plan 1) Load patron account 2) Press search to hold 3) Perform a search which brings back 2+ items (e.g. 'street') 4) Note that on the search results it says: Place hold for 'firstname (othername) surname (cardnumber)' 5) Press the Place hold button and note that the dropdown includes "Place hold for 'firstname (othername) surname'" and "Forget 'firstname (othername) surname'" 6) Click through to an item from the results, press the 'Place hold' button and note the dropdown includes "Place hold for 'firstname (othername) surname'" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134497|0 |1 is obsolete| | --- Comment #74 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 134745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134745&action=edit Bug 21978: Add middle_name field to the database This patch adds a new field, middle_name, to the borrowers, deletedborrowers and borrower_modifications tables. It also updates the DefaultPatronSearchFields preference to include the new field if the preference is still set to it's default settings from install. Sponsored-by: Cheshire Libraries Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134498|0 |1 is obsolete| | --- Comment #75 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 134746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134746&action=edit Bug 21978: Add middle_name to api specification This patch adds middle_name to the accaeptable fields in API requests and responses. Test plan 1) Search for a user using the API 2) Confirm the API responds with a 200 Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134499|0 |1 is obsolete| | --- Comment #76 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 134747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134747&action=edit Bug 21978: Add support for middle name This patch adds the new 'Middle name' field to the patron record. To test: 1) Apply patches 2) Update database, restart all and clear the browser cache 3) Load a patron in the staff module 4) Confirm you can see and edit the new 'Middle name' field 5) Confirm the new middle name data displays on patron details 6) Confirm the new middle name data displays on patron search results 7) Confirm the new middle name data displays everywhere patron names are displayed. 8) Confirm the new middle name data displays on the OPAC 9) Confirm the 'Middle name' field appears in the OPAC borrower modification screens 10) Edit sysprefs `BorrowerMandatoryFields`, `BorrowerUnwantedFields`, `SelfModificationBorrowerUnwantedField`, `PatronSelfModificationMandatoryField`, `PatronSelfRegistrationBorrowerMandatoryField` and `PatronSelfRegistrationBorrowerUnwantedField` to confirm you can make the new field required or hidden. 11) Verify that DefaultPatronSearchFields contains the new field if you already had 'firstname' in the field list 12) Enable PatronAutoComplete system preference 13) Type patrons surname into checkout or patron search but don't hit return 14) Confirm the patrons middle name is displayed in the preview 15) Go to tools > patron lists and attempt to add a patron to a list 16) Patrons middle name should appear in the autocomplete here too Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134500|0 |1 is obsolete| | --- Comment #77 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 134748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134748&action=edit Bug 21978: Schema Update Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134501|0 |1 is obsolete| | --- Comment #78 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 134749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134749&action=edit Bug 21978: Add middle_name into hold request autocomplete Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134502|0 |1 is obsolete| | --- Comment #79 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 134750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134750&action=edit Bug 21978: Use patron-title.inc in request.tt This patch updates all manual accurences of the patron title display to use the patron-title.inc include (so we get middlename handling) in request.tt. We also add the option to hide the cardnumber from the include and set the link_to to 'members_pay' to retain the current display format on this page. Test plan You'll need to trigger the following cases to test all cases: 1) Too many holds 2) Account expired 3) Has restrictions 4) Outstanding fines 5) Already has hold on item 6) No holds allowed 7) Too many holds for this record 8) Already in possession 9) Already has a hold 10) Already has a recall 11) Pickup library doesn't many patron home library Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134503|0 |1 is obsolete| | --- Comment #80 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 134751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134751&action=edit Bug 21978: Use patron-title for holdfor handling in results This patch update the catalogue search results page to use the patron-title include to display patron titles for the 'Holds for' line in results and dropdown list. Test plan 1) Load patron account 2) Press search to hold 3) Perform a search which brings back 2+ items (e.g. 'street') 4) Note that on the search results it says: Place hold for 'firstname (othername) surname (cardnumber)' 5) Press the Place hold button and note that the dropdown includes "Place hold for 'firstname (othername) surname'" and "Forget 'firstname (othername) surname'" 6) Click through to an item from the results, press the 'Place hold' button and note the dropdown includes "Place hold for 'firstname (othername) surname'" Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #81 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- (In reply to Martin Renvoize from comment #66)
Hi Sally,
I've resolved the autocomplete issue you mentioned.. and have added another follow-up to correct the mentioned display issue.
I have a feeling if you dig too deeply you'll find a lot more cases where the display isn't yet taken care of.. I've opened a bug to try and catch all of these occurrences..
Brilliant, thanks for your work on this, Martin - all working well. The autocomplete is excellent. More than happy to pick up those small instances on another bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #82 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- C4::Context->set_preference('DefaultPatronSearchFields', join(',',@default_patron_search_fields) ); Shouldn't we alter the DB directly? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #83 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Please adjust "Bug 21978: Use patron-title.inc in request.tt" to be consistent with spaces: - <li><strong>No holds allowed: </strong> + <li><strong>No holds allowed:</strong> vs - <li><strong>Too many holds for this record: </strong> + <li><strong>Too many holds for this record: </strong> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #84 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- * request.tt l. 384 not correctly indented * In last patch: - holdfor => $query->cookie("holdfor"), - holdfor_surname => $holdfor_patron->surname, - holdfor_firstname => $holdfor_patron->firstname, + holdfor => $query->cookie("holdfor"), + holdfor_patron => $holdfor_patron, holdfor_cardnumber => $holdfor_patron->cardnumber, Why do you keep holdfor_cardnumber? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #85 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Martin, please provide a fresh patchset quickly, this is almost ready for my PQA stamp! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134745|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135147&action=edit Bug 21978: Add middle_name field to the database This patch adds a new field, middle_name, to the borrowers, deletedborrowers and borrower_modifications tables. It also updates the DefaultPatronSearchFields preference to include the new field if the preference is still set to it's default settings from install. Sponsored-by: Cheshire Libraries Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134746|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135148&action=edit Bug 21978: Add middle_name to api specification This patch adds middle_name to the accaeptable fields in API requests and responses. Test plan 1) Search for a user using the API 2) Confirm the API responds with a 200 Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134747|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135149&action=edit Bug 21978: Add support for middle name This patch adds the new 'Middle name' field to the patron record. To test: 1) Apply patches 2) Update database, restart all and clear the browser cache 3) Load a patron in the staff module 4) Confirm you can see and edit the new 'Middle name' field 5) Confirm the new middle name data displays on patron details 6) Confirm the new middle name data displays on patron search results 7) Confirm the new middle name data displays everywhere patron names are displayed. 8) Confirm the new middle name data displays on the OPAC 9) Confirm the 'Middle name' field appears in the OPAC borrower modification screens 10) Edit sysprefs `BorrowerMandatoryFields`, `BorrowerUnwantedFields`, `SelfModificationBorrowerUnwantedField`, `PatronSelfModificationMandatoryField`, `PatronSelfRegistrationBorrowerMandatoryField` and `PatronSelfRegistrationBorrowerUnwantedField` to confirm you can make the new field required or hidden. 11) Verify that DefaultPatronSearchFields contains the new field if you already had 'firstname' in the field list 12) Enable PatronAutoComplete system preference 13) Type patrons surname into checkout or patron search but don't hit return 14) Confirm the patrons middle name is displayed in the preview 15) Go to tools > patron lists and attempt to add a patron to a list 16) Patrons middle name should appear in the autocomplete here too Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134748|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135150&action=edit Bug 21978: Schema Update Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134749|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135151&action=edit Bug 21978: Add middle_name into hold request autocomplete Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134750|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135152&action=edit Bug 21978: Use patron-title.inc in request.tt This patch updates all manual accurences of the patron title display to use the patron-title.inc include (so we get middlename handling) in request.tt. We also add the option to hide the cardnumber from the include and set the link_to to 'members_pay' to retain the current display format on this page. Test plan You'll need to trigger the following cases to test all cases: 1) Too many holds 2) Account expired 3) Has restrictions 4) Outstanding fines 5) Already has hold on item 6) No holds allowed 7) Too many holds for this record 8) Already in possession 9) Already has a hold 10) Already has a recall 11) Pickup library doesn't many patron home library Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134751|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135153&action=edit Bug 21978: Use patron-title for holdfor handling in results This patch update the catalogue search results page to use the patron-title include to display patron titles for the 'Holds for' line in results and dropdown list. Test plan 1) Load patron account 2) Press search to hold 3) Perform a search which brings back 2+ items (e.g. 'street') 4) Note that on the search results it says: Place hold for 'firstname (othername) surname (cardnumber)' 5) Press the Place hold button and note that the dropdown includes "Place hold for 'firstname (othername) surname'" and "Forget 'firstname (othername) surname'" 6) Click through to an item from the results, press the 'Place hold' button and note the dropdown includes "Place hold for 'firstname (othername) surname'" Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #93 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135154&action=edit Bug 21978: (follow-up) Stop passing holdfor_cardnumber We not longer need to pass holdfor_cardnumber distinctly, we can just refer to holdfor_patron.cardnumber instead. This patch does that ;P -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #94 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Doh, I missed the first comment.. brb -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #95 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135155&action=edit Bug 21978: (follow-up) Stop using C4 methods in atomicupdate We should really only use C4::Context methods where absolutely necessary.. in this case is was simple to replace the get_preference and set_preference calls with SQL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #96 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #83 and #84) * Spacing fixed and squashed * Indents fixed and squashed * Follow-up added to drop passing for holdfor_cardnumber. Original reason for keeping it was that I hadn't dug enough to spot if it was used more widely.. I've not done that digging and replaced the JS reference to it with the right placeholder too. * Follow-up added to fix atomicupdate to only use SQL where possible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135147|0 |1 is obsolete| | Attachment #135148|0 |1 is obsolete| | Attachment #135149|0 |1 is obsolete| | Attachment #135150|0 |1 is obsolete| | Attachment #135151|0 |1 is obsolete| | Attachment #135152|0 |1 is obsolete| | Attachment #135153|0 |1 is obsolete| | Attachment #135154|0 |1 is obsolete| | Attachment #135155|0 |1 is obsolete| | --- Comment #97 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135180&action=edit Bug 21978: Add middle_name field to the database This patch adds a new field, middle_name, to the borrowers, deletedborrowers and borrower_modifications tables. It also updates the DefaultPatronSearchFields preference to include the new field if the preference is still set to it's default settings from install. Sponsored-by: Cheshire Libraries Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #98 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135181&action=edit Bug 21978: Add middle_name to api specification This patch adds middle_name to the accaeptable fields in API requests and responses. Test plan 1) Search for a user using the API 2) Confirm the API responds with a 200 Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #99 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135182&action=edit Bug 21978: Add support for middle name This patch adds the new 'Middle name' field to the patron record. To test: 1) Apply patches 2) Update database, restart all and clear the browser cache 3) Load a patron in the staff module 4) Confirm you can see and edit the new 'Middle name' field 5) Confirm the new middle name data displays on patron details 6) Confirm the new middle name data displays on patron search results 7) Confirm the new middle name data displays everywhere patron names are displayed. 8) Confirm the new middle name data displays on the OPAC 9) Confirm the 'Middle name' field appears in the OPAC borrower modification screens 10) Edit sysprefs `BorrowerMandatoryFields`, `BorrowerUnwantedFields`, `SelfModificationBorrowerUnwantedField`, `PatronSelfModificationMandatoryField`, `PatronSelfRegistrationBorrowerMandatoryField` and `PatronSelfRegistrationBorrowerUnwantedField` to confirm you can make the new field required or hidden. 11) Verify that DefaultPatronSearchFields contains the new field if you already had 'firstname' in the field list 12) Enable PatronAutoComplete system preference 13) Type patrons surname into checkout or patron search but don't hit return 14) Confirm the patrons middle name is displayed in the preview 15) Go to tools > patron lists and attempt to add a patron to a list 16) Patrons middle name should appear in the autocomplete here too Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #100 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135183&action=edit Bug 21978: Schema Update Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #101 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135184&action=edit Bug 21978: Add middle_name into hold request autocomplete Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #102 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135185&action=edit Bug 21978: Use patron-title.inc in request.tt This patch updates all manual accurences of the patron title display to use the patron-title.inc include (so we get middlename handling) in request.tt. We also add the option to hide the cardnumber from the include and set the link_to to 'members_pay' to retain the current display format on this page. Test plan You'll need to trigger the following cases to test all cases: 1) Too many holds 2) Account expired 3) Has restrictions 4) Outstanding fines 5) Already has hold on item 6) No holds allowed 7) Too many holds for this record 8) Already in possession 9) Already has a hold 10) Already has a recall 11) Pickup library doesn't many patron home library Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #103 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135186&action=edit Bug 21978: Use patron-title for holdfor handling in results This patch update the catalogue search results page to use the patron-title include to display patron titles for the 'Holds for' line in results and dropdown list. Test plan 1) Load patron account 2) Press search to hold 3) Perform a search which brings back 2+ items (e.g. 'street') 4) Note that on the search results it says: Place hold for 'firstname (othername) surname (cardnumber)' 5) Press the Place hold button and note that the dropdown includes "Place hold for 'firstname (othername) surname'" and "Forget 'firstname (othername) surname'" 6) Click through to an item from the results, press the 'Place hold' button and note the dropdown includes "Place hold for 'firstname (othername) surname'" Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #104 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135187&action=edit Bug 21978: (follow-up) Stop passing holdfor_cardnumber We not longer need to pass holdfor_cardnumber distinctly, we can just refer to holdfor_patron.cardnumber instead. This patch does that ;P Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #105 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135188&action=edit Bug 21978: (follow-up) Stop using C4 methods in atomicupdate We should really only use C4::Context methods where absolutely necessary.. in this case is was simple to replace the get_preference and set_preference calls with SQL Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #106 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135189&action=edit Bug 21978: Add middle_name to sysprefs.sql And add middle_name at the exact same places for installations with the default value. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #107 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Do you agree with this last patch, Martin? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #108 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks great to me Jonathan, thanks for the follow-up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10950 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135180|0 |1 is obsolete| | --- Comment #109 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136513&action=edit Bug 21978: Add middle_name field to the database This patch adds a new field, middle_name, to the borrowers, deletedborrowers and borrower_modifications tables. It also updates the DefaultPatronSearchFields preference to include the new field if the preference is still set to it's default settings from install. Sponsored-by: Cheshire Libraries Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135181|0 |1 is obsolete| | --- Comment #110 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136514&action=edit Bug 21978: Add middle_name to api specification This patch adds middle_name to the accaeptable fields in API requests and responses. Test plan 1) Search for a user using the API 2) Confirm the API responds with a 200 Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135182|0 |1 is obsolete| | --- Comment #111 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136515&action=edit Bug 21978: Add support for middle name This patch adds the new 'Middle name' field to the patron record. To test: 1) Apply patches 2) Update database, restart all and clear the browser cache 3) Load a patron in the staff module 4) Confirm you can see and edit the new 'Middle name' field 5) Confirm the new middle name data displays on patron details 6) Confirm the new middle name data displays on patron search results 7) Confirm the new middle name data displays everywhere patron names are displayed. 8) Confirm the new middle name data displays on the OPAC 9) Confirm the 'Middle name' field appears in the OPAC borrower modification screens 10) Edit sysprefs `BorrowerMandatoryFields`, `BorrowerUnwantedFields`, `SelfModificationBorrowerUnwantedField`, `PatronSelfModificationMandatoryField`, `PatronSelfRegistrationBorrowerMandatoryField` and `PatronSelfRegistrationBorrowerUnwantedField` to confirm you can make the new field required or hidden. 11) Verify that DefaultPatronSearchFields contains the new field if you already had 'firstname' in the field list 12) Enable PatronAutoComplete system preference 13) Type patrons surname into checkout or patron search but don't hit return 14) Confirm the patrons middle name is displayed in the preview 15) Go to tools > patron lists and attempt to add a patron to a list 16) Patrons middle name should appear in the autocomplete here too Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135183|0 |1 is obsolete| | --- Comment #112 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136516&action=edit Bug 21978: Schema Update Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135184|0 |1 is obsolete| | --- Comment #113 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136517&action=edit Bug 21978: Add middle_name into hold request autocomplete Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135185|0 |1 is obsolete| | --- Comment #114 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136518&action=edit Bug 21978: Use patron-title.inc in request.tt This patch updates all manual accurences of the patron title display to use the patron-title.inc include (so we get middlename handling) in request.tt. We also add the option to hide the cardnumber from the include and set the link_to to 'members_pay' to retain the current display format on this page. Test plan You'll need to trigger the following cases to test all cases: 1) Too many holds 2) Account expired 3) Has restrictions 4) Outstanding fines 5) Already has hold on item 6) No holds allowed 7) Too many holds for this record 8) Already in possession 9) Already has a hold 10) Already has a recall 11) Pickup library doesn't many patron home library Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135186|0 |1 is obsolete| | --- Comment #115 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136519&action=edit Bug 21978: Use patron-title for holdfor handling in results This patch update the catalogue search results page to use the patron-title include to display patron titles for the 'Holds for' line in results and dropdown list. Test plan 1) Load patron account 2) Press search to hold 3) Perform a search which brings back 2+ items (e.g. 'street') 4) Note that on the search results it says: Place hold for 'firstname (othername) surname (cardnumber)' 5) Press the Place hold button and note that the dropdown includes "Place hold for 'firstname (othername) surname'" and "Forget 'firstname (othername) surname'" 6) Click through to an item from the results, press the 'Place hold' button and note the dropdown includes "Place hold for 'firstname (othername) surname'" Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135187|0 |1 is obsolete| | --- Comment #116 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136520&action=edit Bug 21978: (follow-up) Stop passing holdfor_cardnumber We not longer need to pass holdfor_cardnumber distinctly, we can just refer to holdfor_patron.cardnumber instead. This patch does that ;P Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135188|0 |1 is obsolete| | --- Comment #117 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136521&action=edit Bug 21978: (follow-up) Stop using C4 methods in atomicupdate We should really only use C4::Context methods where absolutely necessary.. in this case is was simple to replace the get_preference and set_preference calls with SQL Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135189|0 |1 is obsolete| | --- Comment #118 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136522&action=edit Bug 21978: Add middle_name to sysprefs.sql And add middle_name at the exact same places for installations with the default value. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #119 from Christopher Brannon <cbrannon@cdalibrary.org> --- Passed QA! This is a huge step forward! This has been needed for so long! Thank you Martin for this much needed field! I am really looking forward to seeing it in production! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #120 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #121 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Did you notice that t/db_dependent/selenium/patrons_search.t was failing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #122 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137612&action=edit Bug 21978: Fix Selenium tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #123 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Is watching the CI after pushing still a thing or...? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #124 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #122)
Created attachment 137612 [details] [review] Bug 21978: Fix Selenium tests
This patch is messy but makes the tests pass. I think the behaviours are correct (tested using the UI). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #125 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I only see TestBuilder failures on Jenkins at the moment.. so hadn't spotted this no... thanks for the patch.. I'll take a look to confirm it makes sense now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #126 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Patch makes sense.. why is this only failing on D11 though and not any of the other runs? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #127 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #126)
Patch makes sense.. why is this only failing on D11 though and not any of the other runs?
D11 is the only job that has LIGHT_RUN=0 and run the selenium tests (including drop+create of the DB and run webinstaller). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #128 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Aha, I see.. I'm a little out of date then.. I tended to track D10 as I thought it was still the most complete run. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | CC| |tomascohen@gmail.com --- Comment #129 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Thanks for the follow-up, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Needs documenting --- Comment #130 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Documentation| |Martin Renvoize contact| | Resolution|--- |FIXED --- Comment #131 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think, beyond screenshot updates, there's nothing really to change here for documentation.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds a new free text release notes| |field 'Middle name' to the | |patron record. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org