[Bug 41570] New: Tidy kohaTable block - course_reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41570 Bug ID: 41570 Summary: Tidy kohaTable block - course_reserves Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41570 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |jonathan.druart@gmail.com Blocks| |41324 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 [Bug 41324] Tidy kohaTable block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41570 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41570 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191127&action=edit Bug 41570: Tidy kohaTable - course_reserves/course-details.tt Patch from commit 78c174e -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41570 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191128&action=edit Bug 41570: Tidy kohaTable - course_reserves/course-reserves.tt Patch from commit 4cb6d9d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41570 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191129&action=edit Bug 41570: course_reserves - auto tidy Patch from commit 8f0d9c9 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41570 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41570 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191127|0 |1 is obsolete| | Attachment #191128|0 |1 is obsolete| | Attachment #191129|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191389&action=edit Bug 41570: Tidy kohaTable - course_reserves/course-details.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41570 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191390&action=edit Bug 41570: Tidy kohaTable - course_reserves/course-reserves.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41570 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191391&action=edit Bug 41570: course_reserves - auto tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41570 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191392&action=edit Bug 41570: (follow-up) i18n correction, course deletion fix The template's i18n function, I18N.tnx, doesn't work with JavaScript variables, so I've updated it to use the template variable. I also found that I couldn't properly test the course deletion function without fixing a problem which exists in main: The delete course button didn't trigger the confirmation, and the event which was supposed to trigger the confirmation was attached to the whole form. The confirmation is now triggered on form submit. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41570 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41570 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191389|0 |1 is obsolete| | --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194700&action=edit Bug 41570: Tidy kohaTable - course_reserves/course-details.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41570 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191390|0 |1 is obsolete| | --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194701&action=edit Bug 41570: Tidy kohaTable - course_reserves/course-reserves.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41570 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191391|0 |1 is obsolete| | --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194702&action=edit Bug 41570: course_reserves - auto tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41570 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191392|0 |1 is obsolete| | --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194703&action=edit Bug 41570: (follow-up) i18n correction, course deletion fix The template's i18n function, I18N.tnx, doesn't work with JavaScript variables, so I've updated it to use the template variable. I also found that I couldn't properly test the course deletion function without fixing a problem which exists in main: The delete course button didn't trigger the confirmation, and the event which was supposed to trigger the confirmation was attached to the whole form. The confirmation is now triggered on form submit. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41570 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41570 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41570 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara@openfifth.co.uk Status|Pushed to main |Needs documenting --- Comment #13 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Enhancement, not backporting. Scream at me if you feel strongly it should be backported. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org