[Bug 22553] New: Unchecking a subpermission does not uncheck the top level permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553 Bug ID: 22553 Summary: Unchecking a subpermission does not uncheck the top level permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Target Milestone: --- To recreate: 1 - Edit permissions for a user 2 - Check a top level permission 3 - Uncheck some sub permissions 4 - Note the top level is still checked 5 - Save 6 - Edit the permissions agin 7 - User has top level permission -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Depends on| |11375 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 [Bug 11375] Improve patrons permissions display -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just ran into this as well - It's dangerous as it could go unnoticed easily and having to uncheck the top permission means you have to set all sub-permissions again, which is error-prone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87606&action=edit Bug 22553: Unchecking a subpermission does not uncheck the top level permission This patch makes a minor change to the set permissions page's JavaScript so that unchecking a subpermission will uncheck the top level permission. To test, apply the patch and open the "Set permissions" page for a patron. - Expand a permission with multiple subpermissions. - Check the top level permission. All subpermissions should be checked. - Uncheck one of the subpermissions. The top level permission should now be unchecked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87606|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87607&action=edit Bug 22553: Unchecking a subpermission does not uncheck the top level permission This patch makes a minor change to the set permissions page's JavaScript so that unchecking a subpermission will uncheck the top level permission. To test, apply the patch and open the "Set permissions" page for a patron. - Expand a permission with multiple subpermissions. - Check the top level permission. All subpermissions should be checked. - Uncheck one of the subpermissions. The top level permission should now be unchecked. Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87607|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87670&action=edit Bug 22553: Unchecking a subpermission does not uncheck the top level permission This patch makes a minor change to the set permissions page's JavaScript so that unchecking a subpermission will uncheck the top level permission. To test, apply the patch and open the "Set permissions" page for a patron. - Expand a permission with multiple subpermissions. - Check the top level permission. All subpermissions should be checked. - Uncheck one of the subpermissions. The top level permission should now be unchecked. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug in enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org