https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22675 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21206 Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 [Bug 21206] C4::Items - Remove GetItem -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22675 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 87672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87672&action=edit Bug 22675: Fix SCO behaviour on non-existent barcodes Bug 21206 replaced GetItem for Koha::Items->find, and introduced this problem. This patch verifies $item is defined before attempting to use its methods. To test: - Log into SCO - Type an invalid barcode => FAIL: Things explode :-/ - Apply this patch, reload - Type an invalid barcode => SUCCESS: A nice error message is displayed :-D - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22675 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87672|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87684&action=edit Bug 22675: Fix SCO behaviour on non-existent barcodes Bug 21206 replaced GetItem for Koha::Items->find, and introduced this problem. This patch verifies $item is defined before attempting to use its methods. To test: - Log into SCO - Type an invalid barcode => FAIL: Things explode :-/ - Apply this patch, reload - Type an invalid barcode => SUCCESS: A nice error message is displayed :-D - Sign off :-D Signed-off-by: Liz Rea <wizzyrea@gmail.com> 100% that used to explode, and now does not. Excellent. 100% that used to explode, and now does not. Excellent. 100% that used to explode, and now does not. Excellent. 100% that used to explode, and now does not. Excellent. 100% that used to explode, and now does not. Excellent. 100% that used to explode, and now does not. Excellent. 100% that used to explode, and now does not. Excellent. 100% that used to explode, and now does not. Excellent. 100% that used to explode, and now does not. Excellent. 100% that used to explode, and now does not. Excellent. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22675 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87684|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87685&action=edit Bug 22675: Fix SCO behaviour on non-existent barcodes Bug 21206 replaced GetItem for Koha::Items->find, and introduced this problem. This patch verifies $item is defined before attempting to use its methods. To test: - Log into SCO - Type an invalid barcode => FAIL: Things explode :-/ - Apply this patch, reload - Type an invalid barcode => SUCCESS: A nice error message is displayed :-D - Sign off :-D Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22675 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22675 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87685|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87702&action=edit Bug 22675: Fix SCO behaviour on non-existent barcodes Bug 21206 replaced GetItem for Koha::Items->find, and introduced this problem. This patch verifies $item is defined before attempting to use its methods. To test: - Log into SCO - Type an invalid barcode => FAIL: Things explode :-/ - Apply this patch, reload - Type an invalid barcode => SUCCESS: A nice error message is displayed :-D - Sign off :-D Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22675 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug in enhancement not in 18.11.x series -- You are receiving this mail because: You are watching all bug changes.