[Bug 7093] New: Placeholders for suggestion table in suggestion related mails broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7093 Bug #: 7093 Summary: Placeholders for suggestion table in suggestion related mails broken Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: critical Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org Blocks: 4211 There are mails generated when you mark something as available or when you mark it as rejected. Every time you change the status between those too, the patron will get a notification. The messages are correctly written into the message_queue table. BUT: The placeholders for fields from suggestions do not work. The patron name showed up correctly. For testing purposes I added all fields from suggestions to my notices: suggestionid <<suggestions.suggestionid>> suggestedby <<suggestions.suggestedby>> suggesteddate <<suggestions.suggesteddate>> managedby <<suggestions.managedby>> manageddate <<suggestions.manageddate>> acceptedby <<suggestions.acceptedby>> accepteddate <<suggestions.accepteddate>> rejectedby <<suggestions.rejectedby>> rejecteddate <<suggestions.rejecteddate>> STATUS <<suggestions.STATUS>> note <<suggestions.note>> author <<suggestions.author>> title <<suggestions.title>> copyrightdate <<suggestions.copyrightdate>> publishercode <<suggestions.publishercode>> date <<suggestions.date>> volumedesc <<suggestions.volumedesc>> publicationyear <<suggestions.publicationyear>> place <<suggestions.place>> isbn <<suggestions.isbn>> mailoverseeing <<suggestions.mailoverseeing>> biblionumber <<suggestions.biblionumber>> reason <<suggestions.reason>> budgetid <<suggestions.budgetid>> branchcode <<suggestions.branchcode>> collectiontitle <<suggestions.collectiontitle>> itemtype <<suggestions.itemtype>> quantity <<suggestions.quantity>> currency <<suggestions.currency>> price <<suggestions.price>> total <<suggestions.total>> None of those showed up in my mails. Without at least title and author the mails are quite useless. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7093 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|4211 | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7093 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4211 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7093 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-10 20:19:59 UTC --- *** Bug 7212 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7093 --- Comment #2 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-07 16:47:14 UTC --- Created attachment 6639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6639 Proposed Patch In parseletter_sth, the suggestions table was defined twice. The first time (which is the only definition to get called, as it matches first then exists), defined the primary search keys as borrowernumber and biblionumber. This is incorrect; the only usage of the suggestions table tokens is with suggestionid as the key. This is defined further down the if/then chain. This patch removes the erroneous sth query definition. To test: 1. Place a suggestion with a patron account with a configured email you can access 2. Approve or reject it 3. Verify the message you receive contains suggestion tokens (like title, author and reason) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7093 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent CC| |ian.walls@bywatersolutions. | |com Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7093 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|henridamien@koha-fr.org |ian.walls@bywatersolutions. | |com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7093 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6639|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-08 05:46:48 UTC --- Created attachment 6657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6657 [SIGNED-OFF] Bug 7093: placeholds for suggestion table not working in notices In parseletter_sth, the suggestions table was defined twice. The first time (which is the only definition to get called, as it matches first then exists), defined the primary search keys as borrowernumber and biblionumber. This is incorrect; the only usage of the suggestions table tokens is with suggestionid as the key. This is defined further down the if/then chain. This patch removes the erroneous sth query definition. To test: 1. Place a suggestion with a patron account with a configured email you can access 2. Approve or reject it 3. Verify the message you receive contains suggestion tokens (like title, author and reason) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Suggestion mails for accepted, rejected and ordered look good now. I couldn't test the suggestion mail AVAILABLE (bug 7096), but assuming this would work too. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7093 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7093 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | --- Comment #4 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-08 15:23:34 UTC --- Assigning to Marcel for QA, since I wrote -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7093 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Signed Off |Patch Pushed --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-13 15:50:07 UTC --- QA comment: small patch, obvious bug, passed QA patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7093 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Included in 3.6 prior to 3.6.5. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org