[Bug 7334] New: Improve 'No address stored' and similar messages in patron account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7334 Bug #: 7334 Summary: Improve 'No address stored' and similar messages in patron account Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates AssignedTo: katrin.fischer@bsz-bw.de ReportedBy: katrin.fischer@bsz-bw.de QAContact: ian.walls@bywatersolutions.com Created attachment 6658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6658 screenshot The 'no address stored' message above the left menu in the patron account shows up, when the first address field is empty. It would make more sense to check for first and second address line to be empty, before showing the message. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7334 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-08 06:22:22 UTC --- Created attachment 6659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6659 Bug 7334: Improve 'no address stored' and similar messages in patron account - 'no address stored' is now only displayed when first and second line of the address are empty - added id's to all 3 possible messages so people can change or hide them To test: 1) Check 'no address stored' shows only up when address fields are both empty 2) Check address is still correctly displayed Note: make sure you check the 'checkouts' and other tabs, because there are 2 different include files used here. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7334 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7334 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6659|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> 2011-12-08 07:28:45 UTC --- Created attachment 6662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6662 Signed-off patch Bug 7334: Improve 'no address stored' and similar messages in patron account - 'no address stored' is now only displayed when first and second line of the address are empty - added id's to all 3 possible messages so people can change or hide them To test: 1) Check 'no address stored' shows only up when address fields are both empty 2) Check address is still correctly displayed Note: make sure you check the 'checkouts' and other tabs, because there are 2 different include files used here. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> I confirm the bug and the solution. Text messages identification for customization with JavaScript is a plus. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7334 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7334 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Signed Off |Patch Pushed --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-15 17:21:19 UTC --- QA comment: small patch related to templates, works prove xt/author/valid-templates.t xt/author/valid-templates.t .. ok passed QA patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7334 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Included in 3.6 prior to 3.6.5. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org