[Bug 6636] New: a syspref to display 'powered by Koha' text to OPAC footer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Bug #: 6636 Summary: a syspref to display 'powered by Koha' text to OPAC footer Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: mtj@kohaaloha.com QAContact: koha-bugs@lists.koha-community.org a syspref to add 'powered by Koha' text to OPAC footer -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 --- Comment #1 from James, Mason <mtj@kohaaloha.com> 2011-07-27 02:12:05 UTC --- Created attachment 4747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4747 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED CC| |nengard@gmail.com Patch Status|--- |Needs Signoff AssignedTo|oleonard@myacpl.org |mtj@kohaaloha.com --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-07-27 02:19:41 UTC --- Mason, I have some questions: #1 where will this appear - above or below opacfooter? #2 why not allow for choosing to show the koha logo or the text? Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 James, Mason <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 Status|ASSIGNED |NEW Patch Status|Needs Signoff |--- AssignedTo|mtj@kohaaloha.com |oleonard@myacpl.org --- Comment #3 from James, Mason <mtj@kohaaloha.com> 2011-07-27 02:39:01 UTC --- patch applied to commit 68f99cdf980222dcb557667925bd6024640cda2a -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 M James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4747|0 |1 is obsolete| | --- Comment #4 from M James <mtj@kohaaloha.com> 2011-07-27 03:53:39 UTC --- Created attachment 4748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4748 a little formatting tweak... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 M James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4748|0 |1 is patch| | Attachment #4748|application/octet-stream |text/plain mime type| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 --- Comment #5 from M James <mtj@kohaaloha.com> 2011-07-27 03:59:07 UTC --- Created attachment 4749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4749 screenshot -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 --- Comment #6 from M James <mtj@kohaaloha.com> 2011-07-27 04:00:55 UTC --- (In reply to comment #2)
Mason,
I have some questions:
#1 where will this appear - above or below opacfooter?
below - take a look at my screenshot
#2 why not allow for choosing to show the koha logo or the text?
that will be the next patch, after this patch is accepted ;) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 M James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 M. James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-07-27 19:53:29 UTC --- Hi Mason, I like this idea! I tested with the new syspref off/on and languagechooser off/on. Some things are missing from the patch: - updatedatabase for existing installatons - translates systempreferences sql files I am marking failed QA because of those 2 problems. I also have some suggestions: - make the link open in a new window - make 'powered by Koha' a link, instead of only Koha I am not sure about having the css directly in the anchor tag. This way it's hard to customize it, like changing the font size or adding a picture. Perhaps having another spot for cutomizable HTML code (like opaccredits) with a default value would work too? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 --- Comment #8 from M. James <mtj@kohaaloha.com> 2011-07-27 22:32:37 UTC ---
Some things are missing from the patch:
- updatedatabase for existing installatons
fyi: an updatedatabase.pl entry is not needed here - the default behaviour for this feature is OFF. when the feature set to ON, the 'OpacKohaUrl' row is created in the systempreferences table so... no updatedatabase.pl is needed ;)
- translates systempreferences sql files
my new patch adds these... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4748|0 |1 is obsolete| | --- Comment #9 from Mason James <mtj@kohaaloha.com> 2011-07-27 22:39:34 UTC --- Created attachment 4762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4762 new patch now with row added to all sysprefs.sql -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 --- Comment #10 from Mason James <mtj@kohaaloha.com> 2011-07-27 22:41:45 UTC --- applied to patch d4b397feb41fe6b0cb8672d8c002b1b0f709b097 http://git.kohaaloha.com/?p=head-dev/.git;a=commit;h=a8f0a96f7cda17fb6cb0046... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 --- Comment #11 from Mason James <mtj@kohaaloha.com> 2011-07-27 22:56:38 UTC --- (In reply to comment #7)
Hi Mason,
I like this idea! I also have some suggestions: - make 'powered by Koha' a link, instead of only Koha
my patch does this already...
I am not sure about having the css directly in the anchor tag. This way it's hard to customize it, like changing the font size or adding a picture. Perhaps having another spot for cutomizable HTML code (like opaccredits) with a default value would work too?
these are great ideas, lets do them after this patch gets accepted... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-07-28 08:12:51 UTC --- I brought this up on IRC, because I was not sure about the updatedatabase. Like you said it will be added to the systempreferences table on first change, but consensus was that updating the database makes sense for a couple of reasons: (09:53:02) paul_p: kf : I agree with rangi = the problem with "no updatedatabase for syspref" is also that it's not created until you explicitly save something. It will work, but may cause trouble sometimes (SQL request to see what's the value of the syspref for example) (09:47:16) rangi: he is right, the way the code works, if it is in the .pref file, it will get created when changed, but (09:47:40) rangi: the update is good because it tells people a new syspref has been added -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4762|0 |1 is obsolete| | --- Comment #13 from Mason James <mtj@kohaaloha.com> 2011-07-31 23:37:23 UTC --- Created attachment 4784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4784 revised patch, with updatedatabase.pl SQL added. (In reply to comment #12)
I brought this up on IRC...
aaah, those are all good reasons. here is a revised patch, with updatedatabase.pl SQL added. thanks all for the feedback :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Patch Status|Needs Signoff |Failed QA --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-04 07:51:09 UTC --- I am very sorry, but your patch is changing kohaversion.pl If you are adding a syspref, please add a section with subversion XXX to updatedatabase.pl. The RM updates kohaversion.pl later on. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4784|0 |1 is obsolete| | --- Comment #15 from Mason James <mtj@kohaaloha.com> 2011-08-04 22:19:29 UTC --- Created attachment 4850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4850 revised patch, with koha-version.pl edit removed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
I am very sorry, but your patch is changing kohaversion.pl
If you are adding a syspref, please add a section with subversion XXX to updatedatabase.pl.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff --- Comment #16 from Mason James <mtj@kohaaloha.com> 2011-08-04 22:21:49 UTC --- (In reply to comment #14) this is now corrected in a newer patch this is now corrected in a newer patch
The RM updates kohaversion.pl later on. ok, thanks for this info
-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Does not apply --- Comment #17 from Nicole C. Engard <nengard@gmail.com> 2011-08-05 11:51:27 UTC --- -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: add 'powered by Koha' text to OPAC footer Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Auth.pm Auto-merging installer/data/mysql/de-DE/mandatory/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/de-DE/mandatory/sysprefs.sql Auto-merging installer/data/mysql/en/mandatory/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/en/mandatory/sysprefs.sql Auto-merging installer/data/mysql/fr-FR/1-Obligatoire/unimarc_standard_systemprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/fr-FR/1-Obligatoire/unimarc_standard_systemprefs.sql Auto-merging installer/data/mysql/it-IT/necessari/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/it-IT/necessari/sysprefs.sql Auto-merging installer/data/mysql/nb-NO/1-Obligatorisk/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/nb-NO/1-Obligatorisk/sysprefs.sql Auto-merging installer/data/mysql/pl-PL/mandatory/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/pl-PL/mandatory/sysprefs.sql Auto-merging installer/data/mysql/ru-RU/mandatory/system_preferences_full_optimal_for_install_only.sql CONFLICT (content): Merge conflict in installer/data/mysql/ru-RU/mandatory/system_preferences_full_optimal_for_install_only.sql Auto-merging installer/data/mysql/uk-UA/mandatory/system_preferences_full_optimal_for_install_only.sql CONFLICT (content): Merge conflict in installer/data/mysql/uk-UA/mandatory/system_preferences_full_optimal_for_install_only.sql Auto-merging installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Failed to merge in the changes. Patch failed at 0001 add 'powered by Koha' text to OPAC footer When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". nengard@debian:~/kohaclone$ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4850|0 |1 is obsolete| | --- Comment #18 from Mason James <mtj@kohaaloha.com> 2011-08-06 00:15:17 UTC --- Created attachment 4873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4873 revised patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 --- Comment #19 from Mason James <mtj@kohaaloha.com> 2011-08-06 00:17:01 UTC --- (In reply to comment #18)
Created attachment 4873 [details] revised patch
applied to commit 240edb6c0da80d3d932442ccd96f9f98e31260c3 '5660 Webinstaller should check if KohaOpacLanguage exists in staff' -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 --- Comment #20 from Mason James <mtj@kohaaloha.com> 2011-08-06 00:21:55 UTC --- (In reply to comment #18)
Created attachment 4873 [details] revised patch
patch emailed to patches@kc.org -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #21 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-10 11:52:21 UTC --- Owen, I added you to the CC list of this report. Patch looks good to me, except from the CSS related issues on the Powered by Koha footer. I guess it would be better to move the hardcoded style stuff to the css. I also noticed that the horizontal line above the language bar disappeared when opaclanguagesdisplay pref was disabled. Could you have a look? Thanks, Marcel -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 --- Comment #22 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-10 12:09:58 UTC --- Just two small extra remarks: 1) www.koha-community.org should be: koha-community.org 2) the <a> link should open in a new window; add target="_blank" attribute -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 --- Comment #23 from Owen Leonard <oleonard@myacpl.org> 2011-08-10 19:59:30 UTC --- I agree that the CSS should be handled in opac.css. The <span> already has an id, you can use that. Doing this will eliminate the other error I see, an all-caps STYLE attribute. It has to be lower-case in order to be valid XHTML. I disagree that the link should open a new window. If we really want to get technical about it, we could wrap it in a check of OPACURLOpenInNewWindow. Otherwise I say leave it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 --- Comment #24 from Mason James <mtj@kohaaloha.com> 2011-08-23 03:31:03 UTC --- (In reply to comment #21)
Owen, I added you to the CC list of this report. Patch looks good to me, except from the CSS related issues on the Powered by Koha footer. I guess it would be better to move the hardcoded style stuff to the css.
yeah, i agree - i'll resumbit with that fix I also noticed that the horizontal line above the language bar
disappeared when opaclanguagesdisplay pref was disabled.
yep, this was a deliberate 'feature' :) i'll removed it, as it introduces some unnecessary duplication to the template file -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4873|0 |1 is obsolete| | --- Comment #25 from Mason James <mtj@kohaaloha.com> 2011-08-23 03:34:32 UTC --- Created attachment 5099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5099 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 --- Comment #26 from Mason James <mtj@kohaaloha.com> 2011-08-23 03:37:22 UTC --- (In reply to comment #22)
Just two small extra remarks: 1) www.koha-community.org should be: koha-community.org
i agree :) fixed in my latest patch fyi, it looks like the canonical url for kc.org has ?recently? changed from www.koha-community.org to koha-community.org (which is a good thing, to me) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 --- Comment #27 from Mason James <mtj@kohaaloha.com> 2011-08-23 04:00:40 UTC --- (In reply to comment #23)
I agree that the CSS should be handled in opac.css.
yep, this is now done
Doing this will eliminate the other error I see, an all-caps STYLE attribute. It has to be lower-case in order to be valid XHTML.
fyi: the new patch tested ok as 'XHTML 1.0 Transitional' at http://validator.w3.org -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin@catalyst.net.nz --- Comment #28 from Robin Sheat <robin@catalyst.net.nz> 2011-08-29 05:53:35 UTC --- Attempted to sign off, however can't convince it to apply :( -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5099|0 |1 is obsolete| | --- Comment #29 from Mason James <mtj@kohaaloha.com> 2011-09-12 06:08:23 UTC --- Created attachment 5402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5402 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff --- Comment #30 from Mason James <mtj@kohaaloha.com> 2011-09-12 06:10:43 UTC --- (In reply to comment #29)
Created attachment 5402 [details] patch
newly attached patch is rebased from today's master/HEAD commit c849f7a90d4eed248bd53a00b8021c07e856e022 Adding the 155th developer to the history -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 --- Comment #31 from Mason James <mtj@kohaaloha.com> 2011-09-12 06:15:51 UTC ---
newly attached patch is rebased from today's master/HEAD
... and emailed to kc.org patches list ;) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 --- Comment #32 from Robin Sheat <robin@catalyst.net.nz> 2011-09-13 01:03:17 UTC --- Created attachment 5411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5411 Bug 6636 - add 'powered by Koha' text to OPAC footer Signed-off-by: Robin Sheat <robin@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5402|0 |1 is obsolete| | --- Comment #33 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-06 16:38:42 UTC --- Comment on attachment 5402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5402 patch this one is obsolete if i'm not wrong (the signed-off version is the other) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com AssignedTo|oleonard@myacpl.org |mtj@kohaaloha.com --- Comment #34 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-06 16:40:18 UTC --- mason, sorry, does not apply anymore :(( Could you rebase & resubmit (keeping "signed-off") If you do it this night, i'll try to QA it tomorrow, to have it for 3.6, it's a small but very usefull ENH ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Does not apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 --- Comment #35 from Robin Sheat <robin@catalyst.net.nz> 2011-10-06 22:57:31 UTC --- Created attachment 5754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5754 Bug 6636 - add 'powered by Koha' text to OPAC footer Signed-off-by: Robin Sheat <robin@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5411|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Signed Off --- Comment #36 from Robin Sheat <robin@catalyst.net.nz> 2011-10-06 22:58:50 UTC --- It was just a conflict in the CSS, I've fixed it against current master. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 --- Comment #37 from Mason James <mtj@kohaaloha.com> 2011-10-06 23:01:57 UTC --- (In reply to comment #36)
It was just a conflict in the CSS, I've fixed it against current master.
yep... and a 'single line of whitespace' conflict against master, too.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 --- Comment #38 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-07 08:44:47 UTC --- Created attachment 5762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5762 Bug 6636 - add 'powered by Koha' text to OPAC footer Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> QA control: added () inside 2 [% IF %] -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5754|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #39 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-07 08:47:33 UTC --- QA comment: * () were missing in a [% IF %] * also does some un-announced changes from TAB to 4 spaces, that's OK Marking passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #40 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-09 07:14:04 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6636 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #41 from Mason James <mtj@kohaaloha.com> 2011-10-09 13:51:46 UTC --- (In reply to comment #40)
Pushed, please test
tested OK - marking resolved ;) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org