[Bug 6818] New: acquisitions basket groups could use some design work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6818 Bug #: 6818 Summary: acquisitions basket groups could use some design work Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: cgi-bin/koha/acqui/basketgroup.pl?booksellerid=1&close d=1 OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org The page of basket groups does not quite match the style of the rest of Koha. Also, the buttons with text on them (reopen and print) are very small and kinda hard to read. It would be nice to see this page get a bit of love in the design department. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6818 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-24 19:26:33 UTC --- Created attachment 6045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6045 Screenshot This is still an issue in Koha 3.6 Besides the colors the used fonts are very small, making it hard to read and work with the page. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6818 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6818 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-10-27 13:16:04 UTC --- Created attachment 6074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6074 Proposed fix I've made changes to the basket grouping interface to bring it in line with other interfaces in Koha. I think it's better to keep things following a consistent pattern. On the page which lists basket groups: - Basket groups listed in a table instead of as custom-styled lists - Buttons use standard style - Tabs are generated by jQuery On the page for managing baskets in a group: - Markup has been revised to be more consistent with established patterns. - Corrections have been made for validity On the basket view page: - Display of data has been streamlined a little bit - An option has been added to the "Basket group" dropdown for adding a new group - Markup has been corrected for validity and consistency -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6818 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6074|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-04 21:43:36 UTC --- Created attachment 6215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6215 Fix for Bug 6818 - acquisitions basket groups could use some design work I've made changes to the basket grouping interface to bring it in line with other interfaces in Koha. I think it's better to keep things following a consistent pattern. On the page which lists basket groups: - Basket groups listed in a table instead of as custom-styled lists - Buttons use standard style - Tabs are generated by jQuery On the page for managing baskets in a group: - Markup has been revised to be more consistent with established patterns. - Corrections have been made for validity On the basket view page: - Display of data has been streamlined a little bit - An option has been added to the "Basket group" dropdown for adding a new group - Markup has been corrected for validity and consistency Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> 1) Basket group page The blue is gone and the new buttons are much better readable than before. 2) Basket grouping page Works. 3) Basket view page I like the new option to create a new group from here. Nice improvement to the workflow! I removed a spare 'td' from line 264. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6215|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-04 21:44:39 UTC --- Created attachment 6216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6216 Fix for Bug 6818 - acquisitions basket groups could use some design work I've made changes to the basket grouping interface to bring it in line with other interfaces in Koha. I think it's better to keep things following a consistent pattern. On the page which lists basket groups: - Basket groups listed in a table instead of as custom-styled lists - Buttons use standard style - Tabs are generated by jQuery On the page for managing baskets in a group: - Markup has been revised to be more consistent with established patterns. - Corrections have been made for validity On the basket view page: - Display of data has been streamlined a little bit - An option has been added to the "Basket group" dropdown for adding a new group - Markup has been corrected for validity and consistency Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> 1) Basket group page The blue is gone and the new buttons are much better readable than before. 2) Basket grouping page Works. 3) Basket view page I like the new option to create a new group from here. Nice improvement to the workflow! I removed a spare 'td' from line 264. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6818 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Signed Off |Patch Pushed --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-08 16:40:07 UTC --- QA comment: * templates still passing tests : prove xt/author/valid-templates.t says xt/author/valid-templates.t .. ok All tests successful. Files=1, Tests=672, 38 wallclock secs ( 0.31 usr 0.01 sys + 36.97 cusr 0.50 csys = 37.79 CPU) Result: PASS * template only markup * there was a tiny merge conflict I solved (an added empty line) passed QA Patch pushed, please test Chris_n = no change in the workflow, but important changes in the design (for more consistency though). I would not object any decision (merging in 3.6 or no), both are debatable -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6818 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Included in 3.6 prior to 3.6.5. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org