[Bug 6914] New: koha_perl_deps.pl color option changes user's shell prompt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6914 Bug #: 6914 Summary: koha_perl_deps.pl color option changes user's shell prompt Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: Linux Status: NEW Severity: minor Priority: P5 Component: Installation and upgrade (command-line installer) AssignedTo: gmcharlt@gmail.com ReportedBy: gbarniskis@gmail.com QAContact: koha-bugs@lists.koha-community.org This is a repeatable bug on a stock Debian squeeze fresh install with default Terminal settings (black text on white background). Simply run perl koha_perl_deps.pl -a -c The script's assertion of 'bold white' affects the Terminal shell prompt, which on default Terminal settings makes it white on white, a.k.a. suboptimal. A correction is proposed in two parts. First, use blue not white for the header and footer, as this should render fine for both default Terminal settings and for those workers who prefer light text on a dark background. Second, at the end of the utility we should return the shell to the condition we found it in regardless of report color settings. This seems to do it: print color 'reset' if $color; I will submit a patch shortly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6914 --- Comment #1 from Greg Barniskis <gbarniskis@gmail.com> 2011-09-25 23:31:20 UTC --- Created attachment 5584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5584 proposed 6914 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6914 Greg Barniskis <gbarniskis@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6914 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6914 Greg Barniskis <gbarniskis@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5584|0 |1 is obsolete| | --- Comment #2 from Greg Barniskis <gbarniskis@gmail.com> 2011-09-26 15:09:48 UTC --- Comment on attachment 5584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5584 proposed 6914 patch The first patch file attached here (2011-09-25 23:31 UTC) is flawed because I was more intent on learning git commands and work flow than the code. The 'reset' should be after the footer print line. Sorry, I will send a corrected patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6914 --- Comment #3 from Greg Barniskis <gbarniskis@gmail.com> 2011-09-26 16:26:41 UTC --- Created attachment 5591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5591 patch attempt 2 with correct ordering of the color reset -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6914 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5591|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-02 07:43:31 UTC --- Created attachment 6511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6511 Bug 6914 - fixes for the color option of koha_perl_deps.pl Reset the terminal color mode after reporting (to avoid polluting the user's shell), and use blue instead of white for the report header and footer. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6914 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6914 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #5 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-02 13:51:06 UTC --- affects koha_perl_deps.pl only, which is primarily only used turning install or trouble shooting. just changes colors, which are entirely cosmetic. Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6914 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-03 06:48:27 UTC --- patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6914 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Included in 3.6 prior to 3.6.5. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org