[Bug 19838] New: Add system preference for adding text to self registration form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 Bug ID: 19838 Summary: Add system preference for adding text to self registration form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Some libraries would like to add some explanations to the self registration form. At the moment there is only a system preference for the page that shows after submitting the registration form. It would be helpful to have another that shows on the self registration form itself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com --- Comment #1 from Lisette Scheer <lisetteslatah@gmail.com> --- This would be very helpful. Lisette -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 Michael Adamyk <madamyk@ckls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk@ckls.org --- Comment #2 from Michael Adamyk <madamyk@ckls.org> --- Katrin, thanks for reporting this. I just ran into this issue myself, and it would be a very helpful feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 116618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116618&action=edit Bug 19838: Add customizable self registration instructions to Koha news Test plan: 1. Apply patch 2. Go to /cgi-bin/koha/tools/koha-news.pl and create 'New entry' with a dsiplay location of SelfRegistrationInstructions 3. On the OPAC go to the self registration page 4. Your new content should be there. 5. Go back to the news tool and again edit the SelfRegistrationInstructions, try to set the library to something other than 'All libraries', you should not be able to. SelfRegistrationInstructions cannot be branch specific. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- I am assuming this should be in the News instead of as a system preference, although there is a problem with being able to select branch specific here. One cannot be logged into a branch while also self registering. Added some JS to not allow a branch choice for this specific piece of content. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #5 from Séverine Queune <severine.queune@bulac.fr> --- (In reply to Lucas Gass from comment #4)
I am assuming this should be in the News instead of as a system preference, although there is a problem with being able to select branch specific here.
Hi Lucas ! I don't completely agreed with that point, I think this feature should be branch specific but only available for the branches filled in PatronSelfRegistrationLibraryList. There can be some important informations a branch would like to display for future patrons, whereas the other doesn't, for example (before Covid times), the BULAC was open to anyone more than 15 it's our side "public library"), but our partner the Maison de l'Asie was only accessible for graduate students, teachers and researchers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #6 from Lisette Scheer <lisetteslatah@gmail.com> --- (In reply to Séverine Queune from comment #5)
(In reply to Lucas Gass from comment #4)
I am assuming this should be in the News instead of as a system preference, although there is a problem with being able to select branch specific here.
Hi Lucas ! I don't completely agreed with that point, I think this feature should be branch specific but only available for the branches filled in PatronSelfRegistrationLibraryList. There can be some important informations a branch would like to display for future patrons, whereas the other doesn't, for example (before Covid times), the BULAC was open to anyone more than 15 it's our side "public library"), but our partner the Maison de l'Asie was only accessible for graduate students, teachers and researchers.
Agreed, it would be helpful if the different news could show up when a patron selected their home branch as different libraries in a system might also have different instructions for what they need a patron to bring in to get their physical card. For example one of the libraries in our consortium is mailing a card to everyone who self registers and are in the service area, but we are not. Being able to provide that kind of information on a branch by branch basis would be very helpful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Séverine and Lisette, I do not disagree with you at all, branch specific self reg instructions would be best. The problem with self registration is that the patron cannot be identified as belonging to any particular branch until after they have registered and selected a branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #8 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- We're a single site library so we hide the home branch since there's only one and it doesn't make sense for the patron to have to select it or even see it. But I can see how helpful it would be to have branch specific self reg instructions for larger libraries and consortiums. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think then we would have to switch the text every time the library pull down is changed by the patron registering. This "on the fly" kind of change is not how the news system works currently, so I really feel it's out of scope here. But you could possibly get that effect with some additionally jQuery. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe it could be an option to have a library specific text on the page that you get to after successful submission of the form? Then we know the library they registered for and could display "next steps" or "what's happening next". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- I'm marking this Failed QA because it won't work with the switch from News to Additional contents. However based on the discussion so far I'm not sure this works the way everyone needs it to. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- The only way I can see this working, for branch specific instructions, is to display the instructions after the user has registered and we know which branch they are associated with. But I'm not sure that is a solution that everyone would like as it cannot provide instructions that would help the user complete the form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- *** Bug 25100 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 31293 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #9)
I think then we would have to switch the text every time the library pull down is changed by the patron registering. This "on the fly" kind of change is not how the news system works currently, so I really feel it's out of scope here. But you could possibly get that effect with some additionally jQuery.
I agree about branch-specific text being out of scope, as it would require additional enhancements. I think one could achieve the goal by putting multiple text blocks in the "All libraries" entry with a visibility of none, and then toggling between them based on the library pull down. I've inserted self-registration text for quite a few libraries now, and it's always the same text for all branches. I think this would probably be the most common scenario, since typically you register for the system rather than just a branch. I think atypical scenarios could use a Jquery based solution or create further enhancements. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas@bywatersolutions.com |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116618|0 |1 is obsolete| | --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 190837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190837&action=edit Bug 19838: Add customizable self registration instructions to Koha news Test plan: 1. Apply patch 2. Go to Tools -> HTML customizations and create 'New entry' with a dsiplay location of SelfRegistrationInstructions 3. On the OPAC go to the self registration page 4. Your new content should be there. 5. Go back to HTML customizations and edit your SelfRegistrationInstructions entry, try to set the library to something other than 'All libraries', you should not be able to. SelfRegistrationInstructions cannot be branch specific. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 190838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190838&action=edit Bug 19838: (follow-up) Adapting to additional contents Also fixing enabling/disabling of library input -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add system preference for |Add HTML customization for |adding text to self |adding text to self |registration form |registration form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190837|0 |1 is obsolete| | --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 190857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190857&action=edit Bug 19838: Add customizable self registration instructions to Koha news Test plan: 1. Apply patch 2. Go to Tools -> HTML customizations and create 'New entry' with a dsiplay location of SelfRegistrationInstructions 3. On the OPAC go to the self registration page 4. Your new content should be there. 5. Go back to HTML customizations and edit your SelfRegistrationInstructions entry, try to set the library to something other than 'All libraries', you should not be able to. SelfRegistrationInstructions cannot be branch specific. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190838|0 |1 is obsolete| | --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 190858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190858&action=edit Bug 19838: (follow-up) Adapting to additional contents Also fixing enabling/disabling of library input Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add HTML customization for |Add HTML customization for |adding text to self |adding text to |registration form |self-registration form Text to go in the| |You can now add custom text release notes| |to the OPAC patron | |self-registration form | |using the | |SelfRegistrationInstruction | |s display location in HTML | |customizations. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from David Cook <dcook@prosentient.com.au> --- Like bug 39860 and bug 40659, this should be using a scrubber profile to protect against XSS vulnerabilities. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 Michael Adamyk <michael.adamyk@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.adamyk@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Cook from comment #20)
Like bug 39860 and bug 40659, this should be using a scrubber profile to protect against XSS vulnerabilities.
Sounds like we need a new coding guideline. David could you write up something to add to the next dev meeting? A follow-up patch here would be a great way to provide an example ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Owen Leonard from comment #21)
(In reply to David Cook from comment #20)
Like bug 39860 and bug 40659, this should be using a scrubber profile to protect against XSS vulnerabilities.
Sounds like we need a new coding guideline. David could you write up something to add to the next dev meeting? A follow-up patch here would be a great way to provide an example ;)
Yes, we do need a new coding guideline. If we do so, we should also file a bug and make sure all older HTML customization's get scrubbed, IMO. In doing so we can perhaps standardize some of the scrubber profiles? We currently have 3. One for 'note' which allows the following HTML tags: br b i em big small strong u hr span div p ol ul li dl dt dd One for 'comment' which allows: br b i em big small strong And one for "record_display" for Bug 39860, it is the most permissive one, allowing classes, IDs, and much more HTML: div span h1 h2 h3 h4 h5 h6 p br ul ol li dl dt dd a img strong b em i u s strike del ins sup sub blockquote cite q abbr acronym dfn table thead tbody tfoot tr td th caption pre code kbd samp var hr address Do we need to come up with a general profile that can be used for all HTML customization? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #23 from David Cook <dcook@prosentient.com.au> --- (In reply to Lucas Gass (lukeg) from comment #22)
(In reply to Owen Leonard from comment #21)
(In reply to David Cook from comment #20)
Like bug 39860 and bug 40659, this should be using a scrubber profile to protect against XSS vulnerabilities.
Sounds like we need a new coding guideline. David could you write up something to add to the next dev meeting? A follow-up patch here would be a great way to provide an example ;)
Yes, we do need a new coding guideline.
100% need a new coding guideline. People talk about adding things to dev meetings but I have no idea how that's done. Is there a person to send it to, somewhere to put it, or something else? I can't make it to dev meetings which makes it extra hard I think.
Do we need to come up with a general profile that can be used for all HTML customization?
I don't think that's 100% possible, as different contexts can require different restrictions. The one I bump into the most locally is content that gets added into DataTables. If you allow tables into the HTML that's added into DataTables, things can bust. But then there's other places like OpacMainUserBlock where maybe you do want to allow tables. But it's not always clear what's going to end up in a DataTable as sometimes it might just be shown on a regular page. I don't have a good answer for that yet... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42047 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #24 from Lisette Scheer <lisette@bywatersolutions.com> --- (In reply to David Cook from comment #23)
100% need a new coding guideline. People talk about adding things to dev meetings but I have no idea how that's done. Is there a person to send it to, somewhere to put it, or something else? I can't make it to dev meetings which makes it extra hard I think.
You can do a draft on wiki.koha-community.org/wiki/Coding_Guidelines and then add to the wiki page for the next meeting https://wiki.koha-community.org/wiki/Development_IRC_meeting_15_April_2026 It might be helpful to also a post in the mattermost so people can ask you questions in advance. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #25 from David Cook <dcook@prosentient.com.au> --- (In reply to Lisette Scheer from comment #24)
(In reply to David Cook from comment #23)
100% need a new coding guideline. People talk about adding things to dev meetings but I have no idea how that's done. Is there a person to send it to, somewhere to put it, or something else? I can't make it to dev meetings which makes it extra hard I think.
You can do a draft on wiki.koha-community.org/wiki/Coding_Guidelines and then add to the wiki page for the next meeting https://wiki.koha-community.org/wiki/Development_IRC_meeting_15_April_2026
It might be helpful to also a post in the mattermost so people can ask you questions in advance.
I'm too late for the next dev meeting but I've created "[DRAFT] SEC2: HTML entered by users must be scrubbed before displaying on the UI" on https://wiki.koha-community.org/wiki/Coding_Guidelines I'll post about it on Mattermost as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190857|0 |1 is obsolete| | Attachment #190858|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 208190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208190&action=edit Bug 19838: Add customizable self registration instructions to Koha news Test plan: 1. Apply patch 2. Go to Tools -> HTML customizations and create 'New entry' with a dsiplay location of SelfRegistrationInstructions 3. On the OPAC go to the self registration page 4. Your new content should be there. 5. Go back to HTML customizations and edit your SelfRegistrationInstructions entry, try to set the library to something other than 'All libraries', you should not be able to. SelfRegistrationInstructions cannot be branch specific. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 208191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208191&action=edit Bug 19838: (follow-up) Add 'note' type scrubber filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208190|0 |1 is obsolete| | Attachment #208191|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #28 from David Nind <david@davidnind.com> --- Created attachment 208427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208427&action=edit Bug 19838: Add customizable self registration instructions to Koha news Test plan: 1. Apply patch 2. Go to Tools -> HTML customizations and create 'New entry' with a dsiplay location of SelfRegistrationInstructions 3. On the OPAC go to the self registration page 4. Your new content should be there. 5. Go back to HTML customizations and edit your SelfRegistrationInstructions entry, try to set the library to something other than 'All libraries', you should not be able to. SelfRegistrationInstructions cannot be branch specific. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #29 from David Nind <david@davidnind.com> --- Created attachment 208428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208428&action=edit Bug 19838: (follow-up) Add 'note' type scrubber filter Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #30 from David Nind <david@davidnind.com> --- Created attachment 208429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208429&action=edit Bug 19838: (follow-up) Terminology - self-registration Changed "self registration" to "self-registration", as per the terminology guidelines. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|You can now add custom text |You can now add custom text release notes|to the OPAC patron |to the OPAC patron |self-registration form |self-registration form |using the |using the |SelfRegistrationInstruction |SelfRegistrationInstruction |s display location in HTML |s display location in HTML |customizations. |customizations (the text | |applies for "All | |libraries", and can't be | |set for individual | |libraries). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 210314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210314&action=edit Bug 19838: (QA follow-up) Fix punctuation in hint text -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208427|0 |1 is obsolete| | Attachment #208428|0 |1 is obsolete| | Attachment #208429|0 |1 is obsolete| | Attachment #210314|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 210315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210315&action=edit Bug 19838: Add customizable self registration instructions to Koha news Test plan: 1. Apply patch 2. Go to Tools -> HTML customizations and create 'New entry' with a dsiplay location of SelfRegistrationInstructions 3. On the OPAC go to the self registration page 4. Your new content should be there. 5. Go back to HTML customizations and edit your SelfRegistrationInstructions entry, try to set the library to something other than 'All libraries', you should not be able to. SelfRegistrationInstructions cannot be branch specific. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 210316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210316&action=edit Bug 19838: (follow-up) Add 'note' type scrubber filter Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 210317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210317&action=edit Bug 19838: (follow-up) Terminology - self-registration Changed "self registration" to "self-registration", as per the terminology guidelines. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 210318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210318&action=edit Bug 19838: (QA follow-up) Fix punctuation in hint text Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Status|Signed Off |Passed QA --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Did some tiny follow-up - moving the punctuation . outside the quotes here: +<div id="SelfRegistrationInstructions_notes" class="hint customization_note"> Show this content above the OPAC self-registration form. This cannot be added on a per-library basis, only for "All libraries." </div> ... and realized I filed this bug myself in 2017. Thanks for picking it up! :) I notice that it's not possible to add a link to the HTML customization because of the scrubber profile used. Could we switch the profile to one less restrictive? I think adding a link to the libraries terms of use or similar would be a very common use case here. I am still going to Pass QA here given that this is a new feature and we could move the profile to a separate bug or quick follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, I dug a little deeper and since this change seems to apply to ALL HTML customizations in the OPAC we can't leave it like that. :( 1) We absolutely need a more permissive scrubber profile including links and tables and such so that we don't break people's implementations. We also do have search forms for new acq titles (creating an OPAC search) and such in our HTML customizations. 2) This breaks all pages using HTML customizations but the self-reg I believe. For a quick test: Turn on CookieConsent in the system preferences. The OPAC explodes into: Template process failed: undef error - scrub_html: filter not found at /kohadevbox/koha/C4/Templates.pm line 146 Maybe we should drop the scrubber requirement from this patch set and resolve it separately? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org