[Bug 38984] New: DataTables's columnDefs cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Bug ID: 38984 Summary: DataTables's columnDefs cleanup Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 26553 We don't need to have a columnDefs for NoSort or anti-the, they are already defined in the global datatables.js Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26553 [Bug 26553] Remove KohaTable (columns_settings.inc) and use kohaTable (datatables.js) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177253&action=edit Bug 38984: Remove NoSort def No need to pass it to the constructor as it's defined already in datatables.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177254&action=edit Bug 38984: Replace nosort with NoSort We don't need nosort and NoSort, use NoSort everywhere -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177255&action=edit Bug 38984: Remove anti-the Same as previouly for anti-the -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177256&action=edit Bug 38984: Add NoSort when can replace targets In those occurrences we can simply use NoSort. It fixes some bugs, where the display of the column depends on some pref's values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177257&action=edit Bug 38984: Allow sort on all fields - club-enrollments it does not make sense to remove sorting only for the last 2 fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177258&action=edit Bug 38984: Also make 'Actions' translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177259&action=edit Bug 38984: Specific - tools/batch_extend_due_dates.tt Why no sort on item type? Why no sort on #checkouts_result? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Also tempted to rename NoSort with no-sort and NoExport with no-export, to match string-sort, anti-the, etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #8)
Also tempted to rename NoSort with no-sort and NoExport with no-export, to match string-sort, anti-the, etc.
And it's "noExport"... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177256|0 |1 is obsolete| | Attachment #177257|0 |1 is obsolete| | Attachment #177258|0 |1 is obsolete| | Attachment #177259|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177278&action=edit Bug 38984: Add NoSort when can replace targets In those occurrences we can simply use NoSort. It fixes some bugs, where the display of the column depends on some pref's values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177279&action=edit Bug 38984: Allow sort on all fields - club-enrollments it does not make sense to remove sorting only for the last 2 fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177280&action=edit Bug 38984: Also make 'Actions' translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177281&action=edit Bug 38984: Specific - tools/batch_extend_due_dates.tt Why no sort on item type? Why no sort on #checkouts_result? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39015 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39015 [Bug 39015] Date sorting not working in statistics wizards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177280|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177597&action=edit Bug 38984: Also make 'Actions' translatable Current status: Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177281|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177598&action=edit Bug 38984: Specific - tools/batch_extend_due_dates.tt Why no sort on item type? Why no sort on #checkouts_result? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177253|0 |1 is obsolete| | Attachment #177254|0 |1 is obsolete| | Attachment #177255|0 |1 is obsolete| | Attachment #177278|0 |1 is obsolete| | Attachment #177279|0 |1 is obsolete| | Attachment #177597|0 |1 is obsolete| | Attachment #177598|0 |1 is obsolete| | --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177641&action=edit Bug 38984: Remove NoSort def No need to pass it to the constructor as it's defined already in datatables.js Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177642&action=edit Bug 38984: Replace nosort with NoSort We don't need nosort and NoSort, use NoSort everywhere Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177643&action=edit Bug 38984: Remove anti-the Same as previouly for anti-the Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177644&action=edit Bug 38984: Add NoSort when can replace targets In those occurrences we can simply use NoSort. It fixes some bugs, where the display of the column depends on some pref's values Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177645&action=edit Bug 38984: Allow sort on all fields - club-enrollments it does not make sense to remove sorting only for the last 2 fields Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177646&action=edit Bug 38984: Also make 'Actions' translatable Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177647&action=edit Bug 38984: Specific - tools/batch_extend_due_dates.tt Why no sort on item type? Why no sort on #checkouts_result? Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177648&action=edit Bug 38984: (follow-up) Fix syntax error in invoice-files table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177649&action=edit Bug 38984: (follow-up) Fix nosort class on first column Changing "nosort" to "NoSort". Also adding an "order" option to the table configuration so that the table isn't sorted by default on the first column (overriding the NoSort option). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177651&action=edit Bug 38984: (follow-up) Replace obsolete "paginate" option with "paging" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177641|0 |1 is obsolete| | Attachment #177642|0 |1 is obsolete| | Attachment #177643|0 |1 is obsolete| | Attachment #177644|0 |1 is obsolete| | Attachment #177645|0 |1 is obsolete| | Attachment #177646|0 |1 is obsolete| | Attachment #177647|0 |1 is obsolete| | Attachment #177648|0 |1 is obsolete| | Attachment #177649|0 |1 is obsolete| | Attachment #177651|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177933&action=edit Bug 38984: Remove NoSort def No need to pass it to the constructor as it's defined already in datatables.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177934&action=edit Bug 38984: Replace nosort with NoSort We don't need nosort and NoSort, use NoSort everywhere -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177935&action=edit Bug 38984: Remove anti-the Same as previouly for anti-the -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177936&action=edit Bug 38984: Add NoSort when can replace targets In those occurrences we can simply use NoSort. It fixes some bugs, where the display of the column depends on some pref's values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177937&action=edit Bug 38984: Allow sort on all fields - club-enrollments it does not make sense to remove sorting only for the last 2 fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #31 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177938&action=edit Bug 38984: Also make 'Actions' translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #32 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177939&action=edit Bug 38984: Specific - tools/batch_extend_due_dates.tt Why no sort on item type? Why no sort on #checkouts_result? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #33 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177940&action=edit Bug 38984: (follow-up) Fix syntax error in invoice-files table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #34 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177941&action=edit Bug 38984: (follow-up) Fix nosort class on first column Changing "nosort" to "NoSort". Also adding an "order" option to the table configuration so that the table isn't sorted by default on the first column (overriding the NoSort option). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #35 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177942&action=edit Bug 38984: (follow-up) Replace obsolete "paginate" option with "paging" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com CC| |baptiste.wojtkowski@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|baptiste.wojtkowski@biblibr |testopia@bugs.koha-communit |e.com |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177933|0 |1 is obsolete| | Attachment #177934|0 |1 is obsolete| | Attachment #177935|0 |1 is obsolete| | Attachment #177936|0 |1 is obsolete| | Attachment #177937|0 |1 is obsolete| | Attachment #177938|0 |1 is obsolete| | Attachment #177939|0 |1 is obsolete| | Attachment #177940|0 |1 is obsolete| | Attachment #177941|0 |1 is obsolete| | Attachment #177942|0 |1 is obsolete| | --- Comment #36 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179057&action=edit Bug 38984: Remove NoSort def No need to pass it to the constructor as it's defined already in datatables.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #37 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179058&action=edit Bug 38984: Replace nosort with NoSort We don't need nosort and NoSort, use NoSort everywhere -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #38 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179059&action=edit Bug 38984: Remove anti-the Same as previouly for anti-the -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #39 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179060&action=edit Bug 38984: Add NoSort when can replace targets In those occurrences we can simply use NoSort. It fixes some bugs, where the display of the column depends on some pref's values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #40 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179061&action=edit Bug 38984: Allow sort on all fields - club-enrollments it does not make sense to remove sorting only for the last 2 fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #41 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179062&action=edit Bug 38984: Also make 'Actions' translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #42 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179063&action=edit Bug 38984: Specific - tools/batch_extend_due_dates.tt Why no sort on item type? Why no sort on #checkouts_result? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #43 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179064&action=edit Bug 38984: (follow-up) Fix syntax error in invoice-files table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #44 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179065&action=edit Bug 38984: (follow-up) Fix nosort class on first column Changing "nosort" to "NoSort". Also adding an "order" option to the table configuration so that the table isn't sorted by default on the first column (overriding the NoSort option). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #45 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179066&action=edit Bug 38984: (follow-up) Replace obsolete "paginate" option with "paging" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #46 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I'd love to also see the suggested NoSort -> no-sort and NoExport to no-export change.. that would be nice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #47 from Jonathan Druart <jonathan.druart@gmail.com> --- We are missing noExport from datatables.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #48 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #47)
We are missing noExport from datatables.js
Forget that, it's something else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #49 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 180303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180303&action=edit Bug 38984: Uniformize noSort NoExport NoExport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179057|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180356&action=edit Bug 38984: Remove NoSort def No need to pass it to the constructor as it's defined already in datatables.js Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179058|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180357&action=edit Bug 38984: Replace nosort with NoSort We don't need nosort and NoSort, use NoSort everywhere Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179059|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180358&action=edit Bug 38984: Remove anti-the Same as previouly for anti-the Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179060|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180359&action=edit Bug 38984: Add NoSort when can replace targets In those occurrences we can simply use NoSort. It fixes some bugs, where the display of the column depends on some pref's values Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179061|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180360&action=edit Bug 38984: Allow sort on all fields - club-enrollments it does not make sense to remove sorting only for the last 2 fields Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179062|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180361&action=edit Bug 38984: Also make 'Actions' translatable Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179063|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180362&action=edit Bug 38984: Specific - tools/batch_extend_due_dates.tt Why no sort on item type? Why no sort on #checkouts_result? Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179064|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180363&action=edit Bug 38984: (follow-up) Fix syntax error in invoice-files table Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179065|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180364&action=edit Bug 38984: (follow-up) Fix nosort class on first column Changing "nosort" to "NoSort". Also adding an "order" option to the table configuration so that the table isn't sorted by default on the first column (overriding the NoSort option). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179066|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180365&action=edit Bug 38984: (follow-up) Replace obsolete "paginate" option with "paging" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180303|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180366&action=edit Bug 38984: Uniformize noSort NoExport NoExport Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #61 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for the tidy up here Jonathan :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply Version|unspecified |Main --- Comment #62 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you please rebase? There is a conflict in sco-main I am not sure about. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180356|0 |1 is obsolete| | Attachment #180357|0 |1 is obsolete| | Attachment #180358|0 |1 is obsolete| | Attachment #180359|0 |1 is obsolete| | Attachment #180360|0 |1 is obsolete| | Attachment #180361|0 |1 is obsolete| | Attachment #180362|0 |1 is obsolete| | Attachment #180363|0 |1 is obsolete| | Attachment #180364|0 |1 is obsolete| | Attachment #180365|0 |1 is obsolete| | Attachment #180366|0 |1 is obsolete| | --- Comment #63 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181021&action=edit Bug 38984: Remove NoSort def No need to pass it to the constructor as it's defined already in datatables.js Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #64 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181022&action=edit Bug 38984: Replace nosort with NoSort We don't need nosort and NoSort, use NoSort everywhere Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #65 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181023&action=edit Bug 38984: Remove anti-the Same as previouly for anti-the Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #66 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181024&action=edit Bug 38984: Add NoSort when can replace targets In those occurrences we can simply use NoSort. It fixes some bugs, where the display of the column depends on some pref's values Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #67 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181025&action=edit Bug 38984: Allow sort on all fields - club-enrollments it does not make sense to remove sorting only for the last 2 fields Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #68 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181026&action=edit Bug 38984: Also make 'Actions' translatable Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #69 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181027&action=edit Bug 38984: Specific - tools/batch_extend_due_dates.tt Why no sort on item type? Why no sort on #checkouts_result? Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #70 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181028&action=edit Bug 38984: (follow-up) Fix syntax error in invoice-files table Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #71 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181029&action=edit Bug 38984: (follow-up) Fix nosort class on first column Changing "nosort" to "NoSort". Also adding an "order" option to the table configuration so that the table isn't sorted by default on the first column (overriding the NoSort option). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #72 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181030&action=edit Bug 38984: (follow-up) Replace obsolete "paginate" option with "paging" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #73 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181031&action=edit Bug 38984: Uniformize noSort NoExport NoExport Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #74 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe we could add a little summary for devs on what to use when now? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #75 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #76 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #74)
Maybe we could add a little summary for devs on what to use when now?
I've done a little updating to this page: https://wiki.koha-community.org/wiki/DataTables_HowTo. There's probably more to be done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #77 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #76)
(In reply to Katrin Fischer from comment #74)
Maybe we could add a little summary for devs on what to use when now?
I've done a little updating to this page: https://wiki.koha-community.org/wiki/DataTables_HowTo. There's probably more to be done.
That's awesome thanks :) Wondering if we can delete this line and fix the file name? WARNING: H::T::P has been dropped from the official codebase so what follows is not applicable to current coding standards... you have been warned. koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/issues.tmpl: -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 --- Comment #78 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #77)
(In reply to Owen Leonard from comment #76)
(In reply to Katrin Fischer from comment #74)
Maybe we could add a little summary for devs on what to use when now?
I've done a little updating to this page: https://wiki.koha-community.org/wiki/DataTables_HowTo. There's probably more to be done.
That's awesome thanks :)
Wondering if we can delete this line and fix the file name?
WARNING: H::T::P has been dropped from the official codebase so what follows is not applicable to current coding standards... you have been warned.
koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/issues.tmpl:
Yes, and add an "OBSOLETE" flag at the top of the page as well... It needs to be rewritten. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #79 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 26553 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38984 Bug 38984 depends on bug 26553, which changed state. Bug 26553 Summary: Remove KohaTable (columns_settings.inc) and use kohaTable (datatables.js) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26553 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org