[Bug 9786] New: Holds to pull showing items not available
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 Bug ID: 9786 Summary: Holds to pull showing items not available Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com CC: gmcharlt@gmail.com If an item is on hold and waiting for pickup, and another hold is placed on the record, a hold to pull will show in the Holds to pull report, even though there are no items that can fill that hold request! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |liz@catalyst.net.nz --- Comment #1 from Liz Rea <liz@catalyst.net.nz> --- I was unable to replicate this on master - perhaps you have something else going on? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 --- Comment #2 from Liz Rea <liz@catalyst.net.nz> --- To be clear - here is what I did I had an bib with two items. I placed and filled two holds, both were marked waiting. I then placed a third hold, and ran the "holds to pull" report. The bib was not on the list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.8 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Indeed, this appears to be working in master. I discovered it in 3.8.5 I believe. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- I checked the version having this bug, it's 3.8.8. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16066&action=edit Bug 9786 - Holds to pull showing items not available If an item is on hold and waiting for pickup, and another hold is placed on the record, a hold to pull will show in the Holds to pull report, even though there are no items that can fill that hold request. Test Plan: 1) Create a record with 1 item 2) Create 2 holds on the record 3) Fill the first hold 4) Check the Holds to pull report, it should show this record 5) Apply patch 6) Reload the Holds to pull report, it should no longer show this record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Have you checked the bug is still present in 3.8.x (3.8.11 is due to be released in 9 days .. 3.8.8 is nearly 3 months old) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16066|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16088&action=edit Bug 9786 - Holds to pull showing items not available If an item is on hold and waiting for pickup, and another hold is placed on the record, a hold to pull will show in the Holds to pull report, even though there are no items that can fill that hold request. Test Plan: 1) Create a record with 1 item 2) Create 2 holds on the record 3) Fill the first hold 4) Check the Holds to pull report, it should show this record 5) Apply patch 6) Reload the Holds to pull report, it should no longer show this record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Yes, this bug appears to be present in 3.8.x (In reply to comment #6)
Have you checked the bug is still present in 3.8.x (3.8.11 is due to be released in 9 days .. 3.8.8 is nearly 3 months old)
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- I can't reproduce this bug in 3.8.x. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 --- Comment #10 from Liz Rea <liz@catalyst.net.nz> --- Out of curiosity - in the DB where you see this bug, is the item perhaps in transit instead of waiting? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 Corinne BULAC <corinnebulac@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |corinnebulac@gmail.com --- Comment #11 from Corinne BULAC <corinnebulac@gmail.com> --- Sandbox setup by corinne.hayet@bulac.fr with database 2 and bug 9786 on Thu Mar 21 09:44:59 2013 Something went wrong ! Applying: Bug 9786 - Holds to pull showing items not available Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging circ/pendingreserves.pl CONFLICT (content): Merge conflict in circ/pendingreserves.pl Failed to merge in the changes. Patch failed at 0001 Bug 9786 - Holds to pull showing items not available When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 9786 - Holds to pull showing items not available Bug 9786 - Holds to pull showing items not available Apply? [yn] Patch left in /tmp/Bug-9786---Holds-to-pull-showing-items-not-availab-HpPDSE.pat -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |m.de.rooy@rijksmuseum.nl --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #11)
Sandbox setup by corinne.hayet@bulac.fr with database 2 and bug 9786 on Thu Mar 21 09:44:59 2013 Something went wrong ! Applying: Bug 9786 - Holds to pull showing items not available Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging circ/pendingreserves.pl CONFLICT (content): Merge conflict in circ/pendingreserves.pl Failed to merge in the changes. Patch failed at 0001 Bug 9786 - Holds to pull showing items not available When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 9786 - Holds to pull showing items not available
Bug 9786 - Holds to pull showing items not available Apply? [yn] Patch left in /tmp/Bug-9786---Holds-to-pull-showing-items-not-availab-HpPDSE.pat
This seems to be for 3.8. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16088|0 |1 is obsolete| | --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 16589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16589&action=edit Bug 9786 - Holds to pull showing items not available If an item is on hold and waiting for pickup, and another hold is placed on the record, a hold to pull will show in the Holds to pull report, even though there are no items that can fill that hold request. Test Plan: 1) Create a record with 1 item 2) Create 2 holds on the record 3) Fill the first hold 4) Check the Holds to pull report, it should show this record 5) Apply patch 6) Reload the Holds to pull report, it should no longer show this record Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Holds to pull showing items |[3.8.X] Holds to pull |not available |showing items not available -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Setting this to Passed QA, but you will just have to attract the attention of the RMaint for 3.8.X to get this pushed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I stumbled over this in 3.8.3. The line for waiting items was missing there. Seems hard to reproduce under the latest 3.8.X, but the test for found is not null will do no harm.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9786 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.12 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org