[Bug 5648] New: icons clumping together
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 Summary: icons clumping together Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 When choosing icons for item types or authorized values the icons appear in alpha order in rows, however if the icon set has icons in multiple sizes (as three of our sets do) then the rows get all scattered and the icons look clumped together. I'd like to see a better style here that keeps the icons in neat rows. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2011-01-22 13:15:00 UTC --- Created attachment 3016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3016 example of messy view -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 --- Comment #2 from Jen Zajac <jen@catalyst.net.nz> --- Created attachment 16842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16842&action=edit Patch file -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 Jen Zajac <jen@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jen@catalyst.net.nz Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 --- Comment #3 from Jen Zajac <jen@catalyst.net.nz> --- Created attachment 16844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16844&action=edit screenshot with patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 Frederic Durand <frederic.durand@unilim.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic.durand@unilim.fr --- Comment #4 from Frederic Durand <frederic.durand@unilim.fr> --- Working fine when you're choosing icons for item types. Not apply when you are modifying authorized values and you want to choose icons for them (in admin-->authorised values). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 Frederic Durand <frederic.durand@unilim.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Hmm, setting this back to needs signoff, as it does fix a problem, causes no regressions, and a follow up could be sent to address the icons in authorised values. Let's encourage our new developers, not dishearten them -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Upgrading to bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|minor |enhancement --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree with Chris and Jared - they just beat me to add a comment :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Re-upgrading to bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Oh, I didn't intent to change back to enh - glad you spotted it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 --- Comment #10 from Frederic Durand <frederic.durand@unilim.fr> --- (En réponse au commentaire 5)
Hmm, setting this back to needs signoff, as it does fix a problem, causes no regressions, and a follow up could be sent to address the icons in authorised values.
Let's encourage our new developers, not dishearten them
It was not my goal to discourage anyone, it s more about a bad choice with bug's status, my fault, sorry for that. Will be more careful next time. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9945 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9945 | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Frederic, sorry if that came over a bit harsh - I think we should also port this fix to the authorised value page, but sometimes it's good to get a small improvement in. I have opened bug 9945 for that. Thank you for your testing :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9945 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 Frederic Durand <frederic.durand@unilim.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Small patch. It fixes an ergonomic issue. Marked as Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16842|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16971&action=edit Bug 5648: Changed display: inline to inline-block on the inline CSS styling on the li elements. Signed-off-by: Frédéric Durand <frederic.durand@unilim.fr> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. Welcome, Jen, you are the 205th committer! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5648 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x and 3.10.x will be in 3.8.12 and 3.10.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org