[Bug 39745] New: Wrong system preference 'language' in test suite
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Bug ID: 39745 Summary: Wrong system preference 'language' in test suite Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 27490 renamed system preference language to StaffInterfaceLanguages. Needs to be done in test suite selenium tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27490 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 [Bug 27490] Rename system preference language to StaffInterfaceLanguages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39720 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 [Bug 39720] Search for system preferences call errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |fridolin.somers@biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 181494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181494&action=edit Bug 39745: Wrong system preference 'language' in test suite Bug 27490 renamed system preference language to StaffInterfaceLanguages. Needs to be done in test suite selenium tests. Also fixes 'opaclanguages' case to 'OPACLanguages' just to match the file installer/data/mysql/mandatory/sysprefs.sql Test by running selenium tests onboarding and installation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181494|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 181498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181498&action=edit Bug 39745: Fix wrong system preference 'language' in test suite (selenium) Bug 27490 renamed system preference language to StaffInterfaceLanguages. Needs to be done in test suite selenium tests. Also fixes 'opaclanguages' case to 'OPACLanguages' just to match the file installer/data/mysql/mandatory/sysprefs.sql Test by running selenium tests onboarding and installation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 181499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181499&action=edit Bug 39745: Fix wrong system preference 'language' in test suite (mock_preference) Bug 27490 renamed system preference language to StaffInterfaceLanguages. Needs to be done in test suite on mock_preference calls Test by running impacted tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181498|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 181551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181551&action=edit Bug 39745: Fix wrong system preference 'language' in test suite (selenium) Bug 27490 renamed system preference language to StaffInterfaceLanguages. Needs to be done in test suite selenium tests. Also fixes 'opaclanguages' case to 'OPACLanguages' just to match the file installer/data/mysql/mandatory/sysprefs.sql Test by running selenium tests onboarding and installation Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181499|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 181552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181552&action=edit Bug 39745: Fix wrong system preference 'language' in test suite (mock_preference) Bug 27490 renamed system preference language to StaffInterfaceLanguages. Needs to be done in test suite on mock_preference calls Test by running impacted tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes several tests so release notes| |that the correct system | |preference names are used: | |- language => | |StaffInterfaceLanguages | |(name changed in bug 27490) | | | |- opaclanguages => | |OPACLanguages (name now | |uses the correct case) CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Start up KTD with Selenium: ktd --selenium up 2. Run these test - they should pass before and after the patches: prove t/db_dependent/selenium/00-onboarding.t prove t/db_dependent/selenium/01-installation.t prove t/db_dependent/Auth.t prove t/db_dependent/Koha/ItemTypes.t prove t/db_dependent/Koha/SharedContent.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off QA Contact|katrin.fischer@bsz-bw.de | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have some confusing problem with selenium, not pushing this yet, leaving for a fresher set of eyes. Running tests (5) * Proving /kohadevbox/koha/t/db_dependent/Koha/SharedContent.t OK! * Proving /kohadevbox/koha/t/db_dependent/selenium/01-installation.t KO! STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} /usr/share/perl5/Selenium/Remote/Driver.pm:361 in Try::Tiny::try (eval 397):1 in Selenium::Remote::Driver::__ANON__ (eval 399):2 in Selenium::Remote::Driver::__ANON__ /usr/share/perl5/Selenium/Remote/Driver.pm:1340 in Selenium::Remote::Driver::_execute_command /usr/share/perl5/Selenium/Remote/Driver.pm:1340 in (eval) /kohadevbox/koha/t/lib/Selenium.pm:121 in Selenium::Remote::Driver::find_element /kohadevbox/koha/t/db_dependent/selenium/01-installation.t:93 in t::lib::Selenium::fill_form Error while executing command: no such element: Unable to locate element: //*[@id="language"] at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. at /usr/share/perl5/Selenium/Remote/Driver.pm line 356. # Looks like your test exited with 255 before it could output anything. /kohadevbox/koha/t/db_dependent/selenium/01-installation.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/2 subtests Test Summary Report ------------------- /kohadevbox/koha/t/db_dependent/selenium/01-installation.t (Wstat: 65280 (exited 255) Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 2 tests but ran 0. Files=1, Tests=0, 15 wallclock secs ( 0.01 usr 0.00 sys + 0.77 cusr 0.07 csys = 0.85 CPU) Result: FAIL * Proving /kohadevbox/koha/t/db_dependent/Koha/ItemTypes.t OK! * Proving /kohadevbox/koha/t/db_dependent/Auth.t OK! * Proving /kohadevbox/koha/t/db_dependent/selenium/00-onboarding.t KO! STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} /usr/share/perl5/Selenium/Remote/Driver.pm:361 in Try::Tiny::try (eval 397):1 in Selenium::Remote::Driver::__ANON__ (eval 399):2 in Selenium::Remote::Driver::__ANON__ /usr/share/perl5/Selenium/Remote/Driver.pm:1340 in Selenium::Remote::Driver::_execute_command /usr/share/perl5/Selenium/Remote/Driver.pm:1340 in (eval) /kohadevbox/koha/t/lib/Selenium.pm:121 in Selenium::Remote::Driver::find_element /kohadevbox/koha/t/db_dependent/selenium/00-onboarding.t:92 in t::lib::Selenium::fill_form Error while executing command: no such element: Unable to locate element: //*[@id="language"] at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. at /usr/share/perl5/Selenium/Remote/Driver.pm line 356. # Looks like your test exited with 255 before it could output anything. /kohadevbox/koha/t/db_dependent/selenium/00-onboarding.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/2 subtests Test Summary Report ------------------- /kohadevbox/koha/t/db_dependent/selenium/00-onboarding.t (Wstat: 65280 (exited 255) Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 2 tests but ran 0. Files=1, Tests=0, 13 wallclock secs ( 0.01 usr 0.00 sys + 0.77 cusr 0.06 csys = 0.84 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181551|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182103&action=edit Bug 39745: Fix wrong system preference 'language' in test suite (selenium) Bug 27490 renamed system preference language to StaffInterfaceLanguages. Needs to be done in test suite selenium tests. Also fixes 'opaclanguages' case to 'OPACLanguages' just to match the file installer/data/mysql/mandatory/sysprefs.sql Test by running selenium tests onboarding and installation Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181552|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182104&action=edit Bug 39745: Fix wrong system preference 'language' in test suite (mock_preference) Bug 27490 renamed system preference language to StaffInterfaceLanguages. Needs to be done in test suite on mock_preference calls Test by running impacted tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Selenium tests don't work for me here, do you have an idea? Error while executing command: no such element: Unable to locate element: //*[@id="language"] at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@openfifth.c |testopia@bugs.koha-communit |o.uk |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- @Martin are Selenium tests OK for you ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 --- Comment #12 from David Nind <david@davidnind.com> --- (In reply to Fridolin Somers from comment #11)
@Martin are Selenium tests OK for you ?
The tests (see comment #6) all still work for me locally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Attachment #182103|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41682 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182104|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192016&action=edit Bug 39745: Fix wrong system preference 'language' in test suite (mock_preference) Bug 27490 renamed system preference language to StaffInterfaceLanguages. Needs to be done in test suite on mock_preference calls Test by running impacted tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- I was going to open a new bug report with the exact same patch to fix check_sysprefs.t failure. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192795&action=edit Bug 39745: Replace more occurrences in selenium tests Patch from commit cea8280 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #16)
Created attachment 192795 [details] [review] Bug 39745: Replace more occurrences in selenium tests
Patch from commit cea8280
To fix Jenkins: 23:31:41 koha-1 | # Failed test at t/db_dependent/check_sysprefs.t line 165. 23:31:41 koha-1 | # Structures begin differing at: 23:31:41 koha-1 | # $got->[1] = 'language' 23:31:41 koha-1 | # $expected->[1] = 'marcflavour' 23:31:41 koha-1 | # Too many sysprefs in DB: marcflavour, Version, language 23:31:41 koha-1 | # Looks like you failed 1 test of 1754. 23:31:41 koha-1 | 23:31:41 koha-1 | # Failed test 'Compare database with sysprefs.sql file' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Follow up pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 --- Comment #19 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #20 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #21 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Nothing to change in the Koha manual for this. Feel free to reopen with more information if this is incorrect. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org