[Bug 32600] New: Housebound module needs page-section treatment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32600 Bug ID: 32600 Summary: Housebound module needs page-section treatment Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Depends on: 30952 There are a few different sections within housebound.tt that do not have the page-section class. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Blocks| |31757 Status|NEW |ASSIGNED Version|22.05 |master Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32600 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 145355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145355&action=edit Bug 32600: Housebound module needs page-section treatment This patch adds a .page-section container to two areas in the patron homebound template. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and make sure the HouseboundModule system preference is enabled. - Locate a patron and edit their record. - In the "Housebound roles" section, check both "Chooser" and "Deliverer." - Locate another patron and click on the "Housebound" menu item in the left-hand sidebar. - On the "Manage housebound profile" page, set a delivery day and frequency and save changes. - On the "Housebound details for..." page the details section at the top should be correctly styled. - Click "Add a new delivery." - Fill out some delivery details and click "Save." - Now the "Housebound details for..." page should show a "Deliveries" section which is correctly styled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32600 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32600 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145355|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 145358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145358&action=edit Bug 32600: Housebound module needs page-section treatment This patch adds a .page-section container to two areas in the patron homebound template. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and make sure the HouseboundModule system preference is enabled. - Locate a patron and edit their record. - In the "Housebound roles" section, check both "Chooser" and "Deliverer." - Locate another patron and click on the "Housebound" menu item in the left-hand sidebar. - On the "Manage housebound profile" page, set a delivery day and frequency and save changes. - On the "Housebound details for..." page the details section at the top should be correctly styled. - Click "Add a new delivery." - Fill out some delivery details and click "Save." - Now the "Housebound details for..." page should show a "Deliveries" section which is correctly styled. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32600 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145358|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145820&action=edit Bug 32600: Housebound module needs page-section treatment This patch adds a .page-section container to two areas in the patron homebound template. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and make sure the HouseboundModule system preference is enabled. - Locate a patron and edit their record. - In the "Housebound roles" section, check both "Chooser" and "Deliverer." - Locate another patron and click on the "Housebound" menu item in the left-hand sidebar. - On the "Manage housebound profile" page, set a delivery day and frequency and save changes. - On the "Housebound details for..." page the details section at the top should be correctly styled. - Click "Add a new delivery." - Fill out some delivery details and click "Save." - Now the "Housebound details for..." page should show a "Deliveries" section which is correctly styled. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32600 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32600 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32600 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32600 --- Comment #5 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32600 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32600 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32600 Bug 32600 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org