http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14325 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10900 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14325 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39826&action=edit Bug 14325: Test calls C4::Context::set_userenv This is a case of works by accident. This patch corrects the set_userenv call. TEST PLAN --------- 1) prove t/db_dependent/Borrower_Discharge.t -- works 2) git grep :set_userenv -- only this one file. 3) Confirm the the C4/Context.pm has a set_userenv which shifts the first parameter, as intended for a -> call and not a :: call. 4) apply patch 5) prove t/db_dependent/Borrower_Discharge.t -- still works 6) git grep :set_userenv -- nothing now. 7) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14325 --- Comment #2 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39828&action=edit Bug 14325: Test calls C4::Context::set_userenv This is a case of works by accident. This patch corrects the set_userenv call. TEST PLAN --------- 1) prove t/db_dependent/Borrower_Discharge.t -- works 2) git grep :set_userenv -- only this one file. 3) Confirm the the C4/Context.pm has a set_userenv which shifts the first parameter, as intended for a -> call and not a :: call. 4) apply patch 5) prove t/db_dependent/Borrower_Discharge.t -- still works 6) git grep :set_userenv -- nothing now. 7) run koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14325 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Attachment #39826|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14325 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39828|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 39833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39833&action=edit Bug 14325: Test calls C4::Context::set_userenv This is a case of works by accident. This patch corrects the set_userenv call. TEST PLAN --------- 1) prove t/db_dependent/Borrower_Discharge.t -- works 2) git grep :set_userenv -- only this one file. 3) Confirm the the C4/Context.pm has a set_userenv which shifts the first parameter, as intended for a -> call and not a :: call. 4) apply patch 5) prove t/db_dependent/Borrower_Discharge.t -- still works 6) git grep :set_userenv -- nothing now. 7) run koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14325 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes.