[Bug 10442] New: Remove references to non-standard "error" class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Bug ID: 10442 Summary: Remove references to non-standard "error" class Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org There are a few references in the templates to a very old "error" class which should not be used anymore. Generally speaking '<div class="dialog alert">' should be used instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18824&action=edit Bug 10442 - Remove references to non-standard "error" class The CSS for <div class="error"> is obsolete and should not be used. This patch removes the definition from the main CSS file and corrects instances of its use in the templates to the standard <div class="dialog alert">. This patch also corrects some minor HTML validity and capitalization errors in the changed templates. Testing each error condition in all the modified temlates is probably overkill for the minor changes made in this patch. Markup has simply been changed to use alternate existing styles. Visual confirmation of the markup changes is probably sufficient. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan@catalyst.net.nz --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- I'm not sure that replacing & with & in href was in order -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle@bywatersolutions.com --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Owen, can you please address Srjdan's comment 2? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Srdjan Jankovic from comment #2)
I'm not sure that replacing & with & in href was in order
While not strictly within the scope of the bug, unescaped ampersands are a violation of coding guidelines (invalid HTML) and should be corrected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18824|0 |1 is obsolete| | --- Comment #5 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 19281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19281&action=edit Bug 10442 - Remove references to non-standard "error" class The CSS for <div class="error"> is obsolete and should not be used. This patch removes the definition from the main CSS file and corrects instances of its use in the templates to the standard <div class="dialog alert">. This patch also corrects some minor HTML validity and capitalization errors in the changed templates. Testing each error condition in all the modified temlates is probably overkill for the minor changes made in this patch. Markup has simply been changed to use alternate existing styles. Visual confirmation of the markup changes is probably sufficient. Signed-off-by: Liz Rea <wizzyrea@gmail.com> confirmed the changes - no obvious errors, functionality seems fine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19281|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19296&action=edit [PASSED QA] Bug 10442 - Remove references to non-standard "error" class The CSS for <div class="error"> is obsolete and should not be used. This patch removes the definition from the main CSS file and corrects instances of its use in the templates to the standard <div class="dialog alert">. This patch also corrects some minor HTML validity and capitalization errors in the changed templates. Testing each error condition in all the modified temlates is probably overkill for the minor changes made in this patch. Markup has simply been changed to use alternate existing styles. Visual confirmation of the markup changes is probably sufficient. Signed-off-by: Liz Rea <wizzyrea@gmail.com> confirmed the changes - no obvious errors, functionality seems fine. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. I read the changes and did a few tests in Koha. Some of the error conditions are pretty hard to reproduce, I did manage for lateorders, but didn't succeed for memberentrygen and parcel. But changes appear to be save and I spotted no problems, so passing QA. Patch also fixes a few capitalization errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Comment on attachment 19296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19296 [PASSED QA] Bug 10442 - Remove references to non-standard "error" class Review of attachment 19296: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10442&attachment=19296) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt @@ -171,5 @@
[% END %] </h2>
-<div class="error" style="display:none"></div> -
I'm not sure whether simply removing this is OK. There is code in additem.js that looks for the existence of a div whose CSS class is "error"; if such a div is not present, an error message (e.g., when trying to add a duplicate item) would have no place to be displayed. Setting bug back to "Signed-off" for QA to look into this. If I'm right, additem.js will need to be modified, e.g., to use a div ID rather than a div class to locate the placeholder for an error message. It may be necessary to apply the patch for bug 10483 to be able to test a situation where attempting to add an item during the process of creating a new order results in an error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff CC| |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 --- Comment #8 from Srdjan Jankovic <srdjan@catalyst.net.nz> ---
While not strictly within the scope of the bug, unescaped ampersands are a violation of coding guidelines (invalid HTML) and should be corrected.
Even in href? I'm not sure about that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org