[Bug 36915] New: Send email notification when a booking is cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Bug ID: 36915 Summary: Send email notification when a booking is cancelled Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: thibaud.guillot@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Hello :) I purpose to add an email notification to patron when a booking is cancelled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |thibaud.guillot@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29002 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #1 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 167010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167010&action=edit Bug 36915: Send email notification when a booking is cancelled When a booking is cancelled, patron received an email based on specific letter. Test plan: 1) Create a letter with code "BOOKING_CANCELLATION" on "Notices and slips" tool. 2) Add booking or go on item already booked in advance. 3) Cancel it 4) Verify in message_queue table directly or go on patron page and click on "Notices" tab section. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Shouldn't this be in $booking->delete instead? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167010|0 |1 is obsolete| | --- Comment #3 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 167013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167013&action=edit Bug 36915: Send email notification when a booking is cancelled When a booking is cancelled, patron received an email based on specific letter. Test plan: 1) Create a letter with code "BOOKING_CANCELLATION" on "Notices and slips" tool. 2) Add booking or go on item already booked in advance. 3) Cancel it 4) Verify in message_queue table directly or go on patron page and click on "Notices" tab section. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #4 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to Jonathan Druart from comment #2)
Shouldn't this be in $booking->delete instead?
Thanks for your feedback, you're right.. I was wrong :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- And please provide tests ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36789 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36789 [Bug 36789] Transform a booking into checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37034 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37034 [Bug 37034] Add cronjob to alert patron with bookings ended and not been converted into a loan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I like this, and it was indeed on my enhancements list ;) Couple of comments, however.. 1) Could we pass the bookings object into GetPreparedLetter instead of passing various individual pieces. (Bug 19966 adds this functionality to GetPreperaredLetter, you'd want to pass the object and then call delete at the end of the method after GetPreparredLetter has returned) 2) Could we add a sample notice template too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community |https://bugs.koha-community |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi |?id=29002 |?id=37198 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167013|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168149&action=edit Bug 36915: Send email notification when a booking is cancelled When a booking is cancelled, patron received an email based on specific letter. Test plan: 1) Create a letter with code "BOOKING_CANCELLATION" on "Notices and slips" tool. 2) Add booking or go on item already booked in advance. 3) Cancel it 4) Verify in message_queue table directly or go on patron page and click on "Notices" tab section. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168150&action=edit Bug 36915: (follow-up) Pass object to GetPreparedLetter This patch updates the logic to pass the object to be deleted through to GetPreparedLetter. This way, as we add fields and accessors to the object in the future, they will automatically become available to the notices. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I added the suggested follow-up to utilise the 'objects' option in GetPreparedLetter. Still needs unit tests.. I'll try to take a look at adding those when I can. I'm also working on a default notice template to ship. I do wonder if we really want to tie this to 'delete'.. I'd be tempted to introduce a 'cancel' method to be more explicit. Then if we later introduce database cleanup or other workflows that include deletions we can call the standard delete method without having to work around the cancellation message handling. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168155&action=edit Bug 36915: (follow-up) Basic sample notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36666 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36666 [Bug 36666] Bookings needs some slips and notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #11 from David Nind <david@davidnind.com> --- I've Failed QA because when you preview the notice, there is a huge amount of white space before the actual message. I'm not sure whether this is because of the sample notice, or something else. Either way, I don't know how to fix this (otherwise I would have added a follow-up). Suggestion: - Change the title of the notice to "A library booking was cancelled" - In the notice change "You library" to "Your library" Do we do database updates for new sample notices? Testing notes (using KTD): 1. Apply the patches. 2. Reset everything (so the sample notice is available): reset_all 3. Add an email address to the patron you will make the booking for (for example, Mary Burton, mary@example.com) 4. Add a booking: . Find a record . Go to Items > Priority . Change "Bookable" to "Yes" then click "Update" . Use the "Place booking" action for the record . Enter the details to create a booking (using the patron you added an email address to) 5. Cancel a booking: . Go to the record . Select the Bookings section . Click "Cancel" for the booking you made in step 4 . Click "Confirm" in the pop-up window to cancel the booking 6. Check that a notice was generated: . Go to the notices section for the patron OR . Check the message queue in the database: - koha-mysql kohadev - select * from message_queue; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Speaking to ByWater and their partners using Bookings, they would indeed want to keep the booking around for reports down the line. I think we should add a 'status' field to bookings to track that they have been placed, cancelled, fulfilled and add a 'cancel' method to set it with an optional 'delete' that can be passed would you want to remove the booking rather than just set to cancelled. I'll look into the notice issue highlighted by David too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #13 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 170058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170058&action=edit Bug 36915: (follow-up) Make basic sample notice html and add breaks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Making the sample notice html by setting is_html to true fixes the whitespace problem. I also added David's suggestions to the sample notice while I was at it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168149|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 170077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170077&action=edit Bug 36915: Send email notification when a booking is cancelled When a booking is cancelled, patron received an email based on specific letter. Test plan: 1) Create a letter with code "BOOKING_CANCELLATION" on "Notices and slips" tool. 2) Add booking or go on item already booked in advance. 3) Cancel it 4) Verify in message_queue table directly or go on patron page and click on "Notices" tab section. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168150|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 170078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170078&action=edit Bug 36915: (follow-up) Pass object to GetPreparedLetter This patch updates the logic to pass the object to be deleted through to GetPreparedLetter. This way, as we add fields and accessors to the object in the future, they will automatically become available to the notices. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168155|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 170079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170079&action=edit Bug 36915: (follow-up) Basic sample notice Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170058|0 |1 is obsolete| | --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 170080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170080&action=edit Bug 36915: (follow-up) Make basic sample notice html and add breaks Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement sends a release notes| |notice to a patron when a | |booking is cancelled using | |the new | |BOOKING_CANCELLATION | |notice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #19 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Blockers: Unit tests still needed Questions: Should this notice always be sent? Hold cancellations have a 'reason' and nothing is sent when the reason is skipped. I think we should have something similar here - suppose the library just wants to move the booking to a new edition etc. Should there be a messaging preference? Patrons may not want to receive these notices, are they mandatory? Suggestion: "Your library" in notice is somewhat unclear - is this notice coming from the library who owns the material, or the patron's library? We should use a template "branchname" and display the actual library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #20 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 170099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170099&action=edit Bug 36915: (follow-up) Include branchname in sample notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #21 from Paul Derscheid <paul.derscheid@lmscloud.de> --- That last patch adds the missing branchname of the pickup library to the notice. Other sample notices include a lot of fields of the library object, not sure whether we should do this here as well or the branchname is sufficient. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #22 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 170155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170155&action=edit Bug 36915: (follow-up) Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #23 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Questions:
Should this notice always be sent? Hold cancellations have a 'reason' and nothing is sent when the reason is skipped. I think we should have something similar here - suppose the library just wants to move the booking to a new edition etc.
I'd like to get this thing through and move the cancellation via a cancel method into two follow-up bugs. 1. Add a status column to the bookings table. 2. Move the the notification from delete into cancel and also change the status to 'cancelled' (Child of 1).
Should there be a messaging preference? Patrons may not want to receive these notices, are they mandatory?
This should probably also be it's own bug (Child or 2). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170077|0 |1 is obsolete| | Attachment #170078|0 |1 is obsolete| | Attachment #170079|0 |1 is obsolete| | Attachment #170080|0 |1 is obsolete| | Attachment #170099|0 |1 is obsolete| | Attachment #170155|0 |1 is obsolete| | --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170203&action=edit Bug 36915: Send email notification when a booking is cancelled When a booking is cancelled, patron received an email based on specific letter. Test plan: 1) Create a letter with code "BOOKING_CANCELLATION" on "Notices and slips" tool. 2) Add booking or go on item already booked in advance. 3) Cancel it 4) Verify in message_queue table directly or go on patron page and click on "Notices" tab section. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170204&action=edit Bug 36915: (follow-up) Pass object to GetPreparedLetter This patch updates the logic to pass the object to be deleted through to GetPreparedLetter. This way, as we add fields and accessors to the object in the future, they will automatically become available to the notices. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170205&action=edit Bug 36915: (follow-up) Basic sample notice Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170206&action=edit Bug 36915: (follow-up) Make basic sample notice html and add breaks Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #28 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170207&action=edit Bug 36915: (follow-up) Include branchname in sample notice Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #29 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170208&action=edit Bug 36915: (follow-up) Add tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170203|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170385&action=edit Bug 36915: Send email notification when a booking is cancelled When a booking is cancelled, patron received an email based on specific letter. Test plan: 1) Create a letter with code "BOOKING_CANCELLATION" on "Notices and slips" tool. 2) Add booking or go on item already booked in advance. 3) Cancel it 4) Verify in message_queue table directly or go on patron page and click on "Notices" tab section. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170204|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170386&action=edit Bug 36915: (follow-up) Pass object to GetPreparedLetter This patch updates the logic to pass the object to be deleted through to GetPreparedLetter. This way, as we add fields and accessors to the object in the future, they will automatically become available to the notices. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170205|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170387&action=edit Bug 36915: (follow-up) Basic sample notice Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170206|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170388&action=edit Bug 36915: (follow-up) Make basic sample notice html and add breaks Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170207|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170389&action=edit Bug 36915: (follow-up) Include branchname in sample notice Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170208|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170390&action=edit Bug 36915: (follow-up) Add tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170391&action=edit Bug 36915: (QA follow-up) Passing less to encourage traversal I generally push for contextual use of accessors in TT notices and try to reduce extra lookups. In this case we can access the pickup library branchname directly using the pickup_library relation available to us in the booking object we pass. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- More great teamwork and it's great to see bookings edging forward now. All works really nicely now, no regressions and well tested. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37202 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37202 [Bug 37202] Add a booking reminder notice to let patrons know they have an upcoming booking -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37203 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37203 [Bug 37203] Add a booking is ready to collect notice to let patrons know that their booking is ready to be collected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37204 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 [Bug 37204] Add a booking has changed notice to update a patron should a booking be updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |bookings function| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Are there any plans to make this a patron messaging preference? It seems at the moment this feature can only be turned on/off by adding or deleting the notice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #39 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Yes, there are plans, but we wanted to move the control aspect into follow-up bugs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Paul Derscheid from comment #39)
Yes, there are plans, but we wanted to move the control aspect into follow-up bugs.
Is it an option to have it for this release? I think than we could also do a database update to add the notice by default, as we'd not turn it on for the patrons automatically. Makes it cleaner. Also update path: If we introduce the messaging preference later, we will need to deal with creating "checkboxes" if the notice exists, assuming the library is using it not to deactivate it by accident. Also checking where the notice exists and matching that to the home libraries of the patrons... messier to do later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement sends a |This enhancement sends a release notes|notice to a patron when a |notice to a patron when a |booking is cancelled using |booking is cancelled using |the new |the new |BOOKING_CANCELLATION |BOOKING_CANCELLATION |notice. |notice. | | | |**Sponsored by** | |*BibLibre* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #40)
(In reply to Paul Derscheid from comment #39)
Yes, there are plans, but we wanted to move the control aspect into follow-up bugs.
Is it an option to have it for this release?
I think than we could also do a database update to add the notice by default, as we'd not turn it on for the patrons automatically. Makes it cleaner.
Also update path:
If we introduce the messaging preference later, we will need to deal with creating "checkboxes" if the notice exists, assuming the library is using it not to deactivate it by accident. Also checking where the notice exists and matching that to the home libraries of the patrons... messier to do later.
Never got a reply :( This will make an update later on harder. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38490 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38490 [Bug 38490] All bookings notices should be available in the advanced messaging preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38859 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38859 [Bug 38859] New bookings notices should be added for existing installs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Bug 36915 depends on bug 29002, which changed state. Bug 29002 Summary: Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1117 Documentation| |Aude Charillon contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #43 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Documented in the Manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38490 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38490 [Bug 38490] All bookings notices should be available in the advanced messaging preferences -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org