[Bug 37803] New: Add a booking has been created notice to infrom a patron on successful creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Bug ID: 37803 Summary: Add a booking has been created notice to infrom a patron on successful creation Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: paul.derscheid@lmscloud.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Similarly to notices when a booking has been modified or deleted we should have a notice for a successful creation of a booking for patrons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37204 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 [Bug 37204] Add a booking has changed notice to update a patron should a booking be updated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |bookings function| | Assignee|koha-bugs@lists.koha-commun |paul.derscheid@lmscloud.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a booking has been |Add patron notification |created notice to infrom a |when a new booking has been |patron on successful |created successfully |creation | --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I stumbled on the bug description a little - hope this is OK? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 --- Comment #2 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Sure, you are right. Copied it from Bug 37204 and doctored it a bit too much. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 --- Comment #3 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 170933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170933&action=edit Bug 37803: Add patron notification when a new booking has been created successfully -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 --- Comment #4 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 170934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170934&action=edit Bug 37803: Add patron notification when a new booking has been created successfully To test: 1) Apply the patch 2) Include the sample notice, e.g. run 'reset_all' on ktd 3) Create a booking 4) Look into the borrower notifications 5) Confirm the notice has been generated 6) Run t/db_dependent/Koha/Booking.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170933|0 |1 is obsolete| | Attachment #170934|0 |1 is obsolete| | --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 170935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170935&action=edit Bug 37803: Add patron notification when a new booking has been created successfully To test: 1) Apply the patch 2) Include the sample notice, e.g. run 'reset_all' on ktd 3) Create a booking 4) Look into the borrower notifications 5) Confirm the notice has been generated 6) Run t/db_dependent/Koha/Booking.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Commented the 'Obsoletes' for some reason the first time. Please ignore :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 leb <simonsen@bz-sh.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |simonsen@bz-sh.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170935|0 |1 is obsolete| | --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171066&action=edit Bug 37803: Add patron notification when a new booking has been created successfully To test: 1) Apply the patch 2) Include the sample notice, e.g. run 'reset_all' on ktd 3) Create a booking 4) Look into the borrower notifications 5) Confirm the notice has been generated 6) Run t/db_dependent/Koha/Booking.t Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- I just inserted the signed-off line because the sandbox failed at that step. Just for reference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171066|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172829&action=edit Bug 37803: Add patron notification when a new booking has been created successfully To test: 1) Apply the patch 2) Include the sample notice, e.g. run 'reset_all' on ktd 3) Create a booking 4) Look into the borrower notifications 5) Confirm the notice has been generated 6) Run t/db_dependent/Koha/Booking.t Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- More great work, thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36666 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36666 [Bug 36666] Bookings needs some slips and notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38175 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38175 [Bug 38175] Improve Bookings behavior with new status field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172829|0 |1 is obsolete| | --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173286&action=edit Bug 37803: Add patron notification when a new booking has been created successfully To test: 1) Apply the patch 2) Include the sample notice, e.g. run 'reset_all' on ktd 3) Create a booking 4) Look into the borrower notifications 5) Confirm the notice has been generated 6) Run t/db_dependent/Koha/Booking.t Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This enhancement adds a release notes| |patron notification for | |successful booking | |creation, aligning it with | |existing notices for | |booking modifications and | |deletions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Bug 37803 depends on bug 37204, which changed state. Bug 37204 Summary: Add a booking has changed notice to update a patron should a booking be updated https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Needs documenting --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 24.05.x backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Bug 37803 depends on bug 37204, which changed state. Bug 37204 Summary: Add a booking has changed notice to update a patron should a booking be updated https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Notice template not created for existing installations, is that expected? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #14)
Notice template not created for existing installations, is that expected?
Koha_Main_My8 is failing with: 18:55:44 koha_1 | No bookings BOOKING_CONFIRMATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 610. 18:55:44 koha_1 | 18:55:44 koha_1 | # Failed test 'Koha::Booking->store should have enqueued a BOOKING_CONFIRMATION email for a new booking' 18:55:44 koha_1 | # at t/db_dependent/Koha/Booking.t line 413. 18:55:44 koha_1 | # got: '0' 18:55:44 koha_1 | # expected: '1' 18:55:44 koha_1 | # Looks like you failed 1 test of 2. 18:55:44 koha_1 | 18:55:44 koha_1 | # Failed test 'confirmation notice trigger' 18:55:44 koha_1 | # at t/db_dependent/Koha/Booking.t line 418. 18:55:44 koha_1 | No bookings BOOKING_CONFIRMATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 610. 18:55:44 koha_1 | No bookings BOOKING_MODIFICATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 610. 18:55:44 koha_1 | 18:55:44 koha_1 | # Failed test 'Koha::Booking->store should have enqueued a BOOKING_MODIFICATION email for a booking with modified start_date' 18:55:44 koha_1 | # at t/db_dependent/Koha/Booking.t line 495. 18:55:44 koha_1 | # got: '0' 18:55:44 koha_1 | # expected: '1' 18:55:44 koha_1 | No bookings BOOKING_MODIFICATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 610. 18:55:44 koha_1 | No bookings BOOKING_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 610. 18:55:44 koha_1 | 18:55:44 koha_1 | # Failed test 'Koha::Booking->store should have enqueued a BOOKING_CANCELLATION email for a booking status change that is a "cancellation"' 18:55:44 koha_1 | # at t/db_dependent/Koha/Booking.t line 537. 18:55:44 koha_1 | # got: '0' 18:55:44 koha_1 | # expected: '1' 18:58:14 koha_1 | # Looks like you failed 2 tests of 5. 18:58:14 koha_1 | 18:58:14 koha_1 | # Failed test 'modification/cancellation notice triggers' 18:58:14 koha_1 | # at t/db_dependent/Koha/Booking.t line 542. 18:58:14 koha_1 | DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data truncated for column 'status' at row 1 at /kohadevbox/koha/Koha/Object.pm line 172 18:58:14 koha_1 | # Looks like you failed 2 tests of 16. 18:58:14 koha_1 | 18:58:14 koha_1 | # Failed test 'store() tests' 18:58:14 koha_1 | # at t/db_dependent/Koha/Booking.t line 558. 18:58:14 koha_1 | # Looks like you failed 1 test of 2. 18:58:14 koha_1 | [17:52:23] t/db_dependent/Koha/Booking.t The template is missing because we are running the tests suite after update DB process, not a "normal" installation (using selenium tests, like in Koha_Main) Jenkins config has `export TEST_DB_UPGRADE=yes` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38490 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38490 [Bug 38490] All bookings notices should be available in the advanced messaging preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #14)
Notice template not created for existing installations, is that expected?
Yes, it was to be expected to keep the behavior consistent for updating installations ("lest surprise") and because libraries will need/want to adapt the notices before starting to send them. I am quite sure this is not the only notice we handled it that way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38501 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38501 [Bug 38501] Prevent failures of Koha/Booking.t when run on MySQL8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #16)
(In reply to Jonathan Druart from comment #14)
Notice template not created for existing installations, is that expected?
Yes, it was to be expected to keep the behavior consistent for updating installations ("lest surprise") and because libraries will need/want to adapt the notices before starting to send them.
I am quite sure this is not the only notice we handled it that way.
We now have a patch that fixes the tests: bug 38501 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Aude Charillon contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1117 CC| |aude.charillon@openfifth.co | |.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Bug 37803 depends on bug 37204, which changed state. Bug 37204 Summary: Add a booking has changed notice to update a patron should a booking be updated https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #18 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Documented in the Manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38490 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38490 [Bug 38490] All bookings notices should be available in the advanced messaging preferences -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org