[Bug 20469] New: Add item status to staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Bug ID: 20469 Summary: Add item status to staff article requests form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The Article Requests feature does not look at item status. When you want to process a request, it is useful to show a few fundamental item statuses like Checked out, On hold or Available. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20468 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 [Bug 20468] Multiselect on staff article requests form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 73281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73281&action=edit Bug 20469: Add item status to staff article request form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73281|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 73282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73282&action=edit Bug 20469: Add item status to staff article request form A method Koha::Item->is_waiting_or_transit is added (with tests). The template checks if an item is checked out, on hold (waiting or transit), or is available. (Note: This can be extended in the future in a general include as we have at opac side.) Test plan: [1] Run t/db_dependent/Koha/Items.t [2] Place an article request on an item on loan. Verify status on form. [3] Place an article request on a waiting item. Check status again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 73282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73282 Bug 20469: Add item status to staff article request form Review of attachment 73282: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20469&attachment=73282) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt @@ +42,5 @@
[% END %] +[% BLOCK item_status %][%# pass Koha::Item into myitem %] + [% IF myitem.onloan %]Checked out + [% ELSIF myitem.is_waiting_or_transit %]On hold + [% ELSE %]Available
Just curious about the lack of <span>'s. Does this translate? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to M. Tompsett from comment #3)
Comment on attachment 73282 [details] [review] Bug 20469: Add item status to staff article request form
Review of attachment 73282 [details] [review]: -----------------------------------------------------------------
::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt @@ +42,5 @@
[% END %] +[% BLOCK item_status %][%# pass Koha::Item into myitem %] + [% IF myitem.onloan %]Checked out + [% ELSIF myitem.is_waiting_or_transit %]On hold + [% ELSE %]Available
Just curious about the lack of <span>'s. Does this translate?
Hmm It doesnt. Will add a follow-up. Need them too in the other block. Thx. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 73388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73388&action=edit Bug 20469: (Follow-up) Make translation of status possible As Mark noticed, adding a span for each status will allow for translation. Note that the menu options in the block before are inside html tags like <a><i>..</i>..</a> and will be translated (as long as spaces match). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73282|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 76627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76627&action=edit Bug 20469: Add item status to staff article request form A method Koha::Item->is_waiting_or_transit is added (with tests). The template checks if an item is checked out, on hold (waiting or transit), or is available. (Note: This can be extended in the future in a general include as we have at opac side.) Test plan: [1] Run t/db_dependent/Koha/Items.t [2] Place an article request on an item on loan. Verify status on form. [3] Place an article request on a waiting item. Check status again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73388|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 76628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76628&action=edit Bug 20469: (Follow-up) Make translation of status possible As Mark noticed, adding a span for each status will allow for translation. Note that the menu options in the block before are inside html tags like <a><i>..</i>..</a> and will be translated (as long as spaces match). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76627|0 |1 is obsolete| | Attachment #76628|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76630&action=edit Bug 20469: Add item status to staff article request form A method Koha::Item->is_waiting_or_transit is added (with tests). The template checks if an item is checked out, on hold (waiting or transit), or is available. (Note: This can be extended in the future in a general include as we have at opac side.) Test plan: [1] Run t/db_dependent/Koha/Items.t [2] Place an article request on an item on loan. Verify status on form. [3] Place an article request on a waiting item. Check status again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76631&action=edit Bug 20469: (Follow-up) Make translation of status possible As Mark noticed, adding a span for each status will allow for translation. Note that the menu options in the block before are inside html tags like <a><i>..</i>..</a> and will be translated (as long as spaces match). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why do you return an empty string instead of "0"? IMO we should return ->count, and use the DBIC rs. I will provide a patch and you will tell me what you think about it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76630|0 |1 is obsolete| | Attachment #76631|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77184&action=edit Bug 20469: Add item status to staff article request form A method Koha::Item->is_waiting_or_transit is added (with tests). The template checks if an item is checked out, on hold (waiting or transit), or is available. (Note: This can be extended in the future in a general include as we have at opac side.) Test plan: [1] Run t/db_dependent/Koha/Items.t [2] Place an article request on an item on loan. Verify status on form. [3] Place an article request on a waiting item. Check status again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77185&action=edit Bug 20469: (Follow-up) Make translation of status possible As Mark noticed, adding a span for each status will allow for translation. Note that the menu options in the block before are inside html tags like <a><i>..</i>..</a> and will be translated (as long as spaces match). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77186&action=edit Bug 20469: Use DBIC rs and return ->count -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |NeedsMoreQA --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Koha::Item->is_waiting_or_transit sounds wrong to me, this logic belongs to Koha::Hold Waiting for another QA opinion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #10)
Why do you return an empty string instead of "0"? IMO we should return ->count, and use the DBIC rs.
I will provide a patch and you will tell me what you think about it.
Empty string is the perl default for false. I have seen its use more in the Koha codebase. But I have no objection to your follow-up. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #14)
Koha::Item->is_waiting_or_transit sounds wrong to me, this logic belongs to Koha::Hold Waiting for another QA opinion.
Yeah, I could agree too. Having another look.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|NeedsMoreQA | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 77222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77222&action=edit Bug 20469: (follow-up) Add Koha::Holds->waiting_or_transit Adding this variant next to existing ->waiting and ->unfilled methods. The method will be used in the next patch in Koha::Item. Trivial unit test added in Holds.t Test plan: Run t/db_dependent/Holds.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77184|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 77223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77223&action=edit Bug 20469: Add item status to staff article request form A method Koha::Item->has_waiting_or_transit_hold is added (with tests). The template checks if an item is checked out, on hold (waiting or transit), or is available. (Note: This can be extended in the future in a general include as we have at opac side.) Test plan: [1] Run t/db_dependent/Koha/Items.t [2] Place an article request on an item on loan. Verify status on form. [3] Place an article request on a waiting item. Check status again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> EDIT (July 24, 2018): Method renamed to has_waiting_or_transit_hold. Part of the logic moved to Koha::Holds (see first patch now). Replaced storing undef to found by deleting hold in corresponding subtest of Items.t. Added an additional check in the template for article requests on record level that have no itemnumber (in that case no item status). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 77224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77224&action=edit Bug 20469: (follow-up) Make translation of status possible As Mark noticed, adding a span for each status will allow for translation. Note that the menu options in the block before are inside html tags like <a><i>..</i>..</a> and will be translated (as long as spaces match). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Core change is now: +sub has_waiting_or_transit_hold { + my ( $self ) = @_; + my $rs = $self->_result->reserves; + return Koha::Holds->_new_from_dbic($rs)->waiting_or_transit->count; +} But I am still not completely happy about it. Fetching a result set, wrapping it in Koha object and searching again.. Another approach would be to get the "found => [W, T] " attribute from a class method in Koha Holds and pass it into the DBIx call in Koha Item. Resulting in one search. But also not very nice.. Or add something like Koha::Holds->search_waiting_or_transit({ itemnumber => $x })->count.. What do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Other candidates for a future change? C4/Items.pm: WHERE (found = 'W' OR found = 'T') C4/Members.pm: my $waiting_holds = $patron->holds->search({ found => 'W' }); circ/returns.pl: my $waiting_holds = $patron->holds->search({ found => 'W', branchcode => $userenv_branch })->count; installer/data/mysql/updatedatabase.pl: my $waiting_holds = Koha::Holds->search({ found => 'W', priority => 0 }); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77184|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The "correct" way to do it (regarding the discussion on bug 11983) would be: $patron->holds->filter_by_in_transit->filter_by_waiting But it is not as simple to implement as it sounds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #22)
The "correct" way to do it (regarding the discussion on bug 11983) would be:
$patron->holds->filter_by_in_transit->filter_by_waiting
But it is not as simple to implement as it sounds.
Yeah, this sounds more like transit AND waiting instead of transit OR waiting. And the idea of two filters applied in a row does not look good in terms of performance. I will leave this patch in BLOCKED for the time being. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 [Bug 11983] Code to select patrons to purge needs to be centralized -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #23)
(In reply to Jonathan Druart from comment #22)
The "correct" way to do it (regarding the discussion on bug 11983) would be:
$patron->holds->filter_by_in_transit->filter_by_waiting
But it is not as simple to implement as it sounds.
Yeah, this sounds more like transit AND waiting instead of transit OR waiting.
Yes you are right, it's not equivalent.
And the idea of two filters applied in a row does not look good in terms of performance.
No it will not. DBIx::Class is building the ResultSet, nothing is fetch at this point. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This feels like it doesn't fit in either Koha::Items or Koha::Holds to me and rather, as per my suggestion in bug 11983 comment 8 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983#c8) a Koha::Article::Requests module should be factored out.. we currently have too much business logic directly tied up in the model classes. I don't really see this as a case for filter_by_x and filter_by_y methods actually as the filter, in my opinion, doesn't fit the 'involving complex joins and stuff' category.. rather it's a simple dbic query. I would probably subclass the class most appropriate (Holds or Items.. I'm not sure here) and add the special accessor there. Does this sound sane/make sense or do you want me to attempt to create a counter patch as example code? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- https://wiki.koha-community.org/wiki/Koha_Objects#Subclassing_Koha::Object_a... for guidance around the sort of thing I'm thinking. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Bug 20469 depends on bug 20468, which changed state. Bug 20468 Summary: Multiselect on staff article requests form https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17530 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This got stuck two years ago on a discussion on another report that did not get further either. And now what? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11983 | Status|BLOCKED |ASSIGNED --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Dependency removed. We more or less agreed on what has been discussed in bug 11983, even if not widely used yet we have some filter_by_* methods in Koha:: Can you please rebase, I will have another look. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77184|0 |1 is obsolete| | Attachment #77185|0 |1 is obsolete| | Attachment #77186|0 |1 is obsolete| | Attachment #77222|0 |1 is obsolete| | Attachment #77223|0 |1 is obsolete| | Attachment #77224|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 107235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107235&action=edit Bug 20469: Add item status to staff article request form The template checks if an item is checked out, on hold (waiting or transit), not for loan. (Note: This can be extended in the future in a general include as we have at opac side.) Test plan: [1] Place an article request on an item on loan. Verify status on form. [2] Place an article request on a waiting item. Check status again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> [EDIT] Simplified on 2020-07-23. Removed Koha::Item->is_waiting_or_transit. Added template plugin call ItemTypes->Notforloan. Adjusted commit message accordingly. Additional test: [3] Place an article request on a not for loan item. Check status. NOTE: Not for loan is informational too. It does not say that this item is not available for an article request. Depends on local situation. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 107236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107236&action=edit Bug 20469: Add test for ItemTypes plugin Test plan: Run the test. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Back to SO queue The patch has been simplified. And actually no longer part of the former discussion.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Would not it be better to introduce Koha::Item->itemtype that would return a Koha::ItemType object? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #32)
Would not it be better to introduce Koha::Item->itemtype that would return a Koha::ItemType object?
Yes, good idea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107235|0 |1 is obsolete| | Attachment #107236|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 107412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107412&action=edit Bug 20469: Add Koha::Item->itemtype Also needed to add a missing rollback to preceding subtest. Test plan: Run t/db_dependent/Koha/Item.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #35 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 107413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107413&action=edit Bug 20469: Add item status to staff article request form The template checks if an item is checked out, on hold (waiting or transit), not for loan. (Note: This can be extended in the future in a general include as we have at opac side.) Test plan: [1] Place an article request on an item on loan. Verify status on form. [2] Place an article request on a waiting item. Check status again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> [EDIT] Simplified on 2020-07-27 Removed Koha::Item->is_waiting_or_transit. Use Koha::Item->itemtype to check notforloan on itemtype level. Adjusted commit message accordingly. Additional test: [3] Place an article request on a not for loan item. Check status. NOTE: Not for loan is informational too. It does not say that this item is not available for an article request. Depends on local situation. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I'd remove the effective param, I don't see a case where we would not need it, effective_itemtype will always return the correct value (depending on the pref) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20472 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 [Bug 20472] Add digital scan as optional format to Article Requests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107412|0 |1 is obsolete| | --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 107417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107417&action=edit Bug 20469: Add Koha::Item->itemtype Also needed to add a missing rollback to preceding subtest. Test plan: Run t/db_dependent/Koha/Item.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #38 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 107418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107418&action=edit Bug 20469: Remove effective parameter Test plan: Run test Koha/Item.t again Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107413|0 |1 is obsolete| | --- Comment #39 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 107419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107419&action=edit Bug 20469: Add item status to staff article request form The template checks if an item is checked out, on hold (waiting or transit), not for loan. (Note: This can be extended in the future in a general include as we have at opac side.) Test plan: [1] Place an article request on an item on loan. Verify status on form. [2] Place an article request on a waiting item. Check status again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> [EDIT] Simplified on 2020-07-27 Removed Koha::Item->is_waiting_or_transit. Use Koha::Item->itemtype to check notforloan on itemtype level. Adjusted commit message accordingly. Additional test: [3] Place an article request on a not for loan item. Check status. NOTE: Not for loan is informational too. It does not say that this item is not available for an article request. Depends on local situation. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Thanks Marcel, the patches look great now! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107417|0 |1 is obsolete| | --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108345&action=edit Bug 20469: Add Koha::Item->itemtype Also needed to add a missing rollback to preceding subtest. Test plan: Run t/db_dependent/Koha/Item.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107418|0 |1 is obsolete| | --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108346&action=edit Bug 20469: Remove effective parameter Test plan: Run test Koha/Item.t again Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107419|0 |1 is obsolete| | --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108347&action=edit Bug 20469: Add item status to staff article request form The template checks if an item is checked out, on hold (waiting or transit), not for loan. (Note: This can be extended in the future in a general include as we have at opac side.) Test plan: [1] Place an article request on an item on loan. Verify status on form. [2] Place an article request on a waiting item. Check status again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> [EDIT] Simplified on 2020-07-27 Removed Koha::Item->is_waiting_or_transit. Use Koha::Item->itemtype to check notforloan on itemtype level. Adjusted commit message accordingly. Additional test: [3] Place an article request on a not for loan item. Check status. NOTE: Not for loan is informational too. It does not say that this item is not available for an article request. Depends on local situation. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Nice clean patch. Something similar would be really nice for the item search results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #45 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #43)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thanks ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #47 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org