https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This feels like it doesn't fit in either Koha::Items or Koha::Holds to me and rather, as per my suggestion in bug 11983 comment 8 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983#c8) a Koha::Article::Requests module should be factored out.. we currently have too much business logic directly tied up in the model classes. I don't really see this as a case for filter_by_x and filter_by_y methods actually as the filter, in my opinion, doesn't fit the 'involving complex joins and stuff' category.. rather it's a simple dbic query. I would probably subclass the class most appropriate (Holds or Items.. I'm not sure here) and add the special accessor there. Does this sound sane/make sense or do you want me to attempt to create a counter patch as example code? -- You are receiving this mail because: You are watching all bug changes.