[Bug 37748] New: In Bootstrap 5 "disabled" class must be on anchor tag, not list item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 Bug ID: 37748 Summary: In Bootstrap 5 "disabled" class must be on anchor tag, not list item Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 35402 In Bootstrap 3.x we used <li class="disabled"> for a disabled dropdown menu list item, but now the class should be on the anchor tag inside the <li> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170784&action=edit Bug 37748: In Bootstrap 5 "disabled" class must be on anchor tag, not list item This patch revises the markup for disabled dropdown menu items to conform to Bootstrap 5 requirements. The patch also revises many instances of Bootstrap tooltips which were not working -- tooltips which should be shown with many of the disable dropdown items. In BS5, a tooltip can't be attached to a disabled link. Instead the tooltip must be attached to the link's container. These changes also include the addition of "aria-disabled='true'" to the disabled menu items. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170784|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 170793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170793&action=edit Bug 37748: In Bootstrap 5 "disabled" class must be on anchor tag, not list item This patch revises the markup for disabled dropdown menu items to conform to Bootstrap 5 requirements. The patch also revises many instances of Bootstrap tooltips which were not working -- tooltips which should be shown with many of the disable dropdown items. In BS5, a tooltip can't be attached to a disabled link. Instead the tooltip must be attached to the link's container. These changes also include the addition of "aria-disabled='true'" to the disabled menu items. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This updates the mark-up release notes| |for non-active dropdown | |menu items. It also updates | |how tooltips work with | |non-active dropdown menu | |options. After the OPAC and | |staff interface Bootstrap 5 | |upgrade in Koha 24.11, the | |non-active dropdown menu | |items were not greyed out, | |and some tooltips were not | |working as they should. --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. For a staff patron (such as Henry), update their permissions so that they can access the staff interface, but not set permissions for other patrons. 2. Log in as that staff patron, and for a patron (for example, Mary) got to More > Set permissions. 3. Note that there is no differentiation with the other menu items, and that there is a hover message "You are not authorized to set permissions". 4. Another place to check is Acquisitions > Administration > Budgets. For the main budget actions menu, Delete and + Add fund. 5. After aplying the patch and rebuilding the CSS (yarn build) notice that the "Set permission" option (and other non-active options) are greyed out. Note about tooltips: 1. I did note that the tool tip message is now larger in the patron area - more spacing around the text, which is larger (and more readable, for me anyway). 2. In the Budget/funds area, the tooltip is smaller (text size and less spacing around the text). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Text to go in the|This updates the mark-up | release notes|for non-active dropdown | |menu items. It also updates | |how tooltips work with | |non-active dropdown menu | |options. After the OPAC and | |staff interface Bootstrap 5 | |upgrade in Koha 24.11, the | |non-active dropdown menu | |items were not greyed out, | |and some tooltips were not | |working as they should. | --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- It's not working on "Update child to adult patron". It is missing `$('[data-bs-toggle="tooltip"]').tooltip()` We will need to add it for the whole members module. Don't you think we should actually have it directly in staff-global to affect all templates? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170804&action=edit Bug 37748: (follow-up) Move tooltip initialization to staff-global.js This patch moves generic initializations of Bootstrap tooltips into staff-global.js. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #4)
It's not working on "Update child to adult patron".
Thanks for testing Jonathan. After all that work hoping it would get the "update child" selenium test working I forgot to test the "update child" link X(
should actually have it directly in staff-global to affect all templates?
The follow-up patch does so. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170807&action=edit Bug 37748: Adjust the 'Update child to patron' selenium test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- 1. should we remove this? koha-tmpl/intranet-tmpl/prog/js/messaging-preference-form.js: $('#memberentry_messaging_prefs [data-bs-toggle="tooltip"][disabled]').tooltip();  2. In koha-tmpl/intranet-tmpl/prog/js/catalog.js 121 $('[data-bs-toggle="tooltip"]').on("click",function(e){ 122 e.stopPropagation(); 123 }).tooltip(); Shouldn't we have 'disabled' instead of this on click? 3. same in koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt 4. This one certainly needs to be removed: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt: $('[data-bs-toggle="tooltip"]').tooltip(); => From Owen "The item search one is necessary because the tooltips have to be initialized after the table is drawn and the buttons updated" 5. Is this still relevant? koha-tmpl/intranet-tmpl/prog/js/members-menu.js: $("#updatechild, #patronflags, #renewpatron, #deletepatron, #exportbarcodes").tooltip(); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170804|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170818&action=edit Bug 37748: (follow-up) Move tooltip initialization to staff-global.js This patch moves generic initializations of Bootstrap tooltips into staff-global.js. Templates which included custom tooltip initialization have been updated to use the global function. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #8)
2. In koha-tmpl/intranet-tmpl/prog/js/catalog.js
121 $('[data-bs-toggle="tooltip"]').on("click",function(e){ 122 e.stopPropagation(); 123 }).tooltip(); Shouldn't we have 'disabled' instead of this on click?
This code was in a couple places but not everywhere... the idea being that if you try to click a disabled menu item the menu doesn't automatically close. This gives the user a chance to look again and see the tooltip explaining why the option is disabled. I removed the two unusually cases but we ought to talk about whether that is the desirable behavior for all disabled menu items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170793|0 |1 is obsolete| | Attachment #170807|0 |1 is obsolete| | Attachment #170818|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170819&action=edit Bug 37748: In Bootstrap 5 "disabled" class must be on anchor tag, not list item This patch revises the markup for disabled dropdown menu items to conform to Bootstrap 5 requirements. The patch also revises many instances of Bootstrap tooltips which were not working -- tooltips which should be shown with many of the disable dropdown items. In BS5, a tooltip can't be attached to a disabled link. Instead the tooltip must be attached to the link's container. These changes also include the addition of "aria-disabled='true'" to the disabled menu items. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170820&action=edit Bug 37748: Adjust the 'Update child to patron' selenium test Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170821&action=edit Bug 37748: (follow-up) Move tooltip initialization to staff-global.js This patch moves generic initializations of Bootstrap tooltips into staff-global.js. Templates which included custom tooltip initialization have been updated to use the global function. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Owen, can you confirm you went through all the points of comment 8? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #14)
Owen, can you confirm you went through all the points of comment 8?
Yes: (In reply to Jonathan Druart from comment #8)
1. should we remove this?
Removed. 
2. In koha-tmpl/intranet-tmpl/prog/js/catalog.js 3. same in koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt
Removed. See comment 10.
5. Is this still relevant? koha-tmpl/intranet-tmpl/prog/js/members-menu.js: $("#updatechild, #patronflags, #renewpatron, #deletepatron, #exportbarcodes").tooltip();
Removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170819|0 |1 is obsolete| | Attachment #170820|0 |1 is obsolete| | Attachment #170821|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170860&action=edit Bug 37748: In Bootstrap 5 "disabled" class must be on anchor tag, not list item This patch revises the markup for disabled dropdown menu items to conform to Bootstrap 5 requirements. The patch also revises many instances of Bootstrap tooltips which were not working -- tooltips which should be shown with many of the disable dropdown items. In BS5, a tooltip can't be attached to a disabled link. Instead the tooltip must be attached to the link's container. These changes also include the addition of "aria-disabled='true'" to the disabled menu items. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170861&action=edit Bug 37748: Adjust the 'Update child to patron' selenium test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170862&action=edit Bug 37748: (follow-up) Move tooltip initialization to staff-global.js This patch moves generic initializations of Bootstrap tooltips into staff-global.js. Templates which included custom tooltip initialization have been updated to use the global function. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38049 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38049 [Bug 38049] Admin/RecordSources_spec.ts is still failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 Bug 37748 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org