[Bug 38739] New: Templates not ending with include intranet-bottom.inc in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Bug ID: 38739 Summary: Templates not ending with include intranet-bottom.inc in staff interface Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Some templates in staff interface do not end with include intranet-bottom.inc.
tail -n1 koha-tmpl/intranet-tmpl/prog/en/modules/*/*.tt | grep -B2 '</html>'
==> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/showorder.tt <== </html> -- ==> koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt <== </html> ==> koha-tmpl/intranet-tmpl/prog/en/modules/basket/downloadcart.tt <== </html> ==> koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasketform.tt <== </html> ==> koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt <== </html> -- ==> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/showelastic.tt <== </html> ==> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/showmarc.tt <== </html> -- ==> koha-tmpl/intranet-tmpl/prog/en/modules/reports/convert_report.tt <== </html> -- ==> koha-tmpl/intranet-tmpl/prog/en/modules/tools/preview_letter.tt <== </html> -- ==> koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/downloadshelf.tt <== </html> ==> koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelfform.tt <== </html> So for example it does not call hook "intranet_js". Should all templates end with this include ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38740 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Popup windows and pages like showmarc.tt which are loaded via AJAX do not need the full contents of intranet-bottom. We would either need to add some logic to intranet-bottom.inc or add a different, trimmed-down version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- *** Bug 38740 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt calls : [% INCLUDE 'intranet-bottom.inc' popup_window=1 %] That will add ending tags body and html this must be at the end -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30707 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- other suspects : koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-report-search-result.inc koha-tmpl/intranet-tmpl/prog/en/modules/admin/file_transports.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/cn_browser.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_210c_bis.tt koha-tmpl/intranet-tmpl/prog/en/modules/reserve/hold-group.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_modify_holds.tt
Should all templates end with this include ? Nope, some blocks may exist after it. Also there is the example curbside_pickups.tt with : [% UNLESS policy.enabled %] <div class="alert alert-warning"> Curbside pickups are not enabled for your library. </div> [% INCLUDE 'intranet-bottom.inc' %] [% STOP %] [% END %]
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38740 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Check with : git grep -A1 "INCLUDE 'intranet-bottom.inc'" | grep -v INCLUDE | grep '</' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37033 CC| |jonathan.druart@gmail.com --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Fridolin Somers from comment #3)
koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt calls : [% INCLUDE 'intranet-bottom.inc' popup_window=1 %] That will add ending tags body and html this must be at the end
Caused by bug 37033. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37033 [Bug 37033] Allow plugins to load JavaScript on the cart pop-up in the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31339 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187506&action=edit Bug 38739: Fix mana-report-search-result.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187507&action=edit Bug 38739: Fix admin/file_transports.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187508&action=edit Bug 38739: Fix tools/batch_modify_holds.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187509&action=edit Bug 38739: Fix some other wrong templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187510&action=edit Bug 38739: Fix basket/basket.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36135 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39190 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Assignee|oleonard@myacpl.org |jonathan.druart@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #12 from David Nind <david@davidnind.com> --- Not sure how to test this one. Changed the assignee. The patches no longer apply 8-(... git bz apply 38739 Bug 38739 - Templates not ending with include intranet-bottom.inc in staff interface 187506 - Bug 38739: Fix mana-report-search-result.inc 187507 - Bug 38739: Fix admin/file_transports.pl 187508 - Bug 38739: Fix tools/batch_modify_holds.tt 187509 - Bug 38739: Fix some other wrong templates 187510 - Bug 38739: Fix basket/basket.tt Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 38739: Fix mana-report-search-result.inc Applying: Bug 38739: Fix admin/file_transports.pl Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/admin/file_transports.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/file_transports.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/file_transports.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 38739: Fix admin/file_transports.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187506|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187507|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187508|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187509|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187510|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190335&action=edit Bug 38739: Fix mana-report-search-result.inc Patch from commit e55c96c -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190336&action=edit Bug 38739: Fix admin/file_transports.pl Patch from commit c017f7a -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190337&action=edit Bug 38739: Fix some other wrong templates Patch from commit 5cd3df6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190338&action=edit Bug 38739: Fix basket/basket.tt Patch from commit 3178c9a -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190339&action=edit Bug 38739: Fix tools/batch_modify_holds.tt Patch from commit a52c574 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Test plan: Use `git show -w` on the different commit to confirm that: * main-container.inc is used to replace the div.main and main tags * the extra closing div tag at the end of the files is removed You can also test the UI and confirm that the sidebar is correctly displayed on the different pages modified by those patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190335|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190336|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190337|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190338|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190339|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190340&action=edit Bug 38739: Fix mana-report-search-result.inc Patch from commit c4c0853 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190341&action=edit Bug 38739: Fix admin/file_transports.pl Patch from commit a10f7ee -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190342&action=edit Bug 38739: Fix some other wrong templates Patch from commit 7c8466c -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190343&action=edit Bug 38739: Fix basket/basket.tt Patch from commit dd70679 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #23 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190344&action=edit Bug 38739: Fix tools/batch_modify_holds.tt Patch from commit 27ac86a -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190340|0 |1 is obsolete| | Attachment #190341|0 |1 is obsolete| | Attachment #190342|0 |1 is obsolete| | Attachment #190343|0 |1 is obsolete| | Attachment #190344|0 |1 is obsolete| | --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 190421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190421&action=edit Bug 38739: Fix mana-report-search-result.inc Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 190422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190422&action=edit Bug 38739: Fix admin/file_transports.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 190423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190423&action=edit Bug 38739: Fix some other wrong templates Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 190424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190424&action=edit Bug 38739: Fix basket/basket.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #28 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 190425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190425&action=edit Bug 38739: Fix tools/batch_modify_holds.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #29 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 190426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190426&action=edit Bug 38739: (follow-up) Remove extra messages.inc include Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190421|0 |1 is obsolete| | --- Comment #30 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190780&action=edit Bug 38739: Fix mana-report-search-result.inc Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190422|0 |1 is obsolete| | --- Comment #31 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190781&action=edit Bug 38739: Fix admin/file_transports.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190423|0 |1 is obsolete| | --- Comment #32 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190782&action=edit Bug 38739: Fix some other wrong templates Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190424|0 |1 is obsolete| | --- Comment #33 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190783&action=edit Bug 38739: Fix basket/basket.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190425|0 |1 is obsolete| | --- Comment #34 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190784&action=edit Bug 38739: Fix tools/batch_modify_holds.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190426|0 |1 is obsolete| | --- Comment #35 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 190785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190785&action=edit Bug 38739: (follow-up) Remove extra messages.inc include Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #36 from Victor Grousset/tuxayo <victor@tuxayo.net> --- I've been going at the changed pages and doing a diff before and after the patches on - the final HTML in the inspector (after eventual JS does it's stuff, but the browser will fix some stuff like stray tags) - the HTTP response And also comparing the HTMLs results the W3C validator. The changes are great, in hold-group.tt, on main, the cookieConsentBar was duplicated :o In the final html in the inspector, it is also present in the holds group modal. It was invisible but still, it was there and duplicated. So now it's fixed. audio-alert was also duplicated. Overall on the pages, several unclosed <div> are fixed. I think also some other tags that were stray. Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #37 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This update fixes release notes| |inconsistencies in template | |markup which could cause | |duplicated page elements, | |JavaScript errors, and | |errors in HTML validation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739 --- Comment #38 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- All pushed to 25.11.x Thanks all! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org