[Bug 42143] New: The breadcrumbs on Patron pages render an empty link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 Bug ID: 42143 Summary: The breadcrumbs on Patron pages render an empty link Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: blawlor@clamsnet.org QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org Go to a page like http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 Tab through the breadcrumbs and notice there is an empty link before the link to the patron record. Copy the page source and paste in the W3C Markup Validation Service Notice the errors: Error: Start tag a seen but an element of the same type was already open. Error: Stray end tag a. This violates WCAG 1. 2.4.4 Link Purpose (In Context) (Level A) because a screen reader can't announce the purpose of the link. This is a duplicate nested link and can be removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |blawlor@clamsnet.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 --- Comment #1 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 195702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195702&action=edit Bug 42143: Remove empty duplicate links from patron breadcrumbs This patch imporves accessibility for screen readers by removing a duplicate empty link that is rendered in the breadcrumbs on patron pages. patron-title.inc already includes the links and doesn't need to be wrapped in <a> element. To test: 1. Go to a patron record and tab through the breadcrumbs 2. Notice there is an empty link that is invisible but gets focus between the Patrons and <patron title> breadcrumbs. 3. Check the other tabs to confirm the issue is present Accounting, Routing list, Circulation history, Holds history, Notices, Statistics and Purchase suggestions 4. Click edit and check the breadcrumbs on that page 5. Enable TwoFactorAuthentication and check the manage two-factor auth page 6. Apply patch 7. Revist the pages from steps 1-5 and tab through the breadcrumbs again 8. Confirm there is no duplicate empty link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch improves release notes| |accessibility for screen | |readers by removing a | |duplicate empty link that | |was rendered in the | |breadcrumbs on patron | |pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195702|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 195707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195707&action=edit Bug 42143: Remove empty duplicate links from patron breadcrumbs This patch imporves accessibility for screen readers by removing a duplicate empty link that is rendered in the breadcrumbs on patron pages. patron-title.inc already includes the links and doesn't need to be wrapped in <a> element. To test: 1. Go to a patron record and tab through the breadcrumbs 2. Notice there is an empty link that is invisible but gets focus between the Patrons and <patron title> breadcrumbs. 3. Check the other tabs to confirm the issue is present Accounting, Routing list, Circulation history, Holds history, Notices, Statistics and Purchase suggestions 4. Click edit and check the breadcrumbs on that page 5. Enable TwoFactorAuthentication and check the manage two-factor auth page 6. Apply patch 7. Revist the pages from steps 1-5 and tab through the breadcrumbs again 8. Confirm there is no duplicate empty link Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Thanks Brendan! There were a couple of other areas that require this as well I think: - The patron "Recalls history" page: enable the UseRecalls system preference (no need to set any circulation rules). - More > Set permissions. - More > Delete. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 --- Comment #4 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 195708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195708&action=edit Bug 42143: (follow-up) Remove empty duplicate links from patron breadcrumbs Patch from commit 3e38de9 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 --- Comment #5 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks for testing and catching those other spots, David! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195707|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195708|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 196024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196024&action=edit Bug 42143: Remove empty duplicate links from patron breadcrumbs This patch imporves accessibility for screen readers by removing a duplicate empty link that is rendered in the breadcrumbs on patron pages. patron-title.inc already includes the links and doesn't need to be wrapped in <a> element. To test: 1. Go to a patron record and tab through the breadcrumbs 2. Notice there is an empty link that is invisible but gets focus between the Patrons and <patron title> breadcrumbs. 3. Check the other tabs to confirm the issue is present Accounting, Routing list, Circulation history, Holds history, Notices, Statistics and Purchase suggestions 4. Click edit and check the breadcrumbs on that page 5. Enable TwoFactorAuthentication and check the manage two-factor auth page 6. Apply patch 7. Revist the pages from steps 1-5 and tab through the breadcrumbs again 8. Confirm there is no duplicate empty link Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 196025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196025&action=edit Bug 42143: (follow-up) Remove empty duplicate links from patron breadcrumbs Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42143 --- Comment #9 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org