[Bug 9676] New: Replace YUI buttons on authorities editor page with Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9676 Bug ID: 9676 Summary: Replace YUI buttons on authorities editor page with Bootstrap Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/authorities/authorities.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org Depends on: 9672 The toolbar buttons on the authorities editing page (authorities.pl) are constructed using YUI. They should use Bootstrap instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9676 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9676 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15574&action=edit Bug 9676 - Replace YUI buttons on authorities editor page with Bootstrap This patch converts the "Save" button on the authorities editor page to Bootstrap, replacing YUI button code with Bootstrap markup. This patch also adds the float effect to the toolbar to match that on the MARC editor page. To test, create a new authority or load an existing one. The "Save" button should look correct and work correctly. When you scroll the page down, the toolbar should "stick" to the top of the browser window so that the "Save" button stays visible. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9676 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15574|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15597&action=edit [SIGNED-OFF] Bug 9676 - Replace YUI buttons on authorities editor page with Bootstrap This patch converts the "Save" button on the authorities editor page to Bootstrap, replacing YUI button code with Bootstrap markup. This patch also adds the float effect to the toolbar to match that on the MARC editor page. To test, create a new authority or load an existing one. The "Save" button should look correct and work correctly. When you scroll the page down, the toolbar should "stick" to the top of the browser window so that the "Save" button stays visible. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Button works and looks good. The toolbart sticks when scrolling, but I see a gap between the box of the save button, and the top of the window (tested with chrome, opera, firefox). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9676 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9676 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #2)
but I see a gap between the box of the save button, and the top of the window (tested with chrome, opera, firefox).
This issue is addressed in a change to the global CSS file. Clearing your browser cache should fix it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9676 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9676 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15597|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15831&action=edit [PASSED QA] Bug 9676 - Replace YUI buttons on authorities editor page with Bootstrap This patch converts the "Save" button on the authorities editor page to Bootstrap, replacing YUI button code with Bootstrap markup. This patch also adds the float effect to the toolbar to match that on the MARC editor page. To test, create a new authority or load an existing one. The "Save" button should look correct and work correctly. When you scroll the page down, the toolbar should "stick" to the top of the browser window so that the "Save" button stays visible. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Button works and looks good. The toolbart sticks when scrolling, but I see a gap between the box of the save button, and the top of the window (tested with chrome, opera, firefox). Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9676 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9676 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9676 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 8151 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org